The Weird and The Wonderful

GibbleCH wrote:

And what the heck kind of code would they put in the else if you don't technically need an else?

if (dt == NULL)
	return false;
if (dt.Rows.Count == 0)
	return false;
 
return (t.Rows[0]["Number"].ToString() == "1");

vnike wrote:

They break the clients when modified.

PIEBALDconsult wrote:

And how about removing the .ToString and .Equals ?

Chris Meech wrote:

The slower they work, the better.

if (node.Attributes["Publish"].InnerText.Trim().Contains(s))
                {
                    return;
                }

public static ArrayList NonTranslatable
        {
            get
            {
                nonTranslatable.Add("1st String");
                nonTranslatable.Add("2nd String");
                // ...
                nonTranslatable.Add("30th String");
                return nonTranslatable;
            }
        }

foreach (DictionaryEntry de in translationDictionary)
            {
                if (de.Key.ToString().Equals(node.Attributes["Publish"].InnerText.Trim()))
                    node.Attributes["Publish"].InnerText
                            = translationDictionary[node.Attributes["Publish"].InnerText.Trim()].ToString();
            }

Timothy Byrd wrote:

Simply putting an if (nonTranslatable.Count == 0) block around the code in the NonTranslatable property took the run time down from >75 minutes to ~30 seconds. (Fun fact: During the 75 minutes of processing, those repeated Add() calls caused the program to take up about 25MB of extra memory. That's a lot of strings to loop through and compare repeatedly. OMG )

Timothy Byrd wrote:

Not to mention all the calls to Trim() inside the loop. Or does the runtime optimize those out as invariant?

Megidolaon wrote:

What is the point of

if (node.Attributes["Publish"].InnerText.Trim().Contains(s))
{
    return;
}

A check for containting a single letter and then doing nothing?

Megidolaon wrote:

Maybe the XML contains trailing spaces?
Unless you trim them, the XML Nodes' InnerText wouldn't equal the DictionaryEntries with same

string xmlText = node.Attributes["Publish"].InnerText.Trim();