The Weird and The Wonderful

bool InitRoutine()
    {
    bool failed=false;
 
    ValType val;
 
    HRESULT ans = GetValue1(val);
    if (ans==S_OK)
        {
        globalVal1 = val;
        }
    else
        {
        failed = failed || true;
        }
 
    ans = GetValue2(val);
    if (ans==S_OK)
        {
        globalVal2 = val;
        }
    else
        {
        failed = failed || true;
        }
 
    ans = GetValue3(val);
    if (ans==S_OK)
        {
        globalVal3 = val;
        }
    else
        {
        failed = failed || true;
        }
 
    ans = GetValue4(val);
    if (ans==S_OK)
        {
        globalVal4 = val;
        }
    else
        {
        failed = failed || true;
        }
 

    return !failed;
    }

// Only proceed id if 'dt' is valid and contains at least one row.
if (dt == NULL)
	return false;
if (dt.Rows.Count == 0)
	return false;
 
return (t.Rows[0]["Number"].ToString() == "1");

return dt != null && dt.Rows.Count > 0 && (int)t.Rows[0]["Number"] == 1;

The last part depends on the data the table contains. But if its clear that the column is filled with integers then this should be more efficient.

qualitychecker wrote:

Still depends on the precedence priorities of the language

qualitychecker wrote:

always put constants first

qualitychecker wrote:

provide debugging / tracing points in case of future problems

PIEBALDconsult wrote:

If you can remember to do that, you're smart enough not to make that mistake in the first place.