The Weird and The Wonderful

The Weird and The Wonderful forum is a place to post Coding Horrors, Worst Practices, and the occasional flash of brilliance.

We all come across code that simply boggles the mind. Lazy kludges, embarrassing mistakes, horrid workarounds and developers just not quite getting it. And then somedays we come across - or write - the truly sublime.

Post your Best, your worst, and your most interesting. But please - no programming questions . This forum is purely for amusement and discussions on code snippets. All actual programming questions will be removed.

Re: Another Horror

Sauce!1-Oct-08 23:01

Sauce!

1-Oct-08 23:01

if(a==1 || a==2 || a==3 || a==4) { if(a==1) DoSomething(1); else if(a==2) DoSomething(2); else if(a==3) DoSomething(3); else if(a==4) DoSomething(4); }

DoSomething(a);

Re: Another Horror

ChrisKiki6-Oct-08 0:27

ChrisKiki

6-Oct-08 0:27

big LOL, maybe this is how the runtime actually works Poke tongue | ;-P

This is just for the laugh of it.

adamsappel22-Sep-08 2:24

adamsappel

22-Sep-08 2:24

Hi. Background: Co-Worker, (Female <- not biased, just stating the fact), Qualification: Architect...
(btw, this is all C# VS2008 code, I swear)

Ok, one for the count:

public static bool NameExists (string name)
{
   bool exists = false;
   int i = 0;
   while ((i < someListContainingNames.Count) && (exists == false))
   {
      if (someListContainingNames[i] == filename)
      {
         exists = true;
      }
      i++;
   }
   return exists;
}

Please see if you can read this... (Original code kept):

else if (   ((isEXEDLL == true) || (isEXEConfig == true))
         && ((staysTheSameEXEDLL == false) || (EXEDLLPathExistsSoCanProcess == true))
         )
{
   if (  ((isEXEDLL == true) || (isEXEConfig == true))
      && (staysTheSameEXEDLL == false)
      )
   {
      if (canCopy.DoCopy == true)
      {

Spot the redundency (Regex's left out):

string str = "";
string str2 = "";
Regex regex1 = new Regex(regex1String, RegexOptions.IgnoreCase);
Regex regex2 = new Regex(regex2String, RegexOptions.IgnoreCase);
Regex regex3 = new Regex(regex3String, RegexOptions.IgnoreCase);
Regex regex4 = new Regex(regex4String, RegexOptions.IgnoreCase);

if (regex1.IsMatch(filename))
{
   str = regex1.Match(filename).Groups["code"].Value.ToUpper();
   str2 = regex1.Match(filename).Groups["type"].Value.ToUpper();
}
else if (regex2.IsMatch(filename))
{
   str = regex2.Match(filename).Groups["code"].Value.ToUpper();
   str2 = regex2.Match(filename).Groups["type"].Value.ToUpper();
}
else if (regex3.IsMatch(filename))
{
   str = regex3.Match(filename).Groups["code"].Value.ToUpper();
   str2 = regex3.Match(filename).Groups["type"].Value.ToUpper();
}
else if (regex4.IsMatch(filename))
{
   str = regex4.Match(filename).Groups["code"].Value.ToUpper();
   str2 = regex4.Match(filename).Groups["type"].Value.ToUpper();
}
else
{
   str = "";
   str2 = "";
}

if (  (regex1.IsMatch(filename))
   || (regex2.IsMatch(filename))
   || (regex3.IsMatch(filename))
   || (regex4.IsMatch(filename))
   )
{

Didn't get that one? Try this one:

if (dr.GetValue(dr.GetOrdinal("Copy")).ToString().Trim() == "1")
   copyChecked = true;
else
   copyChecked = false;

Ok, now I'm not pedantic, this I can promise you, but when you come across something like this little gem... (Only method name and class type changed...)

public static bool MethodName(ObjectWithBoolean objectThatHasBool)
{
   if (objectThatHasBool.booleanValue)
   {
      return false;
   }
   else
   {
      return true;
   }
}

Last, but DEFINITELY not the least, here's a little sql query that my "collegue" wrote. See if you can spot the query:

StringBuilder queryString = new StringBuilder();
//this is the query that updates the actual data
queryString.Append("IF EXISTS ");
queryString.Append("(SELECT ID ");
queryString.Append("FROM ");
queryString.Append("Table1 ");
queryString.Append("WHERE ID = ");
queryString.Append(id);
queryString.Append(") ");
queryString.Append("BEGIN ");
queryString.Append("UPDATE ");
queryString.Append("Table1 SET ");
queryString.Append("ComlumnValue1 = ");
queryString.Append("'");
queryString.Append(Value1);
queryString.Append("' ");
queryString.Append(", ComlumnValue2 = ");
queryString.Append(Value2);
queryString.Append(", ComlumnValue3 = ");
queryString.Append(Value3);
queryString.Append(" WHERE ID = ");
queryString.Append("'");
queryString.Append(id);
queryString.Append("' ");
queryString.Append("AND ");
queryString.Append("(ISNULL(ComlumnValue1,0) <> ");
queryString.Append("'");
queryString.Append(Value1);
queryString.Append("' ");
queryString.Append(" OR ");
queryString.Append("ISNULL(ComlumnValue2,0) <> ");
queryString.Append(Value2);
queryString.Append(" OR ");
queryString.Append("ISNULL(ComlumnValue3,0) <> ");
queryString.Append(Value3);
queryString.Append(") ");
queryString.Append(" END ");
queryString.Append("ELSE BEGIN declare @ID int ");
queryString.Append("exec ssl_GetTable1CallSeq 1, ");
queryString.Append("@ID OUTPUT ");
queryString.Append("IF ");
queryString.Append("NOT EXISTS(SELECT * FROM Table1 WHERE ID = ");
queryString.Append(id);
queryString.Append(") ");
queryString.Append("INSERT ");
queryString.Append("INTO Table1 (ID, Name, ");
queryString.Append("ComlumnValue1, ");
queryString.Append("ComlumnValue2, ");
queryString.Append("ComlumnValue3) ");
queryString.Append("VALUES ");
queryString.Append("(@ID, ");
queryString.Append("'");
queryString.Append(name);
queryString.Append("', ");
queryString.Append("'");
queryString.Append(Value1);
queryString.Append("', ");
queryString.Append(Value2);
queryString.Append(", ");
queryString.Append(Value3);
queryString.Append(" ) END ");

command.CommandText = queryString.ToString();

Thanks for listening to my little rant. Any comments very welcome, Smile | :)