|
That isn't our company code! Just see how many WTFs are there apparently within a few lines of code.
Nobody can give you wiser advice than yourself. - Cicero
.·´¯`·->ßRÅhmmÃ<-·´¯`·.
|
|
|
|
|
Maybe it's only for those numbers that it should be decremented again, in which case a simple range check would suffice rather than what was provided.
|
|
|
|
|
This is a s/w that deals with a list of human interface devices. There are two APIs, namely getPortCount(DWORD devID) and getNextPort(DWORD devID) (from the docs that we got), that would assist you in the very range check that you're talking about. Clearly, the dumbass guy who wrote it did not bother to open the docs.
That solved, there's a new WTF. The next issue listed is that the app crashes on 64 bit machines.
I can read it in the docs that these numbers, which were hard coded in the original code WILL vary on a 64 bit machine! 
Nobody can give you wiser advice than yourself. - Cicero
.·´¯`·->ßRÅhmmÃ<-·´¯`·.
|
|
|
|
|
brahmma wrote: app crashes on 64 bit machines.
You mean there are apps that don't! 
(Sorry been installing Vista Ultimate (x64) onto a machine and had fun finding drivers for it. Although everything is working (amazingly) but then most of the hardware is only a few months old.
|
|
|
|
|
brahmma wrote: the coder did not know of the term called "decrement operator"
I am reminded of Abhimanyu's story (http://en.wikipedia.org/wiki/Abhimanyu[^]) This guy knew one part of story of incrementing the variable but not the other part of decrementing it. 
|
|
|
|
|
Naah!!! You shouldn't be comparing this idiot guy with Abhimanyu.
Nobody can give you wiser advice than yourself. - Cicero
.·´¯`·->ßRÅhmmÃ<-·´¯`·.
|
|
|
|
|
Now I'm reminded of a Mad Magazine (or possibly Caldwell) cartoon from the '70s. Moses; having parted the Red Sea and the Hebrews having crossed, the last guy through says, "OK you can close it up now", and Moses is thinking, "Close it up?"
-- modified at 13:01 Wednesday 12th September, 2007
|
|
|
|
|
Deja View - the feeling that you've seen this post before.
|
|
|
|
|
From five ifs to Moses, that's a stretch.
BTW: Microsoft had not yet invented Dispose() at that time
Luc Pattyn [Forum Guidelines] [My Articles]
this weeks tips:
- make Visual display line numbers: Tools/Options/TextEditor/...
- show exceptions with ToString() to see all information
- before you ask a question here, search CodeProject, then Google
|
|
|
|
|
A classical reference... Cool!
|
|
|
|
|
jhwurmbach wrote: And what makes 20 different from 21?
Makes a big difference in BlackJack
|
|
|
|
|
The arcane magic of business logic.
|
|
|
|
|
brahmma wrote: I've got absolutely no freakin' idea what the guy was trying to do there
Out of context it is impossible to guess, but over a limited range the code (rather clumsily) does
if (i%7 == 6) i--;
Peter
"Until the invention of the computer, the machine gun was the device that enabled humans to make the most mistakes in the smallest amount of time."
|
|
|
|
|
it has a range though.. so i == 6 should not be included. maybe put all the special values in an array then check it with a loop. though the code in the first place looked bad. he/she should practice putting some comments!
|
|
|
|
|
You can't just go about it like that. Those numbers will vary from device to device (the app deals with more than one HID). Most importantly, these values will change for all the devices on a 64 bit computer!
|
|
|
|
|
With the context you gave us it was by no means anything other than clumsy code. I just pointed out one mathematical interpretation of the code - you don't like it - fine - but unless you share the context with us, it just looks like clumsy code to me.
Peter
"Until the invention of the computer, the machine gun was the device that enabled humans to make the most mistakes in the smallest amount of time."
|
|
|
|
|
Really sorry about that. I explained the context of it later after creating the thread.
Link[^]
Nobody can give you wiser advice than yourself. - Cicero
.·´¯`·->ßRÅhmmÃ<-·´¯`·.
|
|
|
|
|
I would use an "else if" to make it clear. Did the guy not knowing about enums or switch.
or:
if( i !=13 && ....)
i++;
I wont see other source code like this... it is often only the top of an icecube
Greetings from Germany
|
|
|
|
|
KarstenK wrote: Did the guy not knowing about enums or switch.
Well, what would you expect something from a guy who has hardcoded the port numbers
|
|
|
|
|
I would expect that he has to learn so much, so he better should write the documentation (manual) not the source code.
Greetings from Germany
|
|
|
|
|
Nobody can give you wiser advice than yourself. - Cicero
.·´¯`·->ßRÅhmmÃ<-·´¯`·.
|
|
|
|
|
I've sussed it. This is a candidate for when the guy is optimising the code. Imagine the scene. A manager is whining about how long the code takes to run, and this guy says that he'll optimize the code and he spends 10 seconds removing the code and the next 20 days surfing dodgy sites. 20 days later he runs the application and it runs faster without the useless code. Result - he gets a glowing review and a hefty pay rise for removing this steaming pile of crap (hey a new acronym, SPOC).
Obviously this guy doesn't use CodeProject because, God forbid, no developer on this site would ever produce code as awful as this.;P
Deja View - the feeling that you've seen this post before.
|
|
|
|
|
Pete O'Hanlon wrote: Obviously this guy doesn't use CodeProject because, God forbid, no developer on this site would ever produce code as awful as this.;P
Holy crap! Finally someone could feel everything that I felt about that "developer" guy.
[EDIT] It's amazing how this guy managed to make me say so many WTFs with his merely five or six lines of code. I can't believe so many people were bothered only about the number of if conditions in it and not anything beyond that. Probably the title I gave the thread contributed to it.[/EDIT]
-- modified at 5:48 Wednesday 12th September, 2007
Last modified: 55mins after originally posted --
Nobody can give you wiser advice than yourself. - Cicero
.·´¯`·->ßRÅhmmÃ<-·´¯`·.
|
|
|
|
|
!!!!! 
|
|
|
|
|
switch(i)
{
case 12:
case 19:
case 26:
case 33:
break;
default:
i++;
}
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
