|
Recently a contractor(my View about Contractors - are supposed to good programmers!) worked in our project.
Code written in C#-VS2005
He wrote
<br />
public void RegisterEvents()<br />
{<br />
obj.CenterChanged += new CenterChangedEventHandler(OnCenterChanged);<br />
obj.CenterChanged += new CenterChangedEventHandler(OnCenterChanged);<br />
}<br />
My question:
Would registering the same event twice call the handler twice when event is raised?
-rt
|
|
|
|
|
I did a quick check myself and indeed the handler gets called twice if registered twice.
The handler handled some drawing code which I am sure would redraw twice!
|
|
|
|
|
Contractors aren't magic bullets for organisations. Like every other profession, some are good and some are bad. Remember that a lot of people are attracted to contracting for the perceived high remuneration and you can see why there is a lot of chaff among the wheat.
Deja View - the feeling that you've seen this post before.
|
|
|
|
|
|
Yeah it should get called twice
I find a number of contractors are hackers because they just code to the contract with no thought to maintainability.
I'm sure there are some good ones out there, but they are much more immediate result oriented, which can lead to bad code. I've seen it a few times, not to say permanent coders can't be hackers too.
Tim
|
|
|
|
|
True. Their sense of commitment to the organization is less since they know they would escape after a while.
We need to be careful in getting the proper deliverables from them since our project is billed by them.
|
|
|
|
|
Yes.
But wasn't there a compiler warning or at least a peer code review to stamp out this? 
|
|
|
|
|
Seen in production code
int intTrStatusCnt = 0;
long intMaxTrLogID = 0;
long intMaxTrStatusID = 0;
Cheers,
Vıkram.
Déjà moo - The feeling that you've seen this bull before.
Join the CP group at NationStates. Password: byalmightybob
|
|
|
|
|
That's definitely not Hungarian believe me :P
|
|
|
|
|
szukuro wrote: That's definitely not Hungarian believe me
... hence the phrase 'use it properly'.
Cheers,
Vıkram.
Déjà moo - The feeling that you've seen this bull before.
Join the CP group at NationStates. Password: byalmightybob
|
|
|
|
|
OK, I should've used the joke icon. If you take a look at my profile, I'm from Hungary. The joke was based upon the fact that Hungarian is not the same as Hungarian Notation.
|
|
|
|
|
Touché! 
Cheers,
Vıkram.
Déjà moo - The feeling that you've seen this bull before.
Join the CP group at NationStates. Password: byalmightybob
|
|
|
|
|
I got it. =)
I knew right away you had to be from Hungary, with that sense of humor, haha.
|
|
|
|
|
And neither Italian, I can assure it!
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
|
|
|
|
|
The Grand Negus wrote: Perhaps the guy changed the latter two types after the thing was running to fix a bug
Revision 1.0. 
Cheers,
Vıkram.
Déjà moo - The feeling that you've seen this bull before.
Join the CP group at NationStates. Password: byalmightybob
|
|
|
|
|
Perhaps the guy was using his own convention. If he used it consistently, I don't think he is to blame.
Sorry I haven't noticed the long vars!!!
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
|
|
|
|
|
Well, long *is* integer data type 
"Throughout human history, we have been dependent on machines to survive. Fate, it seems, is not without a sense of irony. " - Morpheus
"Real men use mspaint for writing code and notepad for designing graphics." - Anna-Jayne Metcalfe
|
|
|
|
|
|
Hey, give the guy/gal a break. At least the variables have been initialised. 
Chris Meech
I am Canadian. [heard in a local bar]
|
|
|
|
|
Well, accept for the naming this is not a coding horror. If he was coding for Windows before Vista, he would even be correct. The reason being that with VC6, and any compiler that created 32 bit code, an int and a long where the same thing.
I am not sure about a long but an int is supposed to be a machine word. In reality it depends on the compiler being used.
INTP
"Program testing can be used to show the presence of bugs, but never to show their absence."Edsger Dijkstra
|
|
|
|
|
But Hungarian notation used the l (or lng for the VBized version) to denote longs. Take this as an example, lpszMyText which stands for a Long Pointer to a String terminated by a Zero.
Deja View - the feeling that you've seen this post before.
|
|
|
|
|
Do you know what a long pointer is? I do.
Hungarian notation has its uses, but it falls way short of what it was intended to do. In the case presented an int is probably 32 bit and an long is probably 32 bits, so coding wise it makes no difference until you start using a 64 bit compiler, in which case they will probably both be the same again.
INTP
"Program testing can be used to show the presence of bugs, but never to show their absence."Edsger Dijkstra
|
|
|
|
|
John R. Shaw wrote: Do you know what a long pointer is? I do.
So do I (having a C/C++ background here).
However, it is worth noting that there is a difference in the maximum/minimum allowed values between an int and a long. Try this in C#
Console.WriteLine(int.MaxValue.ToString());
Console.WriteLine(long.MaxValue.ToString()); So, look at the code again and tell me - do you think that an int and a long can be treated the same here?
Deja View - the feeling that you've seen this post before.
|
|
|
|
|
LOL! Sorry I tend not to notice the ‘.Net’ reference when looking at code that appears to be C or C++. Try that same logic in C or C++ and you will see it does not apply. When computers used 16 bit words an ‘int’ was supposed to be 16 bits as per language specifications (but actually it depended on the compiler). When they changed to 32 bit words (size of register) and new compilers came out, then ‘int’ became 32 bits per language specifications, which made it the same as a long. I do not know what artificial limits C# uses, but C and C++ uses register size and the compiler vendor sets the limits according to the standard. Any code you develop should be archived along with a copy of the compiler (environment) and the associated libraries, so that it can be recreated without having to modify it.
INTP
"Program testing can be used to show the presence of bugs, but never to show their absence."Edsger Dijkstra
|
|
|
|
|
John R. Shaw wrote: Try that same logic in C or C++ and you will see it does not apply.
I know - this caught me out a few times when I first moved over to .NET. I must admit that it really bugged me - especially when attempting to convert values.
.NET standardised on int being Int32 and long being Int64.
Deja View - the feeling that you've seen this post before.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
