Re: Updating properties in a IEnumerable - C# Discussion Boards

OriginalGriff26-Dec-22 1:02

26-Dec-22 1:02

Without your code (and probably your data)?
We have no idea why this happens - there are just too many different things you could be doing! There is nowhere near enough information here for us to begin to help you - we have no idea what you are trying to do, or where you are starting from.

Start here: Asking questions is a skill[^] and think about what you need to know, and what you need to tell us in order to get help.

"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!

Basel Shikh Osman26-Dec-22 1:06

Basel Shikh Osman

26-Dec-22 1:06

you are right sorry for that
and i finally got what was the problem i am using inside loop linq and when i use function inside where it took too much time

OriginalGriff26-Dec-22 1:14

26-Dec-22 1:14

It's OK, at least you tried to ask a "proper question" - it's not the worst question we've ever had, just look two threads down ... Laugh | :laugh:

BillWoodruff26-Dec-22 2:50

26-Dec-22 2:50

of course, we have no idea how you are using Linq, but:

"inside loop linq:" keep possibility of multiple enumerations in mind: [^]

«The mind is not a vessel to be filled but a fire to be kindled» Plutarch

Updating properties in a IEnumerable

Gerry Schmitz26-Dec-22 8:16

Gerry Schmitz

26-Dec-22 8:16

Probably creating a memory leak.

"Before entering on an understanding, I have meditated for a long time, and have foreseen what might happen. It is not genius which reveals to me suddenly, secretly, what I have to say or to do in a circumstance unexpected by other people; it is reflection, it is meditation." - Napoleon I

hpjchobbes24-Dec-22 4:14

hpjchobbes

24-Dec-22 4:14

I have an IEnumerable<employee> that I need to update some fields based on the user's security permissions. If a user is in the Admin or HR roles, the CanEdit and CanDelete properties should be set to true. If the user is not Admin or HR, but is their own record, CanEdit should be true. I have come up with two options, and wanted to know which would be considered the better method (or a different way) for speed, readability, and maintainability.

Method 1 first checks if the user is Admin or HR, then loops through the entire collection and updates the values. If the user is not Admin/HR, then it checks each record to see if it is the users and updates. Currently, a user can only have one record, so I quit once I update the matching employee record.

// Admin and HR are allowed to edit and delete all records
if(_userManager.User.IsInRole("Admin") || _userManager.User.IsInRole("HR"))
{
    foreach(var employeeRecord in employeeList)
    {
        employeeRecord.CanEdit = employeeRecord.CanDelete = true;
    }
    return employeeList;
}

// Users are allowed to edit their own record.
foreach(var employeeRecord in employeeList)
{
    if(employeeRecord.WorkEmail.Equals(_userManager.User.Identity.Name, StringComparison.OrdinalIgnoreCase))
    {
        employeeRecord.CanEdit = true;
        return employeeList;
    }
}

// This return is needed in case there is no user record found.
return employeeList;

Method 2 stores a boolean if the user is an Admin/HR, and just sets that as the permission, then checks if the current employeeRecord belongs to the user and sets the permission.

bool hasEditDeletePermission = _userManager.User.IsInRole("Admin") || _userManager.User.IsInRole("HR");

foreach(var employeeRecord in employeeList)
{                
    employeeRecord.CanEdit = employeeRecord.CanDelete = hasEditDeletePermission;
                
    if(_userManager.User.Identity.Name.Equals(employeeRecord.WorkEmail, StringComparison.OrdinalIgnoreCase))
    {
        // Users can edit their own record
        employeeRecord.CanEdit = true;
    }
}

return employeeList;

Method 2 seems shorter and easier to understand, but Method 1 can be faster when the user isn't Admin or HR, which would happen more often. There's also the issue that Method 1 leaves the CanEdit/CanDelete values to whatever they were originally supplied as (currently defaults to false), where as Method 2 will always override any preexisting values which might cause unexpected behavior if other rules are added elsewhere.

Any recommendations on which you would rather use, or even suggestions on better ways to code this would be appreciated.

Gerry Schmitz24-Dec-22 6:35

Gerry Schmitz

24-Dec-22 6:35

If the user was limited to certain records in the first place, that particular process should have been "data driven" with a proper query. Instead, you've got "generic" process that attempts to apply some logic to "every record" from who knows where.

The "data driver" could be data records, references or simply keys. Another design decision.

What you're dealing with is affectionately known as "tramp data".

hpjchobbes24-Dec-22 9:58

hpjchobbes

24-Dec-22 9:58

Could you explain a bit more what you mean by 'data driven with a proper query'? Almost every tutorial/example I've found only seems to be basic "Can Access/Can Not Access", but my needs are more granular. I'm currently using CQRS to have my Controller send an EmployeeQuery request. I've added a pipeline to the request handler which has my security logic and updates the results from the query as I need to apply information not just to the records themselves, but also potentially individual properties of the record. I didn't want to mix my security logic in with my query as I thought that could get hard to expand in the future. Here's an example of the current rules/permissions:

- Admin : Full Create, Read, Update, (Soft/Hard) Delete.
- HR : Full Create, Read, Update, Soft Delete.
- Manager : Full Read (of specific columns), Update of their own record (excluding some columns).
- User : Full Read (of specific columns different than Manager), Update of their own record (excluding some columns).

I'm using EFCore and LINQ for the query and I had first thought about trying to have the security logic in the pipeline 'build' the IQueryable that will get executed by the query handler, but I haven't found a good resource on how to do that, so I am updating the results of the handled query before sending it back to the Controller.

Gerry Schmitz24-Dec-22 23:48

Gerry Schmitz

24-Dec-22 23:48

Context is important. You make references to IEnumerable when operations like "create", update and delete (of a give user's record) typically don't involve "updating sets"; they involve a single record or object graph.

"Browsing" implies sets, and is generally only limited in a broad sense (one may or may not access this particular "view").

When talking about "roles", this is not something that starts at query time; it starts as soon as the user has logged in and identified themselves. The app should be aware of parts to limit based on roles; which includes forms, reports, menu items, and sensitive data (which may involve limiting tables, records, columns, ranges, etc. based on need).

The "back end" accesses "views" of the data based on roles; and applies "need to know" filters before it even tackles the user's request. Still a pipeline, but with some extra "role filters" in between components; which includes the interactive / online / real-time parts.

So, you need to maintain and interface with a user's "role object" from start to finish. And the data that is finally handed off to that actual "insert" or update (that last "grain") is then free of any "role checking".

BillWoodruff25-Dec-22 5:04

25-Dec-22 5:04

as Gary says (imho), you should not be retrieving all records, and then using Linq: you EF query should pull only the records that need updating, and, then, write those updated records back to the data store.

IEnumerable: keep an eye out for multiple enumerations: [^]

«The mind is not a vessel to be filled but a fire to be kindled» Plutarch

Mycroft Holmes24-Dec-22 11:09

Mycroft Holmes

24-Dec-22 11:09

Have an object - user details that stores the info on the current user and a list of permissions. This should be populated when the user logs on.

Each page checks the user object for permissions and set 1 or more flags that control the state of the form controls and the content of any lists for the form.

Never underestimate the power of human stupidity -
RAH
I'm old. I know stuff - JSOP

Member 1587460624-Dec-22 3:18

Member 15874606

24-Dec-22 3:18

I need help in my task

OriginalGriff24-Dec-22 4:06

24-Dec-22 4:06

That's a difficult one ... there are probably millions of tasks that you could have been assigned, and we have no idea at all what it might be!

So we're going to have to guess: the message elements are flexed through a collectimizer which strips the flow-gate arrays into virtual message elements.[^]
Hope that helps!

If it doesn't, then start here: Asking questions is a skill[^] and think about what you need to know, and what you need to tell us in order to get help.

BillWoodruff24-Dec-22 18:39

24-Dec-22 18:39

perhaps the OP thinks this is a psychic hotline ? OMG | :OMG:

«The mind is not a vessel to be filled but a fire to be kindled» Plutarch

OriginalGriff24-Dec-22 19:44

24-Dec-22 19:44

He will meet a tall, dark stranger and should avoid elevators and shellfish until Tuesday ...

RedDk25-Dec-22 6:30

RedDk

25-Dec-22 6:30

Well, first you've gotta wait for the keyboard to do it's magic (press any key). Then when the log-in screen appears out from behind the screen saver, you've gotta stand up. Now move your head as close to perpendicular to the lit screen and, looking down onto it's surface, identify where the spots of spagetti sauce are most concentrated. Notice that the most crusty of these clusters of dinner spatter might be well congealed and therefore hard to wipe off with cold water (test run a "scrape" using a fingernail). Get a cloth rag then, soaked with HOT water, and lightly, from this high advantage point above the frame of the monitor, in a bak-and-forth manner, rub the sauce from the darker backlit spots until they have been removed. After, dry with a paper towel. And you're good to go.

OriginalGriff25-Dec-22 21:44

25-Dec-22 21:44

When I started reading that, I assumed it was going to end with "tell them 'I am too damn stupid to own a computer'" Big Grin | :-D

Nitin S26-Dec-22 18:10

Nitin S

26-Dec-22 18:10

and you will tell details about the task with telepathy or what?

what you have tried before asking for help

=====================================================
The grass is always greener on the other side of the fence

convert double with decimal places to any base in C# example : 19.879 to any base or -19.345 to any base

RedDk27-Dec-22 8:54

RedDk

27-Dec-22 8:54

HOLY CROW! A terabyte of memory! That's a lot!

Sakhalean23-Dec-22 23:48

Sakhalean

23-Dec-22 23:48

Hi All,

convert double with decimal places to any base in C# example : 19.879 to any base or -19.345 to any base

Please help

Re: convert double with decimal places to any base in C# example : 19.879 to any base or -19.345 to any base

OriginalGriff24-Dec-22 0:29

Re: convert double with decimal places to any base in C# example : 19.879 to any base or -19.345 to any base

24-Dec-22 0:29

While we are more than willing to help those that are stuck, that doesn't mean that we are here to do it all for you! We can't do all the work, you are either getting paid for this, or it's part of your grades and it wouldn't be at all fair for us to do it all for you.

So we need you to do the work, and we will help you when you get stuck. That doesn't mean we will give you a step by step solution you can hand in!
Start by explaining where you are at the moment, and what the next step in the process is. Then tell us what you have tried to get that next step working, and what happened when you did.

If you are having problems getting started at all, then this may help: How to Write Code to Solve a Problem, A Beginner's Guide[^]

Sakhalean25-Dec-22 4:52

Sakhalean

25-Dec-22 4:52

Sorry,

I googled nothing helped me. So I have created my own class for number conversions.
I have 17+ years of software development experience.

Thanks you so much for your help.

Re: convert double with decimal places to any base in C# example : 19.879 to any base or -19.345 to any base

BillWoodruff24-Dec-22 18:37