C / C++ / MFC

30-Sep-09 5:09

I did a test for size change of MFC exe.

When a line of code or a small resource bitmap is deleted or added in the exe program, exe size keeps unchanged.

So I guess exe is aligned in size - similar to class aligned in size by its members.

Do you think it is correct or have more info about this?

Joe Woodbury30-Sep-09 6:01

Joe Woodbury

30-Sep-09 6:01

Yes. By default applications are aligned on 512 byte boundaries. (Due to a quirk in the Windows 98 paging mechanism, before Visual Studio 2008, Win32 applications were aligned on 4096 byte boundaries unless you added the /OPT:NOWIN98 switch to the linker. The linker for VS 2008 and later now uses 512 alignment by default.)

includeh1030-Sep-09 8:46

30-Sep-09 8:46

Hi Joe,
The /OPT:NOWIN98 should be sdded at which place of project settings? How?

Joe Woodbury30-Sep-09 8:52

Joe Woodbury

30-Sep-09 8:52

In Visual Studio 2003/2005 it's in Properties|Linker|Optimization. Select "No (/OPT:NOWIN98) Only set this for Release mode.

In Visual Studio 2008, this will generate a warning, so it should be set to Default.

In Visual C++ 6.0, go to Settings|Link. In the Project Options Edit control, go to end and manually add "/OPT:NOWIN98"

includeh1030-Sep-09 9:37

30-Sep-09 9:37

Joe, thanks,

The min change is from 4096 to 512 bytes now.

cheers.

krmed30-Sep-09 6:02

krmed

30-Sep-09 6:02

How are you looking at the size? If you're looking at the Windows Explorer, it only shows size in "cluster" increments.

Open a command window and use the "dir" command to see the actual files size at the byte level.

Karl - WK5M
PP-ASEL-IA (N43CS)
PGP Key: 0xDB02E193
PGP Key Fingerprint: 8F06 5A2E 2735 892B 821C 871A 0411 94EA DB02 E193

Richard MacCutchan30-Sep-09 6:17

Richard MacCutchan

30-Sep-09 6:17

krmed wrote:
Open a command window and use the "dir" command to see the actual files size at the byte level.

Better still, right click in Explorer and select Properties.

David Crow30-Sep-09 9:51

30-Sep-09 9:51

krmed wrote:
If you're looking at the Windows Explorer, it only shows size in "cluster" increments.

It also shows the file's actual size, not just its size on disk.

"Old age is like a bank account. You withdraw later in life what you have deposited along the way." - Unknown

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

krmed1-Oct-09 0:25

krmed

1-Oct-09 0:25

Unless you have a different Windows Explorer than I do, it only shows one size - and it's not the actual size.

But perhaps you were responding to the idea of looking at the properties?

Karl - WK5M
PP-ASEL-IA (N43CS)
PGP Key: 0xDB02E193
PGP Key Fingerprint: 8F06 5A2E 2735 892B 821C 871A 0411 94EA DB02 E193

David Crow1-Oct-09 2:16

ComboBox speed issue with XP style

1-Oct-09 2:16

krmed wrote:
But perhaps you were responding to the idea of looking at the properties?

Correct.

user94130-Sep-09 4:49

user941

30-Sep-09 4:49

I've recently started using the XP styles look by using a manifest on an MFC application, and overall it looks fine.

The problem is a specific screen I have, which uses quite a few Comboboxes and Edit boxes. Everything works basically as before, only much much slower than it used to. When I change back and remove the manifest, everything changes back to regular speed.

Can anyone help me solve this speed issue? The hope is to be able to retain the XP-style look while not slowing down so significantly. Any help would be appreciated, thank you.

Using CEdit with ES_NUMBER giving "Please enter a positive integer." followed by exception.

Neil Urquhart30-Sep-09 4:16

Re: Using CEdit with ES_NUMBER giving "Please enter a positive integer." followed by exception.

30-Sep-09 4:16

Using VC6 & MFC

I have dialog with an edit box for the user to enter an integer number. I have set the number property in the resource sheet (ES_NUMBER) to handle entering numbers. Now everything is fine in that I can enter numbers and catch the new member value in my OnChangeEdit......() function.

However !

If you have say "3" in the edit box and you want to change it to say "4", a legitimate way for the user to do this is to press backspace to delete the "3" character and type "4" to set the new value.

But if you do this I get a message box saying "Please enter a positive integer." on using the backspace key switfly followed by an exception and program crash. Not very elegant !!

I have tried to intercept this with break points in OnChangeEdit or DoDataExchange of the dialog but it never gets there before the message box pops up.

Appart from priseing out the backspace key from the keyboard is there way to get around this ? It looks to my like a glaring whole in the default way MFC works. Other more learned people than me must have hit this plenty of times ?

Neil

sashoalm30-Sep-09 4:29

sashoalm

30-Sep-09 4:29

Have you added any filters or made any unusual changes? I have number edit-controls as well but I don't get message boxes nor exceptions.

There is sufficient light for those who desire to see, and there is sufficient darkness for those of a contrary disposition.
Blaise Pascal

Re: Using CEdit with ES_NUMBER giving "Please enter a positive integer." followed by exception.

Neil Urquhart30-Sep-09 4:39

Re: Using CEdit with ES_NUMBER giving "Please enter a positive integer." followed by exception.

30-Sep-09 4:39

I have a spin control associated with it via the AUTO_BUDDY mechanisam. I have used SetRange in OnInitDialog() for the spin control.

David Crow30-Sep-09 5:43

Re: Using CEdit with ES_NUMBER giving "Please enter a positive integer." followed by exception.

30-Sep-09 5:43

Neil Urquhart wrote:
I have used SetRange...

With what values?

I tried to reproduce this behavior but it works fine for me. I added one edit control and one spin control. I added the ES_NUMBER style to the edit control. I added the UDS_SETBUDDYINT and UDS_AUTOBUDDY styles to the spin control. I used 1,5 as the range. You must have something else in place that is interfering.

Neil Urquhart30-Sep-09 6:44

Re: Using CEdit with ES_NUMBER giving "Please enter a positive integer." followed by exception.

30-Sep-09 6:44

Having produced a reduced version of my dialog I have tracked to source of the exception.

It seems using UpdateData(FALSE) in the OnChangeEdit1() is the source of the problem. Without it I don't get the exception. Its probably not required anyhow. I don't understand why it only causes the problem when the string in the edit control is empty.

This is the code which causes the exception :

// CEditTestDlg.cpp : implementation file
//

#include "stdafx.h"
#include "CEditTest.h"
#include "CEditTestDlg.h"

// Update timer
#define IDT_UPDATE	1000
#define UPDATE_INTERVAL 1000

#ifdef _DEBUG
#define new DEBUG_NEW
#undef THIS_FILE
static char THIS_FILE[] = __FILE__;
#endif

/////////////////////////////////////////////////////////////////////////////
// CAboutDlg dialog used for App About

class CAboutDlg : public CDialog
{
public:
	CAboutDlg();

// Dialog Data
	//{{AFX_DATA(CAboutDlg)
	enum { IDD = IDD_ABOUTBOX };
	//}}AFX_DATA

	// ClassWizard generated virtual function overrides
	//{{AFX_VIRTUAL(CAboutDlg)
	protected:
	virtual void DoDataExchange(CDataExchange* pDX);    // DDX/DDV support
	//}}AFX_VIRTUAL

// Implementation
protected:
	//{{AFX_MSG(CAboutDlg)
	//}}AFX_MSG
	DECLARE_MESSAGE_MAP()
};

CAboutDlg::CAboutDlg() : CDialog(CAboutDlg::IDD)
{
	//{{AFX_DATA_INIT(CAboutDlg)
	//}}AFX_DATA_INIT
}

void CAboutDlg::DoDataExchange(CDataExchange* pDX)
{
	CDialog::DoDataExchange(pDX);
	//{{AFX_DATA_MAP(CAboutDlg)
	//}}AFX_DATA_MAP
}

BEGIN_MESSAGE_MAP(CAboutDlg, CDialog)
	//{{AFX_MSG_MAP(CAboutDlg)
		// No message handlers
	//}}AFX_MSG_MAP
END_MESSAGE_MAP()

/////////////////////////////////////////////////////////////////////////////
// CCEditTestDlg dialog

CCEditTestDlg::CCEditTestDlg(CWnd* pParent /*=NULL*/)
	: CDialog(CCEditTestDlg::IDD, pParent)
{
	//{{AFX_DATA_INIT(CCEditTestDlg)
	m_edit1 = 0;
	//}}AFX_DATA_INIT
	// Note that LoadIcon does not require a subsequent DestroyIcon in Win32
	m_hIcon = AfxGetApp()->LoadIcon(IDR_MAINFRAME);

	bDlgInitDone = FALSE ;

}

void CCEditTestDlg::DoDataExchange(CDataExchange* pDX)
{
	CDialog::DoDataExchange(pDX);
	//{{AFX_DATA_MAP(CCEditTestDlg)
	DDX_Control(pDX, IDC_SPIN1, m_spin1);
	DDX_Text(pDX, IDC_EDIT1, m_edit1);
	//}}AFX_DATA_MAP
}

BEGIN_MESSAGE_MAP(CCEditTestDlg, CDialog)
	//{{AFX_MSG_MAP(CCEditTestDlg)
	ON_WM_SYSCOMMAND()
	ON_WM_PAINT()
	ON_WM_QUERYDRAGICON()
	ON_WM_TIMER()
	ON_EN_CHANGE(IDC_EDIT1, OnChangeEdit1)
	//}}AFX_MSG_MAP
END_MESSAGE_MAP()

/////////////////////////////////////////////////////////////////////////////
// CCEditTestDlg message handlers

BOOL CCEditTestDlg::OnInitDialog()
{
	CDialog::OnInitDialog();

	// Add "About..." menu item to system menu.

	// IDM_ABOUTBOX must be in the system command range.
	ASSERT((IDM_ABOUTBOX & 0xFFF0) == IDM_ABOUTBOX);
	ASSERT(IDM_ABOUTBOX < 0xF000);

	CMenu* pSysMenu = GetSystemMenu(FALSE);
	if (pSysMenu != NULL)
	{
		CString strAboutMenu;
		strAboutMenu.LoadString(IDS_ABOUTBOX);
		if (!strAboutMenu.IsEmpty())
		{
			pSysMenu->AppendMenu(MF_SEPARATOR);
			pSysMenu->AppendMenu(MF_STRING, IDM_ABOUTBOX, strAboutMenu);
		}
	}

	// Set the icon for this dialog.  The framework does this automatically
	//  when the application's main window is not a dialog
	SetIcon(m_hIcon, TRUE);			// Set big icon
	SetIcon(m_hIcon, FALSE);		// Set small icon
	
	// TODO: Add extra initialization here

	m_spin1.SetRange(1,99) ;

	// Set the update timer
	SetTimer(IDT_UPDATE, UPDATE_INTERVAL, NULL) ;

	bDlgInitDone = TRUE ;

	
	return TRUE;  // return TRUE  unless you set the focus to a control
}

void CCEditTestDlg::OnSysCommand(UINT nID, LPARAM lParam)
{
	if ((nID & 0xFFF0) == IDM_ABOUTBOX)
	{
		CAboutDlg dlgAbout;
		dlgAbout.DoModal();
	}
	else
	{
		CDialog::OnSysCommand(nID, lParam);
	}
}

// If you add a minimize button to your dialog, you will need the code below
//  to draw the icon.  For MFC applications using the document/view model,
//  this is automatically done for you by the framework.

void CCEditTestDlg::OnPaint() 
{
	if (IsIconic())
	{
		CPaintDC dc(this); // device context for painting

		SendMessage(WM_ICONERASEBKGND, (WPARAM) dc.GetSafeHdc(), 0);

		// Center icon in client rectangle
		int cxIcon = GetSystemMetrics(SM_CXICON);
		int cyIcon = GetSystemMetrics(SM_CYICON);
		CRect rect;
		GetClientRect(&rect);
		int x = (rect.Width() - cxIcon + 1) / 2;
		int y = (rect.Height() - cyIcon + 1) / 2;

		// Draw the icon
		dc.DrawIcon(x, y, m_hIcon);
	}
	else
	{
		CDialog::OnPaint();
	}
}

// The system calls this to obtain the cursor to display while the user drags
//  the minimized window.
HCURSOR CCEditTestDlg::OnQueryDragIcon()
{
	return (HCURSOR) m_hIcon;
}

void CCEditTestDlg::OnTimer(UINT nIDEvent) 
{
	// TODO: Add your message handler code here and/or call default
	
	switch (nIDEvent) {
	case IDT_UPDATE :
		// Reset this timeout
		KillTimer(nIDEvent) ;

		UpdateData(TRUE) ;
		UpdateData(FALSE) ;

		// Set the update timer again
		SetTimer(IDT_UPDATE, UPDATE_INTERVAL, NULL) ;

		break ;

	default :
		CDialog::OnTimer(nIDEvent);
	}	
}

void CCEditTestDlg::OnChangeEdit1() 
{
	// TODO: If this is a RICHEDIT control, the control will not
	// send this notification unless you override the CDialog::OnInitDialog()
	// function and call CRichEditCtrl().SetEventMask()
	// with the ENM_CHANGE flag ORed into the mask.
	
	// TODO: Add your control notification handler code here
	if(bDlgInitDone) UpdateData(TRUE) ;
	TRACE("value is %d\n", m_edit1) ;

	
}

David Crow30-Sep-09 6:50

Re: Using CEdit with ES_NUMBER giving "Please enter a positive integer." followed by exception.

30-Sep-09 6:50

Neil Urquhart wrote:
It seems using UpdateData(FALSE) in the OnChangeEdit1() is the source of the problem.

UpdateData() is rarely, if ever, necessary. Remove it, use a CEdit control variable, and your troubles will cease.

Neil Urquhart4-Oct-09 20:59

Re: Using CEdit with ES_NUMBER giving "Please enter a positive integer." followed by exception.

4-Oct-09 20:59

It seems if you don't use UpdateData(TRUE) in your OnChangeEdit.....() function then the member variable added to the control is not updated.

Ie the user will perhaps change a value from 1 to 12 in the integer CEdit box and without UpdateData(TRUE) the m_edit1 caught in the OnChangeEdit...() function will be 1 and not 12.

Also it seems the OnChangeEdit...() function can be called prior to OnInitDialog() and if UpdateData() is called at this time then problems will result. I protect my code against this by using a flag to indicate that the OnInitDialog() function had finished.

BOOL CCEditTestDlg::OnInitDialog()<br />
{<br />
	CDialog::OnInitDialog();<br />
<br />
	// Add "About..." menu item to system menu.<br />
<br />
	// IDM_ABOUTBOX must be in the system command range.<br />
	ASSERT((IDM_ABOUTBOX & 0xFFF0) == IDM_ABOUTBOX);<br />
	ASSERT(IDM_ABOUTBOX < 0xF000);<br />
<br />
	CMenu* pSysMenu = GetSystemMenu(FALSE);<br />
	if (pSysMenu != NULL)<br />
	{<br />
		CString strAboutMenu;<br />
		strAboutMenu.LoadString(IDS_ABOUTBOX);<br />
		if (!strAboutMenu.IsEmpty())<br />
		{<br />
			pSysMenu->AppendMenu(MF_SEPARATOR);<br />
			pSysMenu->AppendMenu(MF_STRING, IDM_ABOUTBOX, strAboutMenu);<br />
		}<br />
	}<br />
<br />
	// Set the icon for this dialog.  The framework does this automatically<br />
	//  when the application's main window is not a dialog<br />
	SetIcon(m_hIcon, TRUE);			// Set big icon<br />
	SetIcon(m_hIcon, FALSE);		// Set small icon<br />
	<br />
	// TODO: Add extra initialization here<br />
<br />
	...<br />
	...<br />
	...<br />
<br />
	bDlgInitDone = TRUE ;<br />
<br />
	<br />
	return TRUE;  // return TRUE  unless you set the focus to a control<br />
}<br />
void CCEditTestDlg::OnChangeEdit1() <br />
{<br />
	// TODO: If this is a RICHEDIT control, the control will not<br />
	// send this notification unless you override the CDialog::OnInitDialog()<br />
	// function and call CRichEditCtrl().SetEventMask()<br />
	// with the ENM_CHANGE flag ORed into the mask.<br />
	<br />
	// TODO: Add your control notification handler code here<br />
<br />
	if(bDlgInitDone) UpdateData(TRUE) ;<br />
<br />
	TRACE("value is %d\n", m_edit1) ;<br />
<br />
	<br />
}

David Crow5-Oct-09 2:49

Re: Using CEdit with ES_NUMBER giving "Please enter a positive integer." followed by exception.

5-Oct-09 2:49

Neil Urquhart wrote:
It seems if you don't use UpdateData(TRUE) in your OnChangeEdit.....() function then the member variable added to the control is not updated.

That's what GetWindowText() is for.

Neil Urquhart30-Sep-09 5:24

Barcode generator library

30-Sep-09 5:24

I have found a fix !

It seems in my break point testing in DoDataExchange I had put it after the DDX_Text function. It seems that the "Please enter a positive integer." message come from inside the relvant DDX_Text function somewhere.

I was therefore able to fix the problem by intercepting the value coming from CEdit at the top of DoDataExchange with a bit of validation code. The curcial test you need is to check the text in CEdit to see if the user deleted it all, even though it uses numbers. If he did delete it all I set the text and memver variable to a default value.

I also add validation code for my values range.

void CArtConDlg::DoDataExchange(CDataExchange* pDX)
{
	// Validation vars
	CEdit *cEd ;
	CString csTxt ;

	// Validate DmInterval
	cEd = (CEdit*)GetDlgItem(IDC_EDIT_DMINTERVAL) ;
	cEd->GetWindowText(csTxt) ;
	if(csTxt.IsEmpty()) {
		m_iDmInterval = MIN_DMINTERVAL ;
		csTxt.Format("%d", m_iDmInterval) ;
		cEd->SetWindowText((LPCSTR)csTxt) ;
	} else if(m_iDmInterval < MIN_DMINTERVAL) {
		m_iDmInterval = MIN_DMINTERVAL ;
	} else if(m_iDmInterval > MAX_DMINTERVAL) {
		m_iDmInterval = MAX_DMINTERVAL ;
	}

	// Validate OneShotHours
	cEd = (CEdit*)GetDlgItem(IDC_EDIT_ONESHOTHOURS) ;
	cEd->GetWindowText(csTxt) ;
	if(csTxt.IsEmpty()) {
		m_iTmrOneShotHours = MIN_TMRONESHOTHOURS ;
		csTxt.Format("%d", m_iTmrOneShotHours) ;
		cEd->SetWindowText((LPCSTR)csTxt) ;
	} else if(m_iTmrOneShotHours < MIN_TMRONESHOTHOURS) {
		m_iTmrOneShotHours = MIN_TMRONESHOTHOURS ;
	} else if(m_iTmrOneShotHours > MAX_TMRONESHOTHOURS) {
		m_iTmrOneShotHours = MAX_TMRONESHOTHOURS ;
	}

	
	CDialog::DoDataExchange(pDX);
	//{{AFX_DATA_MAP(CArtConDlg)
	DDX_Control(pDX, IDC_SPIN_ONESHOTHOURS, m_ctrlSpinOneShotHours);
	DDX_Control(pDX, IDC_SPIN_DMINTERVAL, m_ctrlSpinDmInterval);
	DDX_Control(pDX, IDC_TIMERONOFF, m_ctrlTimerOn);
	DDX_Control(pDX, IDC_LIGHTSENSORDAYNIGHT, m_ctrlLightSensor);
	DDX_Control(pDX, IDC_ARTWORK, m_ctrlArtworkOn);
	DDX_Control(pDX, IDC_EDITMODELAP, m_ctrlEditModeLap);
	DDX_Control(pDX, IDC_COMMSALIVE, m_ctrlCommsAlive);
	DDX_Control(pDX, IDC_EDIT_LUMIN, m_ctrlEditLumin);
	DDX_Control(pDX, IDC_SLIDER_LUMIN, m_ctrlSliderLumin);
	DDX_Control(pDX, IDC_LIST_FADERS, m_ctrlListFaders);
	DDX_Text(pDX, IDC_EDIT_FADERUPDATETIME, m_csFaderUpdateTime);
	DDX_Text(pDX, IDC_EDIT_TOTAL_AMPS, m_csTotalAmps);
	DDX_Text(pDX, IDC_EDIT_TOTAL_AMPSPCT, m_csTotalAmpsPct);
	DDX_Radio(pDX, IDC_RADIO_MODEON, m_iTimerMode);
	DDX_Check(pDX, IDC_CHECK_TMRONESHOTONEN, m_bTmrOneShotEn);
	DDX_Check(pDX, IDC_CHECK_TMRFRI, m_bTmrFri);
	DDX_Check(pDX, IDC_CHECK_TMRMON, m_bTmrMon);
	DDX_Check(pDX, IDC_CHECK_TMRSAT, m_bTmrSat);
	DDX_Check(pDX, IDC_CHECK_TMRSUN, m_bTmrSun);
	DDX_Check(pDX, IDC_CHECK_TMRTHU, m_bTmrThu);
	DDX_Check(pDX, IDC_CHECK_TMRTUE, m_bTmrTue);
	DDX_Check(pDX, IDC_CHECK_TMRWED, m_bTmrWed);
	DDX_Text(pDX, IDC_EDIT_ONESHOTENDENDDATETIME, m_csOneShotEndDateTime);
	DDX_Radio(pDX, IDC_RADIO_DMCYCLE, m_iDisplayMode);
	DDX_Text(pDX, IDC_EDIT_DMINTERVAL, m_iDmInterval);
	DDX_Text(pDX, IDC_EDIT_DMFILE, m_csDmFile);
	DDV_MaxChars(pDX, m_csDmFile, 32);
	DDX_DateTimeCtrl(pDX, IDC_DATETIMEPICKER_START, m_ctTmrStart);
	DDX_DateTimeCtrl(pDX, IDC_DATETIMEPICKER_FINISH, m_ctTmrFinish);
	DDX_DateTimeCtrl(pDX, IDC_DATETIMEPICKER_ONESHOTSTART, m_ctTmrOneShotStart);
	DDX_Text(pDX, IDC_EDIT_ONESHOTHOURS, m_iTmrOneShotHours);
	DDX_Radio(pDX, IDC_RADIO_DMPERIODMIN, m_iDmIntervalUnits);
	DDX_Text(pDX, IDC_EDIT_DMLASTFILE, m_csDmLastFile);
	DDX_Text(pDX, IDC_EDIT_DMLASTUPDATE, m_csDmLastFileUpdated);
	DDX_Radio(pDX, IDC_RADIO_LSORAUTO, m_iLightSensorOverRide);
	DDX_Slider(pDX, IDC_SLIDER_LUMIN, m_iSliderLumin);
	DDX_Text(pDX, IDC_EDIT_LUMIN, m_iEditLumin);
	DDX_Text(pDX, IDC_EDIT_FILE, m_csEditFile);
	//}}AFX_DATA_MAP

}

Marc Soleda30-Sep-09 3:23

Marc Soleda

30-Sep-09 3:23

Hi all,
do you know any good barcode generator lib? I've found some, including some good CP articles, but they are not enough as I need the maximum number of type of barcodes to cover: 1D and 2D.

Any option is welcome: paid or free&opensource.

thanks in advance,
Marc Soleda

... she said you are the perfect stranger she said baby let's keep it like this... Dire Straits

Re: Barcode generator library

includeh1030-Sep-09 5:14