C# Console - Password Field not working, Need Help

Question

1.00/5 (2 votes)

See more:

using System.Threading;
using System;


class Sample
{
    public static void Main()
    {
        string user;
        string password = "";
        string cor = "i";
        string pass = "1";
        do
        {
            Console.Write("Username: ");
            user = Convert.ToString(Console.ReadLine());

        } while (user != cor);
        {
            Console.Write("Enter your password: ");
            ConsoleKeyInfo key;
            do
            {
                key = Console.ReadKey(true);
                if (key.Key != ConsoleKey.Backspace)
                {
                    password += key.KeyChar;
                    Console.Write("*");
                }
                else
                {
                    if (password.Length > 0)
                    {
                        password = password.Substring(0, (password.Length - 1));
                        Console.Write("\b \b");
                    }
                }
            }
            while (key.Key != ConsoleKey.Enter);
            


            Console.WriteLine();
            Console.WriteLine("The Password You entered is : " + password);

            {
                if (password != pass)
                {
                    Console.WriteLine();
                    Console.WriteLine("PASSWORD DECLINED");
                    //Thread.Sleep(700);

                }
                else if (password == pass)
                {
                    Console.WriteLine();
                    Console.WriteLine("PASSWORD ACCEPTED");
                    //Thread.Sleep(700);
                }
                else Console.WriteLine("ERROR"); 
                Console.ReadKey();
            }
        }
    }
}

I'm using .NET framework 3.5
I'm super new to programming and I am unsure why this is not working.
Any tips or corrections would be helpful.

Posted 11-May-11 5:59am

Member 7909082

Add a Solution

Comments

Marc A. Brown 11-May-11 12:28pm

What are you expecting the code to do and what is it doing wrong?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2011-05-11T08:19:00

The problem is quite simple: You add every character to your password, including the ENTER key at the end.
So, when you do the password check, you compare "i" with "i\r" which will never match.

Two ways round this:
1) Add the '\r' character to your password. Nasty, brute-force-and-ignorance approach.
2) Re-work your loop:

ConsoleKeyInfo key = Console.ReadKey(true);
while (key.Key != ConsoleKey.Enter)
    {
    if (key.Key != ConsoleKey.Backspace)
        {
        password += key.KeyChar;
        Console.Write("*");
        }
    else
        {
        if (password.Length > 0)
            {
            password = password.Substring(0, (password.Length - 1));
            Console.Write("\b \b");
            }
        }
    key = Console.ReadKey(true);
    }

You could have found this yourself, very easily. Since the problem is that the two strings don't appear to match, when you think they should, you need to find out why not.
So. put a breakpoint on the line:

if (password != pass)

The execution of your program will then stop there, and you can look at (and change if you need to) the values "password" and "pass". You can then start looking back in your code to find the source of the problem.

But while you are here:

if (password != pass)
    {
    ...
    }
else if (password == pass)
    {
    ...
    }
else
    ...

Doesn't need to be that complex. Since password either is or isn't equal to pass, it is normal to just write:

if (password != pass)
    {
    ...
    }
else
    {
    ...
    }

(Unless you are feeling really paranoid and suspect that a bool has three states: "true", "false" and "quantum". It doesn't, in .NET. Honest.)

Member 8043849 · Answer 2 · 2011-07-03T16:09:00

//comment your else block and add one more condition in if block then it will work fine
//if (key.Key != ConsoleKey.Backspace && key.Key != ConsoleKey.Enter )

using System.Threading;
using System;

class Sample
{
public static void Main()
{
string user;
string password = "";
string cor = "i";
string pass = "1";
do
{
Console.Write("Username: ");
user = Convert.ToString(Console.ReadLine());
} while (user != cor);
{
Console.Write("Enter your password: ");
ConsoleKeyInfo key;
do
{
key = Console.ReadKey(true);
if (key.Key != ConsoleKey.Backspace && key.Key != ConsoleKey.Enter )
{
password += key.KeyChar;
Console.Write("*");
}
/*else
{
//if (password.Length > 0)
{
// password = password.Substring(0, (password.Length - 1));
//Console.Write("\b \b");
}
}*/
}
while (key.Key != ConsoleKey.Enter);

Console.WriteLine();
Console.WriteLine("The Password You entered is : " + password);
{
if (password != pass)
{
Console.WriteLine();
Console.WriteLine("PASSWORD DECLINED");
//Thread.Sleep(700);
}
else if (password == pass)
{
Console.WriteLine();
Console.WriteLine("PASSWORD ACCEPTED");
//Thread.Sleep(700);
}
else Console.WriteLine("ERROR");
Console.ReadKey();
}
}
}
}

C# Console - Password Field not working, Need Help

2 solutions

Solution 1

Solution 3

Add your solution here

Preview 0