It show an error "operator '==' cannot be applied to operands of type 'string' and 'int' " in "where(x => x.person_id == id)"

Question

1.00/5 (1 vote)

See more:

[HttpGet]
public ActionResult EmployeeView(int id)
{
Employee employee = new Employee();
using (HRMSEntities employeeContext = new HRMSEntities())
{
employee = employeeContext.Employee.Where(x => x.Person_Id == id).FirstOrDefault();
}
return View(employee);
}
}

What I have tried:

[HttpGet]
       public ActionResult EmployeeView(int id)
       {
           Employee employee = new Employee();
           using (HRMSEntities employeeContext = new HRMSEntities())
           {
               employee = employeeContext.Employee.Where(x => x.Person_Id == id).FirstOrDefault();
           }
           return View(employee);
       }
   }

Posted 1-Mar-18 1:36am

Member 13667386

Updated 1-Mar-18 2:01am

Add a Solution

Comments

CHill60 1-Mar-18 7:37am

You can't compare strings with ints like that ... Person_Id must be a string. Try comparing it to id.ToString() instead

Member 13667386 1-Mar-18 7:44am

please help me, im new to c#

CHill60 1-Mar-18 8:56am

You will get quicker responses if you use the "Reply" link for a comment rather than chancing me coming back to a post I've already commented on

Member 13667386 1-Mar-18 7:48am

how i can fix?

Likefire 1-Mar-18 8:31am

employee = employeeContext.Employee.Where(x => x.Person_Id.Equals(id.ToString())).FirstOrDefault();

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2018-03-01T02:01:00

Solution 1

You need to change Person_Id from a string to an int - and probably correct it in the source as well. If you are retrieving the values from a DB, and the column datatype is VARCHAR or NVARCHAR, then you need to change that to an integer, if your ID's are supposed to be numeric. Always use the most appropriate datatype; anything else is a PITA.

If you don't then not only do problems like this occur, but you get worse problems when you try to use any form of sorting: strings are sorted according to the first different character, so they do not work "correctly" when sorting numeric values:

1
10
11
...
19
2
20
21
...

Posted 1-Mar-18 2:01am

OriginalGriff

Comments

phil.o 1-Mar-18 8:46am

5'd, but have a look at previous question; pretty confusing, huh?

OriginalGriff 1-Mar-18 8:50am

He's currently running his fourth copy of the same question - I've deleted one as a repost already.

Many more, and I'm tempted to start treating this as abuse... :laugh:

OriginalGriff 1-Mar-18 8:51am

And it looks like Chill's answer has been deleted along with the fourth one ... I got the third ...

phil.o 1-Mar-18 8:53am

"Put your mouse on the floor! Now! Put your mouse on the floor!"