CString is not accepting values?

Question

0.00/5 (No votes)

See more:

I am using the following code to insert the values into the MYSQL database. In this CString SqlStr4 is accepting and taking values up to sqlstr3 assumption, after that it is not taking the other values. What is the problem in this?? help me.

CString SqlStr4;
SqlStr4 = "INSERT INTO log SET grab_date= '";
SqlStr4 +=strDateTime;
SqlStr4 += "',ip_address='";
SqlStr4 +=SqlStr3;
SqlStr4 += "',image='";
SqlStr4 += StrByte;
SqlStr4 +="';";

Posted 4-May-11 2:22am

Gokulnath007

Updated 4-May-11 2:45am

Hans Dietrich

v4

Add a Solution

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Olivier Levrey · Answer 1 · 2011-05-04T02:28:00

Solution 1

Check that SqlStr3 is a valid string.
For example a common way to "break" a CString object is to use its GetBuffer method, modify the string, and forget to call ReleaseBuffer...

I don't understand what might be wrong. Try to comment a few lines to know exactly which one raises the problem. For example:

C++

CString SqlStr4;
SqlStr4 = "INSERT INTO log SET grab_date= '";
SqlStr4 +=strDateTime;
SqlStr4 += "',ip_address='";
//SqlStr4 +=SqlStr3;
SqlStr4 += "',image='";
SqlStr4 += StrByte;
SqlStr4 +="';";

Once you found which lines (it might be several ones) causes the problem, do the same thing with that string. For example, if you found out that only SqlStr3 causes the problem, then look carefully how SqlStr3 is built. Try to build it a different way...

Posted 4-May-11 2:28am

Olivier Levrey

Updated 4-May-11 3:55am

v2

Comments

Gokulnath007 4-May-11 8:31am

Am not using GetBuffer method, all the variables having the correct values but it is not being taken into the Sqlstr4. I mean copying.

Olivier Levrey 4-May-11 8:38am

So there is something else you are not telling or showing in your code because I don't see any reason why the concatenation would fail here.
Are your using threads? Is SqlStr3 a shared variable?...

Gokulnath007 4-May-11 8:40am

No, SqlStr3 just stores the value 6. Am not using any thread.

Chuck O'Toole 4-May-11 21:48pm

Having looked at your shown output, "6" is terrible as an IP address so I don't think you're pulling the IP field out of the record set correctly. Have you looked at the varient variable with the debugger?

Chuck O'Toole 4-May-11 9:01am

Please show us values of strDateTime, SqlStr3, and StrByte as well as the final content of SqlStr4 so we can have a clue. And don't just say "stores the value 6", show the actual string value, it may not contain what you think it does.

Gokulnath007 4-May-11 9:29am

CString strDateTime;
SYSTEMTIME datetime;
::GetLocalTime(&datetime);
strDateTime.Format(_T("%02i-%02i-%02i %d:%d:%d"),
datetime.wYear,
datetime.wMonth,
datetime.wDay,
datetime.wHour,
datetime.wMinute,
datetime.wSecond);

CRecordset rs(db);
rs.Open(CRecordset::snapshot,strQuery,CRecordset::readOnly);
CDBVariant ip;
rs.GetFieldValue(short(0),ip);
CString strip;
for(int i=0;i<ip.m_pstringa->GetLength();i++)
{
strip+=ip.m_pstringA->GetAt(i);
}

strip.TrimRight();

CString SqlStr3(strip);

Gokulnath007 4-May-11 9:30am

StrSql4 contains INSERT INTO log SET grab_date= '2011-05-04 18:54:49',ip_address='6 this only. Remaining is not there in it.

Olivier Levrey 4-May-11 9:56am

I don't understand where the problem comes from but I gave you a piece of advice: see my uptaded answer. I hope this will help.

Stefan_Lang 5-May-11 4:20am

My guess is that ip.m_pstringA->GetAt(i) does not give you a char, but a wchar. I'm not at all sure what CString::operator+=() would do with an argument of type wchar, but my guess is it gets implicitely converted into something that results in nonprintable characters. Try casting to (char) first.

Olivier Levrey 5-May-11 4:34am

Good point. It deserves a try.

Stefan_Lang · Answer 2 · 2011-05-04T03:35:00

Solution 2

What do you mean by 'does not accept'? Do you mean you get a runtime error while building SqlStr4, or does your database complain about the string you pass? If the latter, is ip_address actually a string type? maybe you should skip the quotes on this field?

Posted 4-May-11 3:35am

Stefan_Lang

krmed · Answer 3 · 2011-05-04T04:19:00

Solution 3

This is just a hunch, but is there any chance that SqlStr3 is a unicode string? The reason I ask is that it appears that your other strings are not unicode and perhaps that is causing your problem.

Just a thought.

Posted 4-May-11 4:19am

krmed

Comments

Chuck O'Toole 4-May-11 21:43pm

Yes, it seems there's a NULL character (\0) in SqlStr3. I'm not sure how it got there, UNICODE would be one way, the other is this loop he used "for(int i=0;iGetLength();i++)". His post did not show the relationship for the terminating condition but it could also pick up a NULL if it's anything other then "<".

mbue · Answer 4 · 2011-05-04T04:31:00

Solution 4

You have to use the mysql_escape_string function to make a valid call.
So you have to escape your strings strDateTime, SqlStr3, StrByte.
Regards.

Posted 4-May-11 4:31am

mbue