How to avoid banches of if conditions

Question

0.00/5 (No votes)

See more:

I've got a filled map, which I need to rearrange according key. Such rearranging requires a lot of 'if' condition, which i found quite ugly.

please advise me any better suggestion.

thanks

What I have tried:

for (auto it = inventory_data.begin(); it != inventory_data.end(); it++){
      if(it->first == "device_model"){
        hardware_info.set ("model", it->second);
      }
      if (it->first == "device_serial"){
        hardware_info.set ("serialNumber", it->second);
      }
      if (it->first == "device_revision"){
        hardware_info.set ("revision", it->second);
      }
      if (it->first == "imei_number"){
        mobile_info.set ("imei", it->second);
      }
      if (it->first == "mobile_cellId"){
        mobile_info.set ("cellId", it->second);
      }
      if (it->first == "mobile_iccid"){
        mobile_info.set ("iccid", it->second);
      }
      if (it->first == "msisdn"){
        mobile_info.set ("msisdn", it->second);
      }
      if (it->first == "imsi"){
        mobile_info.set ("imsi", it->second);
      }
      if (it->first == "mcc"){
        mobile_info.set ("mcc", it->second);
      }
      if (it->first == "mnc"){
        mobile_info.set ("mnc", it->second);
      }
      if (it->first == "lac"){
        mobile_info.set ("lac", it->second);
      }
    }

Posted 3-Jul-17 19:28pm

User 12107792

Updated 3-Jul-17 21:35pm

Add a Solution

Comments

Mohibur Rashid 4-Jul-17 1:44am

for (auto it = inventory_data.begin(); it != inventory_data.end(); it++){
if(it->first == "device_model"){
hardware_info.set ("model", it->second);
} else if (it->first == "device_serial"){
hardware_info.set ("serialNumber", it->second);
} else if (it->first == "device_revision"){
hardware_info.set ("revision", it->second);
} else if (it->first == "imei_number"){
mobile_info.set ("imei", it->second);
} else if (it->first == "mobile_cellId"){
mobile_info.set ("cellId", it->second);
} else if (it->first == "mobile_iccid"){
mobile_info.set ("iccid", it->second);
} else {
mobile_info.set (it->first, it->second);
}
}

how about this?

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

RaunakGupta · Answer 1 · 2017-07-03T20:10:00

Solution 1

use switch instead of if . it is better solution when you have multiple condition and you know result as well

Posted 3-Jul-17 20:10pm

RaunakGupta

Comments

Klaus-Werner Konrad 5-Jul-17 6:51am

This will not work, because in C you can use Switch only with integral types, and a string in C is an ARRAY of characters ...

CPallini · Answer 2 · 2017-07-03T20:49:00

Solution 2

An alternative could be using a map, having the string as key value and a struct (containing the method to call and the method argument) as mapped value.

Posted 3-Jul-17 20:49pm

CPallini

Gaston Verelst · Answer 3 · 2017-07-03T21:35:00

Solution 4

How about using a dictionary to resolve this? Your whole loop is then reduced to 1 line, and future extensions become very easy (and error-proof).

Posted 3-Jul-17 21:35pm

Gaston Verelst

Comments

CPallini 4-Jul-17 3:46am

We call it 'map'. :-)

Gaston Verelst 4-Jul-17 5:52am

Sounds good to me :-)

User 12107792 · Answer 4 · 2017-07-03T20:54:00

Solution 3

thanks all.

I'd like to avoid such if / if-else statements @ Mohibur Rashid

My condition checking is string, not int @ Raunak Gupta

I've got a std::map which is already filled, and i need to iterate through the key to compare @CPallini

Posted 3-Jul-17 20:54pm

User 12107792

Comments

CPallini 4-Jul-17 2:56am

I suggested to use another map to link the string with a {method, method_argument} struct.

RaunakGupta 5-Jul-17 1:24am

you can use string in switch case also..
check this https://www.dotnetperls.com/string-switch