Connection to my database

Question

1.00/5 (1 vote)

See more:

So i cant seem to connect to my database - This is my app.config:

XML

<?xml version="1.0" encoding="utf-8" ?>
<configuration>
    <startup> 
        <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5.2" />
    
  <connectionstrings>
    <add name="Series" connectionString="Data Source=.;Initial Catalog=Series;IntegratedSecurity=True" providerName="System.Data.SqlClient" />

and this is my code in my DB class:

C#

public static SqlConnection ConnectToDB(SqlConnection connection)
        {
            try
            {
                if (connection == null)
                    connection = new SqlConnection(ConfigurationManager.ConnectionStrings["Series"].ConnectionString);
                connection.Open();
               
            }
            catch (Exception ex)
            {
                throw ex;
                
            }
            connection = DB.DisconnectFromDB(connection);
            return connection;
        }

- The name of the database i "Series"

What I have tried:

I think i tried everyting, cant really see the problem

Posted 9-Mar-17 3:28am

Member 12879522

Updated 9-Mar-17 4:00am

CHill60

v2

Add a Solution

Comments

F-ES Sitecore 9-Mar-17 9:29am

Let's start with the basics....what error message do you get?

CHill60 9-Mar-17 9:30am

You are setting the connection to the output from DisconnectFromDB

[no name] 9-Mar-17 9:47am

Well you didn't describe a problem. Step through your code with the debugger and then you might figure it out.

sachin.vishwa90 10-Mar-17 0:55am

have you mentioned the server address in your connection string?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CHill60 · Answer 1 · 2017-03-09T04:00:00

As @NotPoliticallyCorrect has stated - you need to step through your code with the debugger, examine variables and program flow and you might be able to understand what is going on. This article should help you Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]

Your use of Try-Catch is not really sensible - you are not adding anything to the exception before escalating it, so just let it percolate up through the thread. This article might help you Exception Handling Best Practices in .NET[^]

Your problem is the line

C#

connection = DB.DisconnectFromDB(connection);

I have no idea what DB is but I'm guessing that DisconnectFromDB does what it says and disconnects your carefully created connection!

On a final note - I wouldn't pass the connection around like that. Encapsulate the connection variable in your class. For a simplistic example...

C#

using System.Configuration;
using System.Data;
using System.Data.SqlClient;

namespace Sandbox
{
    public class DbClass
    {
        private SqlConnection connection;

        public bool ConnectToDb()
        {
            if (connection == null)
                connection = new SqlConnection(ConfigurationManager.ConnectionStrings["ConnectToDB"].ConnectionString);

            if (connection.State != ConnectionState.Open)
                connection.Open();

            return (connection.State == ConnectionState.Open);
        }
    }
}

Which I can call like this:

C#

var xdb = new DbClass();
  var b = xdb.ConnectToDb();
  Debug.Print(b.ToString());

- meaning the calling module does not need to know anything about System.Data.SqlClient ... which makes life a lot easier if I was to switch database provider

OriginalGriff · Answer 2 · 2017-03-09T03:59:00

Start with your connection string: a Data Source of "." is probably the place to start.
Try setting up a connection in VS with the Server Explorer pane:
1) Open Server Explorer.
2) Right click "Data connections" and select "Add connection"
3) In the dialog that follows, select your DataSource, and database, specify the security info, and press the "Test connection" button.
4) When the connection works, press "OK"
5) Highlight your database in the Server Explorer pane, and look at the Properties pane. A working example of the connection string will be shown, which you can copy and paste into your app.config file.

You'll need to change it for production, of course.

Connection to my database

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0