Value cannot be null. Parameter name: source

Question

1.00/5 (1 vote)

See more:

I am having this error how to resolve it...
Code is provided....
Controller.......

// GET: User/Edit/5
       public ActionResult Edit(int id)
       {
           UserDTO user = new UserDTO();
           user.UserID = id;
           SetViewBagData(id);
           return View(user);

       }

       // POST: User/Edit/5
       [HttpPost]
       public ActionResult Edit(UpdateUser model, int id)
       {
           try
           {
               UserDTO user = new UserDTO();
               user.UserName = model.UserName;

               new UserHandler().Update(user, id);

               return RedirectToAction("Details", new RouteValueDictionary (new { id = user.UserID}));
           }
           catch
           {
               return View();
           }
       }

XML

public void SetViewBagData(int _userId)
        {
            UserDTO r = new UserDTO();
            ViewBag.UserId = _userId;
            ViewBag.List_boolNullYesNo = this.List_boolNullYesNo();
            ViewBag.RoleId = new SelectList(r.Role.OrderBy(p => p.RoleName), "RoleID", "RoleName");
        }

        public List<SelectListItem> List_boolNullYesNo()
        {
            var _retVal = new List<SelectListItem>();
            try
            {
                _retVal.Add(new SelectListItem { Text = "Not Set", Value = null });
                _retVal.Add(new SelectListItem { Text = "Yes", Value = bool.TrueString });
                _retVal.Add(new SelectListItem { Text = "No", Value = bool.FalseString });
            }
            catch { }
            return _retVal;
        }

C#

public PartialViewResult AddUserRoleReturnPartialView(int id, int userId)
       {           
           new UserHandler().AddUserRole(id, userId);
           SetViewBagData(userId);
           return PartialView("_ListUserRoleTable", userId);
       }

Business Logic....

public class UserHandler
    {
        PriviligeContext db = new PriviligeContext();

        public List<UserDTO> GetData()
        {
            var query = from u in db.Users
                        select new UserDTO
                        {
                            UserName = u.Username
                           
                        };
            return query.ToList();
        }

        
        public void Insert(UserDTO user)
        {
            User u = new User();

            u.Username = user.UserName;

            db.Users.Add(u);
            db.SaveChanges();
        }       
        public void Update(UserDTO user, int id)
        {
            var u = db.Users.FirstOrDefault(i => i.UserID == id);
            u.Username = user.UserName;
            db.SaveChanges();
        }
       public void AddUserRole(int id, int userId)
       {
           Role role = db.Roles.Find(id);
           User user = db.Users.Find(userId); 
            
           if (!role.Users.Contains(user))
           {
               role.Users.Add(user);
               db.SaveChanges();
           }
       }
    }

DTO...

C#

namespace DTO
{
    public class UserDTO
    {
        public int UserID { get; set; }
        public string UserName { get; set; }
        public virtual ICollection<RoleDTO> Role { get; set; }
    }
}

C#

namespace DTO
{
    public class RoleDTO
    {
        public int RoleID { get; set; }
        public string RoleName { get; set; }
        public string Description { get; set; }
        public virtual ICollection<PriviligeDTO> Privilige { get; set; }
        public virtual ICollection<UserDTO> User { get; set; }
    }
}

Edit View......

<pre>model SampleWeb.Models.UpdateUser
@using (Html.BeginForm("Edit", "User", FormMethod.Post))
{
    @Html.ValidationSummary(true)
    &lt;input name='User_Id' id='User_Id' type="hidden" value="@ViewBag.UserId" /&gt;
    &lt;fieldset&gt;
        &lt;legend&gt;
            &lt;h3&gt;
                User Details
            &lt;/h3&gt;
        &lt;/legend&gt;
        @Html.Partial("_userDetailsEdit", Model)
        &lt;br /&gt;
        &lt;input type="submit" value="Save" /&gt;
    &lt;/fieldset&gt;

    &lt;fieldset&gt;
        &lt;legend&gt;
            &lt;h3&gt;
                Roles Associated with this User
            &lt;/h3&gt;
        &lt;/legend&gt;
        &lt;div class="panel" id="RolesTable"&gt;
            @Html.Partial("_ListUserRoleTable", Model)
        &lt;/div&gt;
        @Html.Partial("_ListEditableUserRoleTable")
        &lt;br /&gt;
        &lt;div&gt;
            @Html.ActionLink("Go to Roles", "RoleIndex", "Role")
        &lt;/div&gt;
    &lt;/fieldset&gt;
}
&lt;br /&gt;
&lt;div&gt;
    @Html.ActionLink("Go to Users", "Index", "Admin")
&lt;/div&gt;
&lt;div&gt;
    @Html.ActionLink("Back to List", "Index")
&lt;/div&gt;

@section Scripts {
    @Scripts.Render("~/bundles/jqueryval")
}</pre>

Posted 2-Nov-15 20:33pm

Member 10740412

Updated 23-Jul-19 21:32pm

Add a Solution

Comments

Krunal Rohit 3-Nov-15 2:43am

This error is usually related to the EF. Try using debugger and narrow down your issue and the post the relevant code and error details.
Posting this much code is not going to work anyone from us.

-KR

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 3-Nov-15 2:45am

Debug and find out the exact line.

Suvendu Shekhar Giri 3-Nov-15 2:50am

Have you debugged it? If yes, what was your finding?

Sinisa Hajnal 3-Nov-15 2:56am

Set a breakpoint and debug. Find exactly where it fails (and doing that you'll probably resolve it yourself). Good luck

John C Rayan 3-Nov-15 6:06am

Your problem is this line of code.
[HttpPost]
public ActionResult Edit(UpdateUser model, int id)

You are expecting route parameter id but you are passing it as user_id. Change it to user_id.

Member 10740412 3-Nov-15 6:19am

its giving me exception over this line....Value cannot be null
ViewBag.RoleId = new SelectList(r.Role.OrderBy(p => p.RoleName), "RoleID", "RoleName");

John C Rayan 3-Nov-15 6:37am

You mean this is another issue? is user_id working fine? where did you change to user_id. How do you invoke the edit view? you are expecting id in Edit action in the get too. How do you get your user id?

Member 10740412 3-Nov-15 6:59am

i change id in edit action to user_id...
and its giving me exception here

John C Rayan 3-Nov-15 7:08am

You have to change only in [HttpPost] Edit not [HttpGet]. Can you show me the changed code

Member 10740412 3-Nov-15 7:13am

public ActionResult Edit(int id)
{
UserDTO user = new UserDTO();
//USER user = database.USERS.Find(id);
//return View(user);
user.UserID = id;
SetViewBagData(id);
return View(user);

}

// POST: User/Edit/5
[HttpPost]

public ActionResult Edit(UpdateUser model, int user_Id)
{

try
{
UserDTO user = new UserDTO();
user.UserName = model.UserName;

new UserHandler().Update(user, user_Id);

return RedirectToAction("Details", new RouteValueDictionary (new { id = user.UserID}));
}
catch
{
return View();
}
}

John C Rayan 3-Nov-15 7:27am

Try these 3 things.

1. Change your parameter from user_Id to User_Id (Uppercase U) also try with string type instead of int
2. Check the html source and see you are definitely getting value for
@ViewBag.UserId in the following line.
<input name='User_Id' id='User_Id' type="hidden" value="@ViewBag.UserId" />

3. Remove User_Id parameter from the Edit post action and check the FormCollection to see if you see the hidden field User_Id

Member 10740412 3-Nov-15 8:13am

now i tried this but the same error is arising ...
public ActionResult Edit(UpdateUser model, string User_Id)
{
try
{

UserDTO user = new UserDTO();
user.UserName = model.UserName;

new UserHandler().Update(user,int.Parse(User_Id));

return RedirectToAction("Details", new RouteValueDictionary (new { id = user.UserID}));
}
catch
{
return View();
}
}

Member 10740412 3-Nov-15 8:23am

and also tried....
public ActionResult Edit(UpdateUser model)
{

try
{

UserDTO user = new UserDTO();
user.UserName = model.UserName;
int User_Id = user.UserID;
//new UserHandler().Update(user,int.Parse(User_Id));
new UserHandler().Update(user, User_Id);

return RedirectToAction("Details", new RouteValueDictionary (new { id = user.UserID}));
}
catch
{
return View();
}
}

John C Rayan 3-Nov-15 8:28am

Can you post the error here please. Also can you show me your partial view for _userDetailsEdit

Member 10740412 3-Nov-15 8:40am

Value cannot be null.
Parameter name: source

Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.ArgumentNullException: Value cannot be null.
Parameter name: source

Source Error:

Line 81: ViewBag.UserId = _userId;
Line 82: // ViewBag.List_boolNullYesNo = this.List_boolNullYesNo();
Line 83: ViewBag.RoleId = new SelectList(r.Role.OrderBy(p => p.RoleName), "RoleID", "RoleName");
Line 84: }
Line 85:

Source File: f:\DOT NET WORKINGS\SamplePrivilige\SampleWeb\Controllers\UserController.cs Line: 83

Stack Trace:

[ArgumentNullException: Value cannot be null.
Parameter name: source]
System.Linq.OrderedEnumerable`2..ctor(IEnumerable`1 source, Func`2 keySelector, IComparer`1 comparer, Boolean descending) +5882427
System.Linq.Enumerable.OrderBy(IEnumerable`1 source, Func`2 keySelector) +77
SampleWeb.Controllers.UserController.SetViewBagData(Int32 _userId) in f:\DOT NET WORKINGS\SamplePrivilige\SampleWeb\Controllers\UserController.cs:83
SampleWeb.Controllers.UserController.Edit(Int32 id) in f:\DOT NET WORKINGS\SamplePrivilige\SampleWeb\Controllers\UserController.cs:148
lambda_method(Closure , ControllerBase , Object[] ) +141
System.Web.Mvc.ReflectedActionDescriptor.Execute(ControllerContext controllerContext, IDictionary`2 parameters) +229
System.Web.Mvc.ControllerActionInvoker.InvokeActionMethod(ControllerContext controllerContext, ActionDescriptor actionDescriptor, IDictionary`2 parameters) +35
System.Web.Mvc.Async.AsyncControllerActionInvoker.<begininvokesynchronousactionmethod>b__39(IAsyncResult asyncResult, ActionInvocation innerInvokeState) +39
System.Web.Mvc.Async.WrappedAsyncResult`2.CallEndDelegate(IAsyncResult asyncResult) +71
System.Web.Mvc.Async.AsyncControllerActionInvoker.EndInvokeActionMethod(IAsyncResult asyncResult) +42
System.Web.Mvc.Async.AsyncInvocationWithFilters.<invokeactionmethodfilterasynchronouslyrecursive>b__3d() +72
System.Web.Mvc.Async.<>c__DisplayClass46.<invokeactionmethodfilterasynchronouslyrecursive>b__3f() +386
System.Web.Mvc.Async.AsyncControllerActionInvoker.EndInvokeActionMethodWithFilters(IAsyncResult asyncResult) +42
System.Web.Mvc.Async.<>c__DisplayClass2b.<begininvokeaction>b__1c() +38
System.Web.Mvc.Async.<>c__DisplayClass21.<begininvokeaction>b__1e(IAsyncResult asyncResult) +186
System.Web.Mvc.Async.AsyncControllerActionInvoker.EndInvokeAction(IAsyncResult asyncResult) +38
System.Web.Mvc.Controller.<beginexecutecore>b__1d(IAsyncResult asyncResult, ExecuteCoreState innerState) +29
System.Web.Mvc.Async.WrappedAsyncVoid`1.CallEndDelegate(IAsyncResult asyncResult) +67
System.Web.Mvc.Controller.EndExecuteCore(IAsyncResult asyncResult) +53
System.Web.Mvc.Async.WrappedAsyncVoid`1.CallEndDelegate(IAsyncResult asyncResult) +36
System.Web.Mvc.Controller.EndExecute(IAsyncResult asyncResult) +38
System.Web.Mvc.MvcHandler.<beginprocessrequest>b__5(IAsyncResult asyncResult, ProcessRequestState innerState) +44
System.Web.Mvc.Async.WrappedAsyncVoid`1.CallEndDelegate(IAsyncResult asyncResult) +67
System.Web.Mvc.MvcHandler.EndProcessRequest(IAsyncResult asyncResult) +38
System.Web.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute() +399
System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously) +137

Member 10740412 3-Nov-15 8:40am

@model DTO.UserDTO
@{if (Model != null)
{
<div id="expanderContent">
<table style='width: 100%'>

<tr>
<td style='width: 10%; font-weight: bold' class='userTable'>
@Html.LabelFor(model => model.UserName)
</td>
<td style='width: 28%' class='userTable'>
@Html.TextBoxFor(model => model.UserName, new { @class = "singlelinetextinput" })
@Html.ValidationMessageFor(model => model.UserName)
</td>
<td></td>
</tr>
</table>
</div>
}
}

John C Rayan 3-Nov-15 9:23am

Well, the exception is thrown in GET action not POST. Now show me how do you call Edit action from your view. I guess you must be calling it from some other view.

John C Rayan 3-Nov-15 9:31am

You have to debug and see if r.Role in new SelectList(r.Role.OrderBy(p => p.RoleName), "RoleID", "RoleName");
is not null. I think you haven't loaded the roles for the user. I can't see it anywhere.

Member 10740412 3-Nov-15 9:35am

Edit View.....

@model SampleWeb.Models.UpdateUser

@{
ViewBag.Title = "Edit";
}

@using (Html.BeginForm("Edit", "User", FormMethod.Post))
{
@Html.ValidationSummary(true)
<input name='User_Id' id='User_Id' type="hidden" value="@ViewBag.UserId" />

<fieldset>

User Details

@Html.Partial("_userDetailsEdit", Model)
<br />
<input type="submit" value="Save" />
</fieldset>

<fieldset>
@**@
Roles Associated with this User
@*
*@
<div class="panel" id="RolesTable">
@Html.Partial("_ListUserRoleTable", Model)
</div>
@Html.Partial("_ListEditableUserRoleTable")
<br />
@*<div>
@Html.ActionLink("Go to Roles", "RoleIndex", "Role")
</div>*@
</fieldset>
}
<br />
<div>
@Html.ActionLink("Go to Users", "Index", "Users")
</div>
<div>
@Html.ActionLink("Back to List", "Index")
</div>

@section Scripts {
@Scripts.Render("~/bundles/jqueryval")
}

Index View.....
@model IEnumerable<DTO.UserDTO>

@{
ViewBag.Title = "Index";
}

Index

<p>
@Html.ActionLink("Create New", "Create")
</p>
<table class="table">
<tr>

<th>
@Html.DisplayNameFor(model => model.UserName)
</th>
<th></th>
</tr>

@foreach (var item in Model) {
<tr>

<td>
@Html.DisplayFor(modelItem => item.UserName)
</td>
<td>
@Html.ActionLink("Edit", "Edit", new { /*id=item.PrimaryKey */ }) |
@Html.ActionLink("Details", "Details", new { /* id=item.PrimaryKey */ }) |
@Html.ActionLink("Delete", "Delete", new { /* id=item.PrimaryKey */ })
</td>
</tr>
}

</table>

Member 10740412 3-Nov-15 9:49am

Here is where Roles are loaded...
[HttpGet]

public PartialViewResult AddUserRoleReturnPartialView(int id, int userId)
{
new UserHandler().AddUserRole(id, userId);
SetViewBagData(userId);
return PartialView("_ListUserRoleTable", userId);

}
AddUserRole() Function Definition....
public void AddUserRole(int id, int userId)
{
Role role = db.Roles.Find(id);
User user = db.Users.Find(userId);

if (!role.Users.Contains(user))
{
role.Users.Add(user);
db.SaveChanges();
}
}

John C Rayan 3-Nov-15 10:22am

Uncomment id param in here so that id will be passed to Edit . @Html.ActionLink("Edit", "Edit", new { /*id=item.PrimaryKey */ })
Where do you load roles in here :
public ActionResult Edit(int id)
{
UserDTO user = new UserDTO();
user.UserID = id;
SetViewBagData(id);
return View(user);

}

I think it is better if you could send me the project and can fix it for you if you are not able to follow me.

Member 10740412 3-Nov-15 11:26am

how can i send you project

John C Rayan 3-Nov-15 11:29am

give me your email and I send you my email. Send to me by email. Did you try with uncommenting the id. Try this
@Html.ActionLink("Edit", "Edit", new { id=@item.PrimaryKey })

Member 10740412 3-Nov-15 11:32am

I tried but it didn't work

Member 10740412 3-Nov-15 11:33am

fhdgfdfsjdsjfjsd

Member 10740412 3-Nov-15 11:49am

Aren't u going to help me????

Member 10740412 3-Nov-15 11:56am

Plzzzz reply me......

John C Rayan 3-Nov-15 13:05pm

I will send a email soon

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

John C Rayan · Accepted Answer · 2015-11-07T01:55:00

Solution 1

I have sent back to you the amended project in working condition

Posted 7-Nov-15 1:55am

John C Rayan

Comments

Member 3777988 22-Dec-16 17:15pm

please, can you add the comment with the solution, i have the same problem

[HttpPost]
public ActionResult Update(DataEventViewModel model)
{
model.Update();
return RedirectToAction("Detail", "DataActivityProject", new { dataActivityProjectID = model._DataEvent.DataActivityProjectID });
}

@using (Html.BeginForm("Update", "DataEvent", null, FormMethod.Post, null))
{

@Html.Partial("_DataEventForm")

@Html.ActionLink("Cancel", "Detail", "DataActivityProject", new { dataActivityProjectID = Model._DataEvent.DataActivityProject.DataActivityProjectID }, new { @class = "btn btn-warning" })
@*Delete*@

}

John C Rayan 30-Dec-16 9:18am

Not necessarily same issue. Can you please post what error you are getting? If possible create a new question.