Crystal reports display image from SQL

Question

1.00/5 (1 vote)

See more:

Hi,

I have a c# winform app that stores images in an sql database as "image".
I can store the image just fine but when a print the report the image does not appear.

Can anyone help, thanks in advance.
The code i use to store the image and print the report is below:

What I have tried:

//insert image in SQL:

C#

con.Open();
MemoryStream ms = new MemoryStream();
pictureBox2.Image.Save(ms, ImageFormat.Jpeg);
byte[] photo = new byte[ms.Length];
SqlCommand cmd = con.CreateCommand();
cmd.CommandType = CommandType.Text;
cmd.CommandText = "insert into dbo.temp (maquete) VALUES ('" + Photo + "');
cmd.ExecuteNonQuery();
con.Close();
report report = new report();
report.ShowDialog();

//print report

C#

con.Open();
SqlCommand cmd = con.CreateCommand();
cmd.CommandType = CommandType.Text;
cmd.CommandText = "select * from temp";
cmd.ExecuteNonQuery();
bdDataSet ds = new bdDataSet();
SqlDataAdapter da = new SqlDataAdapter(cmd);
da.Fill(ds.temp);
hytherm myReport = new hytherm();
myReport.SetDataSource(ds);
crystalReportViewer1.ReportSource = myReport;
con.Close();

Posted 20-Nov-16 22:31pm

Marc-IT

Updated 21-Nov-16 8:35am

Add a Solution

2 solutions

Solution 1

Store and Retrieve Image in Crystal Reports From SQL Database and Folder Using ASP.Net[^]

C#

tp://www.aspsnippets.com/Articles/Display-image-from-database-in-Crystal-Report-in-ASPNet-using-C-and-VBNet.aspx

Posted 21-Nov-16 3:10am

$*Developer - Vaibhav*$

Updated 21-Nov-16 3:13am

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2016-11-21T08:35:00

NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

At the moment, using string concatenation, your final query will be:

SQL

insert into dbo.temp (maquete) VALUES ('System.Byte[]')

Clearly, the literal string System.Byte[] is not a valid byte array.

(The byte array is also empty - you declare it, but you never populate it.)

In order to pass a byte array to your query, you must use a parameter:

C#

using (var connection = new SqlConnection("..."))
using (var command = new SqlCommand("INSERT INTO dbo.temp (maquete) VALUES (@photo)", connection))
{
    using (var ms = new MemoryStream())
    {
        pictureBox2.Image.Save(ms, ImageFormat.Jpeg);
        byte[] photo = ms.ToArray();
        command.Parameters.AddWithValue("@photo", photo);
    }
    
    connection.Open();
    command.ExecuteNonQuery();
}

NB: All of the images that you think you've stored in your table so far are corrupt. You will need to remove and re-add them.

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]