Help me with this problem? I cant find the no vowels

Question

1.00/5 (2 votes)

See more:

VB

Module Module1
    Dim no As Integer
    Public Class text
        Private s As String

        Public Sub vowels()
            Dim l, i, number As Integer
            no = 0
            Console.WriteLine("type the text")
            s = Console.ReadLine()
            l = Len(s)
            Do While i < l

                If s(i) = "a" Then
                ElseIf s(i) = "A" Then
                ElseIf s(i) = "e" Then
                ElseIf s(i) = "E" Then
                ElseIf s(i) = "i" Then
                ElseIf s(i) = "I" Then
                ElseIf s(i) = "o" Then
                ElseIf s(i) = "O" Then
                ElseIf s(i) = "U" Then
                ElseIf s(i) = "u" Then
                    no = no + 1
                End If
                i = i + 1
            Loop
            number = no
            Console.WriteLine("The no of vowels is {0}", number)

        End Sub

            
    End Class
    Public Sub Main()
        Dim a As New text
        a.vowels()


        Console.ReadKey()
    End Sub

End Module

What I have tried:

i have tried it on my computer but didnt get it exactly

Posted 7-Sep-16 3:14am

Member 12725211

Updated 7-Sep-16 5:12am

Garth J Lancaster

v2

Add a Solution

Comments

[no name] 7-Sep-16 9:19am

Didn't get what exactly? Tried "it"? What is "it"? Just dumping your unformatted, hard to read code into a posting is not asking a question or describing a problem.

Dominic Burford 7-Sep-16 9:35am

Step through the code in the debugger and see where the problem is. A brief look at the code shows that you are only incrementing your counter "no" when the letter "u" is matched. I'm guessing this is not what you were wanting. Also, consider re-writing this as a CASE statement rather than a bunch of If / ElseIf statements.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Garth J Lancaster · Answer 1 · 2016-09-07T03:33:00

this

If s(i) = "a" Then
                ElseIf s(i) = "A" Then
                ElseIf s(i) = "e" Then
                ElseIf s(i) = "E" Then
                ElseIf s(i) = "i" Then
                ElseIf s(i) = "I" Then
                ElseIf s(i) = "o" Then
                ElseIf s(i) = "O" Then
                ElseIf s(i) = "U" Then
                ElseIf s(i) = "u" Then
                    no = no + 1
                End If

is truly horrible !

shouldnt vb.net be

if (some condition) then (do something)
elseif (some other condition) then (do something)
....

had you learned to use a debugger you'd likely see what your issue(s) are

how about a better way ?

declare a constant string (this is not in any language in particular)

VB

constant string vowels = "AaEeIiOoUu";

and then in your loop do a test like

VB

if vowels.contains(s[i]) then no = no + 1;

there's a better extension to what Ive shown you btw, along the lines of :-

VB

constant string vowels = "AEIOU";

VB

if vowels.contains(uppercase(s[i])) then no = no + 1;

I'll leave it up to you to properly code either of those in VB.NET

Dave Kreskowiak · Answer 2 · 2016-09-07T03:58:00

Your code will only count lower case 'u'. Having an empty "Then" clause is telling the code to do nothing if the condition is true. This is what your code is really doing:

VB

If s(i) = "a" Then
    ' Do nothing
ElseIf s(i) = "A" Then
    ' Do nothing
ElseIf s(i) = "e" Then
    ' Do nothing
ElseIf s(i) = "E" Then
    ' Do nothing
ElseIf s(i) = "i" Then
    ' Do nothing
ElseIf s(i) = "I" Then
    ' Do nothing
ElseIf s(i) = "o" Then
    ' Do nothing
ElseIf s(i) = "O" Then
    ' Do nothing
ElseIf s(i) = "U" Then
    ' Do nothing
ElseIf s(i) = "u" Then
    no = no + 1
End If

You do realize there are string comparisons that ignore case, right? There are also others that can look for a string (or character) in another string and tell you if it's in there?

You can do this assignment in a single IF statement.

Patrice T · Answer 3 · 2016-09-07T05:12:00

VB

If s(i) = "a" Then ' Count a vowel here
ElseIf s(i) = "A" Then ' Count a vowel here
ElseIf s(i) = "e" Then ' Count a vowel here
ElseIf s(i) = "E" Then ' Count a vowel here
ElseIf s(i) = "i" Then ' Count a vowel here
ElseIf s(i) = "I" Then ' Count a vowel here
ElseIf s(i) = "o" Then ' Count a vowel here
ElseIf s(i) = "O" Then ' Count a vowel here
ElseIf s(i) = "U" Then ' Count a vowel here
ElseIf s(i) = "u" Then no = no + 1
End If

Only "u" is correct.

Help me with this problem? I cant find the no vowels

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0