Syntax error in Insert into statement using access DB

Question

0.00/5 (No votes)

See more:

Hi Guys,
I am using access Database to insert values, following is the code:

C#

public Int32 InsertUser(string firstnm, string lastnm, string unm, string pwd, string add, string email, string contact)
    {
        int i = 0;
        OleDbConnection con = GetConnection();
        OleDbCommand cmd = new OleDbCommand("insert into usermaster(FullName,UserName,Password,Address,EmailID,ContactNo) values('" + firstnm + " " + lastnm + "','" + unm + "','" + pwd + "','" + add + "','" + email + "','" + contact + "')", con);
        con.Open();
        i = cmd.ExecuteNonQuery();
        con.Close();
        return i;
    }

Now when I am running it with VS it gives me Error "SYNTAX ERROR IN INSERT INTO STATEMENT" but when I use the same command and run it through Access query wizard it gets executed.

So where is the problem. Any help.

Posted 19-Dec-15 19:48pm

Mitul Birla

Add a Solution

2 solutions

Solution 1

Use parameter queries instead of string concatenation : http://www.mikesdotnetting.com/article/26/parameter-queries-in-asp-net-with-ms-access[^]

Posted 19-Dec-15 20:17pm

Mehdi Gholam

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2015-12-19T20:31:00

Just to add to what Mehdi says:
Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead. The chances are that will cure the problem you have spotted.
There are two other problems here:
1) You should Dispose OleDb objects when you are finished with them:

C#

using (OleDbConnection con = GetConnection())
    {
    using (OleDbCommand cmd = new OleDbCommand("INSERT INTO usermaster (FullName,UserName,Password,Address,EmailID,ContactNo) VALUES (@NM, @UN, @PW, @AD, @EM, @CN)", con))
       {
       cmd.Parameters.AddWithValue("@NM", firstnm + " " + lastnm);
       cmd.Parameters.AddWithValue("@UN", unm);
       cmd.Parameters.AddWithValue("@PW", pwd);
       cmd.Parameters.AddWithValue("@AD", add);
       cmd.Parameters.AddWithValue("@EM", email);
       cmd.Parameters.AddWithValue("@CN", contact);
       con.Open();
       return (cmd.ExecuteNonQuery());
       }
   }

2) Never store passwords in clear text - it is a major security risk. There is some information on how to do it here: Password Storage: How to do it.[^]