Need to search in a database whille the criteria is a date field

Question

0.00/5 (No votes)

See more:

Hi All,

please i need your urgent help in solving the below problem..

I'm trying to fill a DataGridView with Access table but the selected data holding the below multiple criteria , the problem that it didn't results correctly as an error MSG appeared

below codes needs to be solved please..

P.S: if i removed the date section the query got executed correctly but i need the date criteria urgently plz

VB

Private Sub Supplier_Query()
        Dim Yesterday As DateTime = DateTime.Today.AddDays(-1)
        cnnOLEDB.ConnectionString = strConnectionString
        cnnOLEDB.Open()
        'Dim strUpdate As String
        Try
            Dim sqlQRY As String
            sqlQRY = "Select * From Customers WHERE SupplierName = '" & SuppNameVariable.Text & "' AND SupplierFeedbackDate = '.... / .... / .....' AND DateAdded <'" & CDate(Yesterday) & "'"
            Dim da As OleDbDataAdapter
            Dim ds As DataSet = New DataSet
            da = New OleDbDataAdapter(sqlQRY, cnnOLEDB)
            Dim cb As OleDbCommandBuilder = New OleDbCommandBuilder(da)
            da.Fill(ds, "Customers")
            Alerting_Escalation_Tool.DataGridViewCustomer.DataSource = ds
            Alerting_Escalation_Tool.DataGridViewCustomer.DataMember = "Customers"
        Catch ex As OleDbException
            MsgBox(ex.ToString)
        End Try
        cnnOLEDB.Close()
End  Sub()

Posted 15-Dec-15 15:23pm

BassamKassem

Add a Solution

Comments

DamithSL 15-Dec-15 22:07pm

what is the error message and what is the column data type of DateAdded in your access database?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2015-12-15T15:35:00

Your approach is wrong from the very beginning. The query composed by concatenation with strings taken from UI. Not only repeated string concatenation is inefficient (because strings are immutable; do I have to explain why it makes repeated concatenation bad?), but there is way more important issue: it opens the doors to a well-known exploit called SQL injection.

This is how it works: http://xkcd.com/327.

Are you getting the idea? The string taken from a control can be anything, including… a fragment of SQL code.

What to do? Just read about this problem and the main remedy: parametrized statements: http://en.wikipedia.org/wiki/SQL_injection.

With ADO.NET, use this: http://msdn.microsoft.com/en-us/library/ff648339.aspx.

Please see my past answers for some more detail:
EROR IN UPATE in com.ExecuteNonQuery();,
hi name is not displaying in name?.

—SA

BassamKassem · Answer 2 · 2015-12-15T19:29:00

This is how i fixed it..

and by the way the field DateAdded holds Date Type in data base design

sqlQRY = "Select * From Customers WHERE SupplierName = '" & SuppNameVariable.Text & "' AND SupplierFeedbackDate = '.... / .... / .....' AND DateAdded < #" + Yesterday + "#"

Thanks guys
Regards
Bassam

Need to search in a database whille the criteria is a date field

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0