Getting SQL Error What should I Do

Question

0.00/5 (No votes)

See more:

With this codes I m still getting error

Exception thrown: 'System.Data.SqlClient.SqlException' in System.Data.dll

Additional information: Incorrect syntax near ')'.

C#

<pre lang="text"> private void insert_Click(object sender, RoutedEventArgs e)
        {
            con.Open();
            SqlCommand cmd = new SqlCommand (@"Insert into mob (FirstName, LastName, Mobile, emailid, Category) VALUES 
                ('"+ First.Text + "','" + Last.Text +"','" + Mobile.Text +"', '" + email.Text + "','" +comboBox + "',)", con);
            cmd.ExecuteNonQuery();
            con.Close();


        }

Posted 1-Dec-15 18:11pm

amitkarnik2211

Updated 1-Dec-15 18:21pm

Suvendu Shekhar Giri

v2

Add a Solution

Comments

jgakenhe 2-Dec-15 0:35am

Suvendu took out the comma before the ); so it should work. Though you should not put this on the open Internet because of the SQL Injection vulnerability.

Anything the user types in will be executed by the SQL Server; so if they type DELETE in first name it will get executed by SQL Server.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Suvendu Shekhar Giri · Answer 1 · 2015-12-01T18:27:00

You have an additional comma (,) at the end of the list of values in the INSERT statement.
Try this-

C#

SqlCommand cmd = new SqlCommand (@"Insert into mob (FirstName, LastName, Mobile, emailid, Category) VALUES
              ('"+ First.Text + "','" + Last.Text +"','" + Mobile.Text +"', '" + email.Text + "','" +comboBox + "')", con);

Note: Your code is vulnerable to SQL Injection. I strongly recommend to use Parameterized Query or Stored Procedure instead.
Reference:
Using Parameterized queries to prevent SQL Injection Attacks in SQL Server[^]

Hope, it helps :)