my output is always zero for "ret" value why?

Question

2.60/5 (2 votes)

See more:

C#

using System;

namespace tax
{
    class Program
    {
        static void Main(string[] args)
        {
            float ret;
            Console.WriteLine("Enter gross pay");
            int gross = Convert.ToInt32(Console.ReadLine());
            Program n = new Program();
            ret = n.logic(gross);
            Console.WriteLine("Tax for your gross pay is {0}", ret);
            float total = gross + ret;
            Console.WriteLine("total amount to be paid is {0}", total);
            Console.ReadKey();



        }
        public float logic(int c)
        {
            float result;
            if(c <= 100000)
            {
                result= 0;
            }
            else if((c >100000)&&(c <=300000))
            {
               result =   (c  * (15 / 100));
            }
            else if(c >300000)
            {
               result =  (c  * (28 / 100));
            }
            else
            {
                result = 0.0f;
            }
            return result;
        }
    }
}

Posted 24-Sep-15 4:52am

Member 12009218

Updated 24-Sep-15 4:59am

Leo Chapiro

v2

Add a Solution

Comments

F-ES Sitecore 24-Sep-15 11:04am

Step through your code line by line and find out for yourself.

http://www.codeproject.com/Articles/79508/Mastering-Debugging-in-Visual-Studio-A-Beginn

Learning to debug your code and resolve your own problems is a vital skill.

Palash Mondal_ 24-Sep-15 11:10am

You need to provide bit more info here like what values you have passed for testing, etc.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2015-09-24T05:06:00

Quote:
result = (c * (15 / 100));

Quote:
result = (c * (28 / 100));

The expressions on the right hand side of the above statements are evaluated using integer math. Change them to (for instance)

result =  (c  * (15.0f / 100));

result =  (c  * (28.0f / 100));

to force floating point evaluation.

Leo Chapiro · Accepted Answer · 2015-09-24T05:07:00

Use float instead of integer!
The error by using an integer is that 15 / 100 = 0 as well as 28 / 100 = 0!

C#

public float logic(float c)
{
    float result;
    if(c <= 100000)
    {
        result= 0;
    }
    else if((c >100000)&&(c <=300000))
    {
       result =   (c  * (15f / 100f));
    }
    else if(c >300000)
    {
       result =  (c  * (28f / 100f));
    }
    else
    {
        result = 0.0f;
    }
    return result;
}

my output is always zero for "ret" value why?

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0