input string was not in correct mood

Question

1.00/5 (1 vote)

See more:

hi
i am making a login page and it is working but once i open first time then i am getting a message " INPUT STRING WAS NOT IN CRRECT FORMAT"
PLEASE check and guide me where i am wrong

C#

private void button4_Click(object sender, EventArgs e)
{
    Form1 fr = new Form1();
    fr.Refresh();
    try
    {
        con = new SqlConnection("Data Source=.;Initial Catalog=DSIIDC2;Integrated Security=True");
        cmd = new SqlCommand("select * from login where username='" + txtusername.Text + "' and password='" + txtpassword.Text + "' and role='admin01'", con);
       // cmd = new SqlCommand("select username='" + txtusername.Text + "', password='" + txtpassword.Text + "' from login where role='admin01'");
        SqlDataAdapter da = new SqlDataAdapter(cmd);
        DataTable datatab = new DataTable();
        da.Fill(datatab);
        if ("admin" == txtusername.Text && "dsiidc" == txtpassword.Text && "admin01" == "admin01")
        {
            //Session["userone"] = TextBox1.Text;

            frm2.Show();


        }
        else if (("admin" == txtusername.Text && "admin" == txtpassword.Text && "admin02" == "admin02"))
        {

            ad.Show();
            da.Dispose();

        }
        else
        {
            txtpassword.Text = "";
            txtpassword.Text = "";


        }

    }

    catch (Exception ex)
    {
        MessageBox.Show("Please Enter User name and password");
    }


}

Posted 10-Jun-15 20:44pm

faizyab 2009

Updated 10-Jun-15 20:59pm

King Fisher

v2

Add a Solution

Comments

King Fisher 11-Jun-15 3:01am

So, whats your Input Data?

Richard MacCutchan 11-Jun-15 3:53am

Just about everything is wrong with that code. You are storing the passwords in clear text. And you are using string concatenation which can lead to the destruction of your database.

Dave Kreskowiak 11-Jun-15 8:52am

virtual +5

José Amílcar Casimiro 11-Jun-15 4:37am

Your code is garbage, you send out.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ZurdoDev · Answer 1 · 2015-06-11T02:01:00

If you debug the code you'll see which line of code is causing the error. Then you'll see what the problem is with the string. However, I don't see anything in the code you have posted that would cause that error so again, pay attention to where the error tells you it is happening.

Then you'll also want to change your code to use parameters.

For example:

C#

 cmd = new SqlCommand("select * from login where username=@userName and password=@password and role='admin01'", con);
cmd.Parameters.AddWithValue("@userName", txtusername.Text);
cmd.Parameters.AddWithValue("@password", txtpassword.Text);