Cannot add an entity that already exists?

Question

4.00/5 (1 vote)

See more:

I am inserting multiple records in my table using loop. After insert first record exception Generates.
ERROR:- Cannot add an entity that already exists?

Below is my Code.

Solved-

C#

 PromoCodeForSpecificBook1 obj;
foreach(var i in Model.BookDetail)
                      {
   obj = new PromoCodeForSpecificBook1();
                          obj.BookId = i.ID; //Convert.ToInt32(Model.Id);
                          var P = DB.BookPromoCodes.OrderByDescending(X => X.Id).FirstOrDefault().Id;
                          obj.PromoCodeId =P;
                          DB.PromoCodeForSpecificBook1s.InsertOnSubmit(obj);
                          DB.SubmitChanges();



                        
                      }

Posted 19-May-15 18:46pm

Naveen Kumar Tiwari

Updated 19-May-15 19:12pm

v3

Add a Solution

Comments

Pankit Patel 20-May-15 1:00am

create new object every time in loop then this error will be removed.
eg. obj = new Object() or whatever.

Naveen Kumar Tiwari 20-May-15 1:10am

thanks done

Pankit Patel 20-May-15 1:29am

Enjoy coding :)

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Raul Iloc · Answer 1 · 2015-05-19T19:20:00

1.In order to add new records in the database you have to create new objects in your foreach loop.

2.A 2nd problem is the fact that you are reading the same booking promo code for each item and should be read only ones before the foreach.

3.A 3rd optimisation could be to save all changes only ones at the end of the foreach.

The modified source code should be:

C#

var P = DB.BookPromoCodes.OrderByDescending(X => X.Id).FirstOrDefault().Id;
foreach(var i in Model.BookDetail)
                      {
                          PromoCodeForSpecificBook obj = new PromoCodSpecificBook(); //Create your entity!
                          obj.BookId = i.ID;
                          obj.PromoCodeId =P;
                          DB.PromoCodeForSpecificBooks.InsertOnSubmit(obj);
                      }
DB.SubmitChanges(); //Save all changes in a single call!