BackgroundWorker not working properly

Question

1.00/5 (1 vote)

See more:

Background Worker doesn't work. still hangs the UI.

Even Progress report doesn't reflect in progress bar.

C#

private void cmdStartUtility_Click(object sender, EventArgs e)
       {
          backgroundWorker.RunWorkerAsync();
       }

C#

private void backgroundWorker_DoWork(object sender, DoWorkEventArgs e)
       {

           this.Invoke(new Action(() =>
           {

               for (int i = 0; i < 100;i++ )
               {
                   Thread.Sleep(1000);
                   backgroundWorker.ReportProgress(i);
                   txtLog.Text = i.ToString();
               }

                   backgroundWorker.ReportProgress(100);
           }));
       }

C#

private void backgroundWorker_ProgressChanged(object sender, ProgressChangedEventArgs e)
       {
           progressBar1.Value = e.ProgressPercentage;
       }

Posted 10-May-15 20:16pm

Tanmay6193

Add a Solution

Comments

Mehdi Gholam 11-May-15 2:34am

Why the Invoke() and new Action() ?

Sergey Alexandrovich Kryukov 11-May-15 2:43am

"Why Invoke?" is a correct question, but "why new Action" is not — this is how Invoke is used. Of course, using Invoke is the total absurd. I'll answer the question, please see.
—SA

2 solutions

Solution 2

I guess you work with WinForms. The Invoke method lets you to run code in the UI thread. But, why do you run the whole of the worker's code (including the Sleep statement that blocks...) in the UI thread? ~~Try to run only the progress change using the Invoke method.~~ Try to remove the Invoke call from DoWork and, move the whole of the UI changes to the backgroundWorker_ProgressChanged method (see the comment below). Something like:

C#

private void backgroundWorker_DoWork(object sender, DoWorkEventArgs e)
       {
               for (int i = 0; i < 100;i++ )
               {
                   Thread.Sleep(1000);
                   backgroundWorker.ReportProgress(i);                   
               }
 
               backgroundWorker.ReportProgress(100);
       }

private void backgroundWorker_ProgressChanged(object sender, ProgressChangedEventArgs e)
       {
           txtLog.Text = e.ProgressPercentage.ToString();
           progressBar1.Value = e.ProgressPercentage;
       }

Posted 10-May-15 20:54pm

Shmuel Zang

Updated 11-May-15 21:14pm

v3

Comments

Sascha Lefèvre 11-May-15 14:31pm

Sorry Shmuel, I had to vote 1: The ProgressChanged-eventhandler is automatically executed on the UI-thread. No invoking neccessary there (likewise the RunWorkerCompleted-eventhandler). Only in DoWork(..) it's neccessary to use Invoke for accessing the UI. And 'txtLog' looks like a TextBox, so setting its .Text-property should either be done via Invoke in DoWork() or moved to ProgressChanged(..). I will reconsider my vote if you improve your answer.
/Sascha

Shmuel Zang 12-May-15 3:11am

I accept the comment. I changed the solution appropriately.

Sascha Lefèvre 12-May-15 7:06am

Very well, my 5 :)

Shmuel Zang 12-May-15 7:45am

Thanks.

George Swan 12-May-15 14:24pm

If possible, I'd use the Task Parallel Library (TPL) rather than the Background worker class. It's cleaner and more simple to set up.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2015-05-10T20:46:00

Solution 1

I haven't seen so much of absurd for a long time. You create a separate thread and then invoke all its code back to the UI thread. All code executed on the non-UI thread should not be under Invoke or BeginInvoke. You should use these methods only in some quickly executed actions which do something to the UI.

Please see my past answer and my other answers referenced in this one: .NET event on main thread[^].

—SA

Posted 10-May-15 20:46pm

Sergey Alexandrovich Kryukov

Comments

Mehdi Gholam 11-May-15 2:50am

Yes exactly! and if you need to update the UI then use ReportProgress() that's what it is there for.

5'ed

Sergey Alexandrovich Kryukov 11-May-15 2:59am

Thank you, Mehdi.
—SA

Shmuel Zang 11-May-15 4:05am

5'ed. It really looks strange to create a worker thread and, run the whole of its code in the UI thread. :)

Sergey Alexandrovich Kryukov 11-May-15 10:21am

Thank you, Shmuel.
—SA