Will the following code work ?

Question

1.00/5 (2 votes)

See more:

struct data 
{
 char name[80];
 double age;
}
 const data MyStruct = {"a",1000};
 strcpy(MyStruct.name,"p");
 printf(MyStruct.name);

Please explain if this code has any problem. Or is it okay? Than why?

Posted 30-Mar-11 11:10am

UL UL ALBAB

Updated 30-Mar-11 11:35am

HimanshuJoshi

v3

Add a Solution

Comments

HimanshuJoshi 30-Mar-11 17:36pm

Edited to remove bold tag in text. Have you tried running it? Have you faced any problem?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Albert Holguin · Accepted Answer · 2011-03-30T12:06:00

Solution 2

besides the problems that SA pointed out, from looking at what that code is doing, its conceptually wrong... you've declared a constant structure then you're trying to copy a different string onto your character buffer after the fact.

Posted 30-Mar-11 12:06pm

Albert Holguin

Comments

Sergey Alexandrovich Kryukov 31-Mar-11 3:05am

Of course. My 5.
Please see a comment by Niklas to my Answer -- an interview re-post. Very unpleasant. I feel bad about it: wasn't worth answering...
--SA

Sergey Alexandrovich Kryukov · Accepted Answer · 2011-03-30T11:37:00

Well, it's not a perfect style because of 4 immediate constants hard-coded. It also consumes 80 bytes of memory without purpose, but this is because of the nature of static array. To me, null terminated string was one of the worst ideas in the history of technology, but this is not your fault :-). You could use std::string instead.

The function strcpy is unsafe, better use strcpy_s.
After the structure declaration you need ';'.
The code will not compile because of const before data.

Now, may I understand why are you asking such Question if your code does not even compile, and you even did not report this problem? Did you even try to compile it?
It looks like you're trying to put too much of your job on others, but it does not help you much.

I must say, your method of learning is not effective. I advice you stop asking such Questions here at CodeProject and learn the basics using some good manual and exercises, using the approach I outlined here:
I have a problem with my program. Please help![^].

—SA