Dear all, I am using visual studio 2010, I have a problem with insert data to database of SQL server 2014. Here is my code:

Question

0.00/5 (No votes)

See more:

String ConnectionString = "Data Source=Lenovo-PC\\SQLSERVER;Integrated Security=True;" +
"Initial Catalog=Google";
SqlConnection Conn = new SqlConnection(ConnectionString);
String Query = " INSERT INTO EMPLOYEE 1(Name,Father,CNIC,Mobile,City,State) VALUES (" +
" '" + textName.Text + "', " +
" '" + textFather.Text + "', " +
" '" + textCNIC.Text + "', " +
" '" + textMobile.Text + "', " +
" '" + textCity.Text + "', " +
" " + textState.Text + ", " + ")";
SqlDataAdapter da = new SqlDataAdapter(Query, Conn);
DataTable dt = new DataTable();
da.Fill(dt);

the error is:

Incorrect syntax near '1'.

Posted 27-Apr-15 0:46am

Member 11645178

Updated 27-Apr-15 1:37am

v2

Add a Solution

Comments

scottgp 27-Apr-15 7:38am

in this part of the statement, 'INSERT INTO EMPLOYEE 1(Name' is the 1 supposed to be there, and if so , should there be a space between 'EMPLOYEE' and '1'?

Naveen Kumar Tiwari 27-Apr-15 7:52am

This is Very Bad style of code writing..Error finding is very hard of such type of pattern...I suggest you dear improve your code...

2 solutions

Solution 1

It means your first line was having a incorrect connection string.

However for best practices declare connection string in Web.config or app.config like below.

XML

<?xml version="1.0" encoding="utf-8" ?>
    <configuration>
        <connectionStrings>
            <add name="CONSTRING" connectionString="Data Source=Lenovo-PC\\SQLSERVER;Initial Catalog=Google;Integrated Security=True"/>
        </connectionStrings>
    </configuration>

then declare a variable and add that connection string

C#

public string conn = ConfigurationManager.ConnectionStrings["CONSTRING"].ConnectionString;
   }

then write your code as below

C#

SqlConnection Conn = new SqlConnection(conn);
String Query = " INSERT INTO EMPLOYEE 1(Name,Father,CNIC,Mobile,City,State) VALUES (" +
" '" + textName.Text + "', " +
" '" + textFather.Text + "', " +
" '" + textCNIC.Text + "', " +
" '" + textMobile.Text + "', " +
" '" + textCity.Text + "', " +
" " + textState.Text + ", " + ")";
SqlDataAdapter da = new SqlDataAdapter(Query, Conn);
DataTable dt = new DataTable();
da.Fill(dt);

Posted 27-Apr-15 1:01am

debasish mishra

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Andy Lanng · Accepted Answer · 2015-04-27T01:24:00

NOOOO!!!

You are wide open to sql insertions. That's a very, very bad thing!

An the error is in

" INSERT INTO EMPLOYEE 1

wither the 1 shouldn't be there, or if the table is called EMPLOYEE 1 then add square braces to sql knows it's a single term:

using (SqlConnection conn = new SqlConnection())
{ // added using so the dispose of conn is called

    String Query =
        " INSERT INTO [EMPLOYEE 1](Name,Father,CNIC,Mobile,City,State) VALUES (@name,@father,@cnic,@mobile,@city,@state);";

    using (SqlCommand command = conn.CreateCommand())
    {

        command.CommandType = CommandType.Text;
        command.CommandText = Query;
        command.Parameters.AddRange(new[]
        {
            new SqlParameter("@name", SqlDbType.NVarChar) {Value = textName.Text},
            new SqlParameter("@father", SqlDbType.NVarChar) {Value = textFather.Text},
            new SqlParameter("@cnic", SqlDbType.NVarChar) {Value = textCNIC.Text},
            new SqlParameter("@mobile", SqlDbType.NVarChar) {Value = textMobile.Text},
            new SqlParameter("@city", SqlDbType.NVarChar) {Value = textCity.Text},
            new SqlParameter("@state", SqlDbType.NVarChar) {Value = textState.Text},
        });

        conn.Open();

        command.ExecuteNonQuery();

        conn.Close();
    }

}

You don't need the data adapter. Inserts do not return values. The return a single int telling you how many rows were affected.

Look into SQL Injection. Using parameters should protect you to a good degree. Any parameters are encoded so as to disallow injection.

On the subject of SQL Injection:
http://en.wikipedia.org/wiki/SQL_injection[^]

My father is '; drop table * ;'. His mates called him 'droppy' for short.

Please use this solution as an addition to the first. Debasish Mishra is correct about the connection string best practice.

EDIT: forgot to open the connection #^_^#