How to optikmize algorith?

Question

1.00/5 (1 vote)

See more:

Hello.

I am making a algorithm that checks if a a device is started or not.
The idea is that I make timer and initialize it, checking every 1,5 sec.

C#

private Timer timerChecker = new Timer();

timer.Tick += this.OnCheck();

private bool isStarted = true;
private bool isStopped = true;

private void OnCheck()
{
    var process = Process.GetProcessByName("processname");
    

if(process.Lenght > 0)
{
    if(!isStarted)
    {
        device.Start();//Start the device, sometimes it starts two times, which is not good
        isStarted = true;
        isStopped= false;
    }
}
else
{
    if(!isStopped) 
    {
        device.Stop(); // Stop the device
        
        isStarted = true;
        isStopped= false;
    }
}

}

Can you offer me better way to check this thing.

Posted 18-Mar-15 10:48am

Zhivko Kabaivanov

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Joan Magnet · Answer 1 · 2015-03-18T12:55:00

First, every time it executes OnCheck you should disable the timer, to avoid a second call while starting/stooping, and enable it before exit the method.

private void OnCheck()
{
    timerChecker.Enabled = false;

    // Do things...


    timerChecker.Enabled = true;
}

It's not clear to me when isStarted/isStoped change it value, I understand it as MustStart & MustStop. If not, simply start/stop the process alternatively.

You could use one variable only for this function.