How add a hyphen “-” to separate value in textbox when user click another button in C#?

Question

0.00/5 (No votes)

See more:

I have a textbox and at least 5 buttons, I want user to click any of 5 buttons then insert its value to the textbox.

If there is no value exists in the textbox then insert the clicked button value to the textbox, but if there are any existing value in textbox then add the "-" to separate the second input value.

Example: The first value should be 12 after click to insert the second button then textbox format should be 12-13.

I do something like this but still no luck:

C#

private void txtFixedTypeTwo_TextChanged(object sender, EventArgs e)
        {
            string sVal = txtFixedTypeTwo.Text;
            if (!string.IsNullOrEmpty(sVal))
            {
                txtGameTwoRandom.Enabled = true;
                txtCountGameTwo.Enabled = true;
                if (txtFixedTypeTwo.Text.Length > 11)
                {
                    MessageBox.Show("Only allow 4 animals", "Information", MessageBoxButtons.OK, MessageBoxIcon.Information);
                    txtFixedTypeTwo.Text = txtFixedTypeTwo.Text.Substring(0, txtFixedTypeTwo.Text.Length - 3);
                }
                else
                {
                    sVal = sVal.Replace("-", "");
                    string newst = Regex.Replace(sVal, ".{2}", "$0-");
                    var nos = newst.Split('-');
                    List<string> tmp = new List<string>();
                    foreach (var item in nos)
                    {
                        if (!tmp.Contains(item))
                        {
                            tmp.Add(item);
                        }
                        else
                        {
                            MessageBox.Show("Duplicate entry detected", "Information", MessageBoxButtons.OK, MessageBoxIcon.Information);
                            txtFixedTypeTwo.Text = txtFixedTypeTwo.Text.Substring(0, txtFixedTypeTwo.Text.Length - 3);
                        }
                    }
                    txtFixedTypeTwo.SelectionStart = txtFixedTypeTwo.Text.Length;
                    txtFixedTypeTwo.Focus();
                }
            }
        }

EDIT:
I tried another solution from Stackoverflow it works great;

C#

public void Button1_Click(object sender, EventArgs e)
{
    if(textBox.Text.Length > 0)
         textBox.Text += "-";

    Button butt = (Button)sender;

    textBox.Text += butt.Text;
}

Posted 26-Jan-15 20:02pm

CeebLaj Thoj

Updated 27-Jan-15 22:06pm

v5

Add a Solution

Comments

BillWoodruff 27-Jan-15 3:15am

What exactly does each button insert ?

CeebLaj Thoj 27-Jan-15 3:28am

Example: btn1 = "01", btn2 = "02", btn3 = "03", btn4 = "04", btn5 = "05"

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

TheRealSteveJudge · Answer 1 · 2015-01-27T20:55:00

This could be what you wanted to have:

MainWindow.xaml:

XML

<Window x:Class="WpfApplication10.MainWindow"
        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        Title="MainWindow" Height="350" Width="525">
    
    <Window.Resources>
        <Style TargetType="Button">
            <Setter Property="Width" Value="75"></Setter>
            <Setter Property="Height" Value="25"></Setter>
            <Setter Property="Margin" Value="5"></Setter>
        </Style>    
    </Window.Resources>
    
    <Grid>
        <StackPanel x:Name="stackPanelButtons" Button.Click="CommonClickHandler">
            <Button Content="01"/>
            <Button Content="02"/>
            <Button Content="03"/>
            <Button Content="04"/>
            <Button Content="05"/>
            <TextBlock x:Name="textBlock"></TextBlock>
        </StackPanel>
    </Grid>
</Window>

MainWindow.xaml.cs:

C#

using System.Collections.Generic;
using System.Windows;
using System.Windows.Controls;

namespace WpfApplication10
{
    public partial class MainWindow : Window
    {
        List<string> values;

        public MainWindow()
        {
            values = new List<string>();

            InitializeComponent();
        }

        private void CommonClickHandler(object sender, RoutedEventArgs e)
        {
            string value = ((Button)e.Source).Content.ToString();

            if(values.Contains(value))
            {
                MessageBox.Show(this, string.Format("'{0}' already exists!", value), "Info", MessageBoxButton.OK, MessageBoxImage.Information);
            }
            else
            {
                values.Add(value);
            }

            textBlock.Text = string.Join("-", values);

            e.Handled = true;
        }
    }
}

Sinisa Hajnal · Answer 2 · 2015-01-26T20:21:00

Solution 1

When you click a button, there is button click event in which you can add the hyphen

Something like this:

C#

protected void button_click(object sender, EventArgs e) {
    Button btn = CType(sender, Button)
    if (btn.Text != string.empty) {
        txtFixedTypeTwo.text += "-" + btn.Text;
    else
        txtFixedTypeTwo.Text = btn.Text;
    }
}

You should probably add same event to all buttons and add the check before the cast to see that the sender really is a button.

If this helps please take time to accept the solution. Thank you.

Posted 26-Jan-15 20:21pm

Sinisa Hajnal

Updated 26-Jan-15 20:22pm

v2

Comments

CeebLaj Thoj 27-Jan-15 2:30am

My problem is each button apply to different textbox format, so I can't do that with button click event.

BillWoodruff 27-Jan-15 3:14am

You need to explain what each button inserts.

Sinisa Hajnal 27-Jan-15 3:16am

Of course you can, you just cannot have it all in a single button event. Assign in each button event whatever format is needed.

CeebLaj Thoj 27-Jan-15 21:38pm

I have problem CType error, not exist in the current....

CeebLaj Thoj 27-Jan-15 3:32am

The reason is because in some textbox condition I don't need to insert the "-" to separate the enter value, because they need to replace the actual textbox with the button value instead of put the "-" to separate the entered value.

Sinisa Hajnal 27-Jan-15 9:30am

And I repeat: as long as the BUTTON controls (triggers) textbox change, you make the change in BUTTON CLICK event. Any conditions, current value or whatever of textbox can be checked at that point and changed accordingly.

TheRealSteveJudge 27-Jan-15 4:14am

Still not clear!
Let me use my crystal ball...
You have 5 buttons with different contents
and one text box
and you want to concatenate the buttons' contents when pressed,
each button's content separated by a dash?
e.g. you press button with content 12 and button with content 14
the text box shall show 12-14?

CeebLaj Thoj 27-Jan-15 20:44pm

Yeah, that's what I want but I really can't get it done

Sinisa Hajnal 28-Jan-15 2:14am

My code in the solution should do that. You mentioned conditions, but this short version will be accomplished by the solution.

CeebLaj Thoj 28-Jan-15 2:18am

I tried you code in the Solution but I got an error of CType, is that I missed something else?

Sinisa Hajnal 28-Jan-15 2:31am

I was writing from the memory. Just find the equivalent cast (this is probably VB specific). Try with (Button)sender instead of CType(sender, Button). Maybe "sender As Button". Play with it. The idea is to get the button clicked from the sender object. If you put code in separate events specific to a button you can reference the button directly without using sender object.

TheRealSteveJudge 28-Jan-15 2:55am

Please have a look at solution 2.

Atish K. Singh · Answer 3 · 2015-01-27T21:26:00

Solution 3

write a method as

C#

private void AppendText(string text)
{
  if(!string.IsNullOrEmpty())
  {
     txtFixedTypeTwo.Text += "-" +  text;
  }
  else
  {
     txtFixedTypeTwo.Text = text;
  }
}

Call this method on click of each button and pass the value of button.Text. e.g

C#

protected void button_click(object sender, EventArgs e) 
{
    Button btn = CType(sender, Button)
    AppendText(btn.Text);
}

Posted 27-Jan-15 21:26pm

Atish K. Singh

Comments

Sinisa Hajnal 28-Jan-15 3:35am

This would fail for CType just like mine did (you just reorganized it).

Atish K. Singh 28-Jan-15 4:36am

Don't use CType. Just pass the button text on the click event of button like:

protected void button1_click(object sender, EventArgs e)
{
AppendText(button1.Text);
}

Sinisa Hajnal 28-Jan-15 5:54am

You can't if the same handler handles all five buttons...

Atish K. Singh 28-Jan-15 6:15am

There is no need to have same handler for each button. Instead create separate handler for each button and call the method and pass the button's text in it.

How add a hyphen “-” to separate value in textbox when user click another button in C#?

3 solutions

Solution 2

Solution 1

Solution 3

Add your solution here

Preview 0

Existing Members

...or Join us