conversion failedvarcher to int windows form

Question

2.00/5 (1 vote)

See more:

fetching data from sql table int passno

getting error conversion failed varchar to int

thx in advance

 SqlDataAdapter da = new SqlDataAdapter("select * from VisitorPass where PassNo = '" + (vfind.SelectedValue.ToString()) + "'", objConn1);
<pre>            DataSet ds = new DataSet();
            da.Fill(ds, "VisitorPass");
            if (ds.Tables["VisitorPass"].Rows.Count > 0)
            {
                MainCombo.SelectedValue = ds.Tables["VisitorPass"].Rows[0]["PassType"].ToString();
                txtvpassno.Text = ds.Tables["VisitorPass"].Rows[0]["PassNo"].ToString();
                VdateTimePicker1.Value = Convert.ToDateTime(ds.Tables["VisitorPass"].Rows[0]["Date"].ToString());
                Dttimein.Value = Convert.ToDateTime(ds.Tables["VisitorPass"].Rows[0]["Timein"].ToString());
                Dttimeout.Value = Convert.ToDateTime(ds.Tables["VisitorPass"].Rows[0]["Timeout"].ToString());
                txtvpassno.Text = ds.Tables["VisitorPass"].Rows[0]["VisitorsName"].ToString();
                txtvpassno.Text = ds.Tables["VisitorPass"].Rows[0]["Purpose"].ToString();
                txtvpassno.Text = ds.Tables["VisitorPass"].Rows[0]["ToSee"].ToString();
                vauthcombo.SelectedValue = ds.Tables["VisitorPass"].Rows[0]["AuthorisedSign"].ToString();

Posted 27-Jan-15 22:39pm

Master Vinu

Updated 27-Jan-15 23:28pm

v2

Add a Solution

Comments

Umer Akram 28-Jan-15 4:45am

have to tried to execute the generated query on the database to see if any issue? it this query is straight forward, you need to check what value you are passing to PassNo column.

Master Vinu 28-Jan-15 4:49am

int value .query is working properly

Atish K. Singh 28-Jan-15 5:01am

What is the datatype of PassNo column in the database?

Master Vinu 28-Jan-15 5:27am

int

Richard Deeming 19-Feb-15 7:34am

Your code is vulnerable to SQL Injection[^].

NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Suvendu Shekhar Giri · Answer 1 · 2015-01-27T22:50:00

Solution 1

Try this

SQL

SqlDataAdapter da = new SqlDataAdapter("select * from VisitorPass where PassNo = " + (vfind.SelectedValue.ToString()), objConn1);

Note: It looks, "PassNo" column is of type INT. Make sure that "vfind.SelectedValue.ToString()" contains number only and not alpha-numeric data.

Hope it helps :)

Posted 27-Jan-15 22:50pm

Suvendu Shekhar Giri

Comments

Master Vinu 28-Jan-15 5:00am

now its give multipart identifier error

Suvendu Shekhar Giri 28-Jan-15 5:28am

can you please paste the complete error here?

Master Vinu 28-Jan-15 5:31am

SqlDataAdapter da = new SqlDataAdapter("select * from VisitorPass where PassNo = " + (vfind.SelectedValue.ToString()), objConn1);
DataSet ds = new DataSet();
da.Fill(ds, "VisitorPass");
if (ds.Tables["VisitorPass"].Rows.Count > 0)
{
MainCombo.SelectedValue = ds.Tables["VisitorPass"].Rows[0]["PassType"].ToString();
txtvpassno.Text = ds.Tables["VisitorPass"].Rows[0]["PassNo"].ToString();
VdateTimePicker1.Value = Convert.ToDateTime(ds.Tables["VisitorPass"].Rows[0]["Date"].ToString());
Dttimein.Value = Convert.ToDateTime(ds.Tables["VisitorPass"].Rows[0]["Timein"].ToString());
Dttimeout.Value = Convert.ToDateTime(ds.Tables["VisitorPass"].Rows[0]["Timeout"].ToString());
txtvpassno.Text = ds.Tables["VisitorPass"].Rows[0]["VisitorsName"].ToString();
txtvpassno.Text = ds.Tables["VisitorPass"].Rows[0]["Purpose"].ToString();
txtvpassno.Text = ds.Tables["VisitorPass"].Rows[0]["ToSee"].ToString();
vauthcombo.SelectedValue = ds.Tables["VisitorPass"].Rows[0]["AuthorisedSign"].ToString();

Suvendu Shekhar Giri 28-Jan-15 5:35am

Actually, I was asking about the multipart identifier error, you are getting. Can you please paste that error here.

Master Vinu 28-Jan-15 5:45am

multipart identifier (system.data.datarowview) could not be bound.

Richard Deeming 19-Feb-15 7:34am

You have copied the SQL Injection[^] vulnerability from the question.

NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.