the function gets called only once

Question

1.00/5 (1 vote)

See more:

i have called a simple function on html-image click to change the pic. But when i re-click on the same image , it does not changes back to the same image. please help in solving :-

JavaScript

function ChangePic() {
            if (document.getElementById("bulb").src = "IMAGES/pic_bulboff.gif")
             document.getElementById("bulb").src = "IMAGES/pic_bulbon.gif";
            else 
           document.getElementById("bulb").src = "IMAGES/pic_bulboff.gif";
            }

HTML

<img id="bulb" alt="no pic is available" />

Posted 8-Jan-15 13:25pm

shikhar gilhotra

Add a Solution

Comments

syed shanu 8-Jan-15 22:10pm

Check with Alert message like this
function ChangePic() {
if (document.getElementById("bulb").src == "IMAGES/pic_bulboff.gif")
{
alert("yes");
document.getElementById("bulb").src = "IMAGES/pic_bulbon.gif";
}
else
{
alert("No");
document.getElementById("bulb").src = "IMAGES/pic_bulboff.gif";
}
}

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2015-01-08T13:32:00

Solution 1

It is not related to calling a function once or twice. In all of your lines, you do assignments, you never check up condition which would return false.
Javascript conditional operator is '==', not '='. To fix your code, consider changing the line of your "if" operator: replace '=' by '=='.

—SA

Posted 8-Jan-15 13:32pm

Sergey Alexandrovich Kryukov

Updated 8-Jan-15 13:33pm

v2

Comments

shikhar gilhotra 8-Jan-15 20:03pm

no, its still not workable .:-(

Sergey Alexandrovich Kryukov 8-Jan-15 21:06pm

Just do it carefully.
—SA

shikhar gilhotra · Answer 2 · 2015-01-08T14:25:00

Solution 2

C#

function ChangePic()
       {
           if (document.getElementById("bulb").src== "http://localhost:1620/IMAGES/pic_bulboff.gif")
           document.getElementById("bulb").src = "IMAGES/pic_bulbon.gif";
             else
           document.getElementById("bulb").src = "IMAGES/pic_bulboff.gif";
         }

Posted 8-Jan-15 14:25pm

shikhar gilhotra

Comments

Sergey Alexandrovich Kryukov 8-Jan-15 21:06pm

Are you sure it's your resolution of the problem? :-)
—SA