SP for Insert Query using "inner Join"

Question

0.00/5 (No votes)

See more:

SQL-Server-2005

I written in line query in my code but I was trying to convert in to store procedure I just stuck some where,please advise me to correct the errors.Thanks in Advance

Even I am planning to use IF exist then use update rather than select

Here is my in line code query

SQL

INSERT INTO Phone (employeeno, PhoneNumber,CreatedBy,UpdatedBy)Select " + "employeeno" + "," + "phoneNo" + "," + "'" + "dbo" + "'" + "," + "'" + "dbo" + "'" + "from User where employeeno=" + item.EmployeeNumber;

ALTER PROC [dbo].[InsertPhone] 
                    @EmployeeNo int,
                    @PhoneNumber char(24)



DECLARE  @CONTEXT_INFO varchar(100)
					select   @CONTEXT_INFO = COALESCE(CONVERT(VARCHAR(128), CONTEXT_INFO()), CURRENT_USER)
 INSERT INTO [Phone]
							(employeeno
							,PhoneNumber
							,CreatedBy
							,UpdatedBy)
select  Ad.employeeno,Ad.PhoneNo,@CONTEXT_INFO,@CONTEXT_INFO from User AD where Ad.employeeno=@EmployeeNo

Posted 21-Mar-11 22:22pm

shan1395

Updated 22-Mar-11 0:18am

v3

Add a Solution

Comments

m@dhu 22-Mar-11 4:32am

Use pre tags for the code for better readability.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sandeep Mewara · Accepted Answer · 2011-03-21T23:43:00

Solution 1

Try something like:

SQL

CREATE PROC [dbo].[InsertPhone]
      @EmployeeNo int
AS
BEGIN
      DECLARE @CONTEXT_INFO varchar(100)
      DECLARE @PhoneNo varchar(15)

      SELECT @CONTEXT_INFO = COALESCE(CONVERT(VARCHAR(128), CONTEXT_INFO()), CURRENT_USER)
      
      SELECT
             @PhoneNo = Ad.PhoneNo
      FROM
             User Ad
      WHERE Ad.Employeeno= @EmployeeNo


      INSERT INTO [Phone]
             (employeeno, PhoneNumber, CreatedBy, UpdatedBy)
      VALUES
             (@EmployeeNo, @PhoneNo, @CONTEXT_INFO, @CONTEXT_INFO) 
END

Now, if you need some modifications on exists or not (that would need a if and then UPDATE/INSERT staments), then make the changes accordingly.

Try!

Posted 21-Mar-11 23:43pm

Sandeep Mewara

Updated 22-Mar-11 0:48am

v3

Comments

shan1395 22-Mar-11 5:52am

hi Sandeep

Thanks for your comment do you seen my query,am trying to pull values from another table (ADUser) and insert in to Phone table.Your store proc to insert for getting values inline and insert.

Sandeep Mewara 22-Mar-11 6:49am

I did saw that. But your try showed Phoneno as a parameter too that made it look like not needed.

I have modified the SP and it was simple enough for you too to modify it. You should have tried instead of asking me if I read your question. I did said 'try something like...'

shan1395 22-Mar-11 7:00am

Awesome thank you so much Sandeep

Sandeep Mewara 29-Mar-11 13:37pm

Glad it worked. Your welcome.