Index was outside the bounds of the array.

Question

1.00/5 (1 vote)

See more:

Whats Wrong in the following code I get Index was outside the bounds of the array. this error in for loop

TxtModel.Text is multiline textbox

C#

public void concode()
   {           
   int i;
     {
       string[] sep = new string[] { "\r\n" };
       string[] aaa = TxtModel.Text.Split(sep,StringSplitOptions.RemoveEmptyEntries);              
 for (i = 0; i <= aaa[i].Length-1; i++)// error at this stage Index was outside the bounds of the array.
      {
        string model = aaa[i].Substring(0, 5); // LICT 
        string length = aaa[i].Substring(5, 4);
        string style = aaa[i].Substring(9, 4);
        string mat = aaa[i].Substring(13, 2);
        string llength = aaa[i].Substring(15, 3);
        string instru = aaa[i].Substring(18, 1);
        if (model != null)
        {
         SqlCommand cmd = new SqlCommand("select * from abc where  Codemap='" + model + "' ", con);
         SqlDataReader rd;
          try
          {
             con.Open();
             rd = cmd.ExecuteReader();
             if (rd.Read() == true)
               {
                 if (rd["Codemap"].ToString() == "ab")
                   {
                   string abc = rd["PName"].ToString();
                   int partid = rd.GetInt32(0);
                  gettMate(partid, abc, mat , length , style , llength , instru );
                  }

              if (rd["Codemap"].ToString() == "bc")
              {
                  string pqr = rd["PName"].ToString();
                  int partid = rd.GetInt32(0);
                 gettMate(partid, abc, mat , length , style , llength , instru );
                                    }
                                }
                            }


                  catch (Exception)
                   {
                      throw;
                   }
                  finally
                   {
                     con.Close();
                   }
                 }
               }                
            }
        }

Posted 4-Jan-15 17:23pm

Member 11270220

Updated 4-Jan-15 18:29pm

King Fisher

v4

Add a Solution

Comments

King Fisher 4-Jan-15 23:33pm

Check your Array Length.

Member 11270220 4-Jan-15 23:36pm

I check but same error

King Fisher 5-Jan-15 0:19am

Can you post the Sample value's of your Array .I mean what do you have on TxtModel.Text while running your Application .

Suvendu Shekhar Giri 4-Jan-15 23:48pm

Make sure that you have correctly typed Codemap & PName as in the database.

Member 11270220 4-Jan-15 23:49pm

ya I check all but same error

deepakdynamite 4-Jan-15 23:51pm

Probably error is coming in following code:

string model = aaa[i].Substring(0, 5); // LICT
string length = aaa[i].Substring(5, 4);
string style = aaa[i].Substring(9, 4);
string mat = aaa[i].Substring(13, 2);
string llength = aaa[i].Substring(15, 3);
string instru = aaa[i].Substring(18, 1);

For eg lets take one line of code : string instru = aaa[i].Substring(18, 1);
It looks like you are assuming that there would be some data on starting from 18th index but what aaa[i]'s length is less than 18

Member 11270220 4-Jan-15 23:55pm

thanks for your help frnds I solve this error. thanks

George Jonsson 5-Jan-15 0:18am

Set the question as solved

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2015-01-04T18:37:00

In this loop, you are doing completely wrong thing. Probably, you meant to do something like

C++

for (i = 0; i <= aaa.Length-1; i++) //...

Besides, in all those expressions Substring(5, 4) or Substring(9, 4) nothing guarantees that the string you are using has any characters at index 5 or 9, or has enough characters after this index to get a slice. You need to check it up before taking a substring.

The whole idea of using immediate constants like 9, 5, or 4 is really bad; it makes the code purely maintainable.

As to your bugs, these problems are very basic, so, instead of asking anyone to fix them, you should learn how to debug them yourself. Such problems are the most easy to solve. Use the debugger, learn how to use it well, and you will be able to debug such problems in no time.

—SA