FileStream close VS FileStream in using statment

Question

5.00/5 (1 vote)

See more:

we were facing a problem that sometime the file was not written completely (all the data) and we were using code below

C#

using (FileStream fs = new FileStream(tempFileName, FileMode.Create))
                {
                    BinaryWriter writer = new BinaryWriter(fs);
                    writer.Flush();
                    writer.Write(data);
                }

only thing i did to solve the situation is put

C#

fs.Close();

inside using statement and it's started working as expected. now as per MSDN says diposed does call close internally.

any idea why this strange behavior ?

Posted 8-Dec-14 2:05am

CS2011

Add a Solution

Comments

Rob Philpott 8-Dec-14 9:10am

Interesting. I can see why it may not work now, (data is in the BinaryWriter buffer and may not be written to stream until the flush), but not why explicitly calling Close() on the filestream would fix it.

I'd be interested to find out!

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Praveen Kumar Upadhyay · Answer 1 · 2014-12-08T02:33:00

Solution 1

Change your code to below code.

C#

using (FileStream fs = new FileStream(tempFileName, FileMode.Create))
{
      BinaryWriter writer = new BinaryWriter(fs);
      writer.Write(data);
      writer.Flush();
}

Do a Flush() after write.

Posted 8-Dec-14 2:33am

Praveen Kumar Upadhyay

Comments

Praveen Kumar Upadhyay 8-Dec-14 8:35am

You can also refer the below link.

http://stackoverflow.com/questions/12735897/streamwriter-is-cutting-off-my-last-couple-of-lines-sometimes-in-the-middle-of-a

CS2011 8-Dec-14 8:45am

well i know flush will do the job so will close(). my question is while under using statement disposed get called and inside dispose close() gets called. so why data is not written properly when i use it without calling close manually

Praveen Kumar Upadhyay 8-Dec-14 9:00am

If you are using Flush() after write, you don't need to use Close(). There is some problem of using 'using' statement. Check out below link.

http://msdn.microsoft.com/en-us/library/aa355056(v=vs.110).aspx

CS2011 8-Dec-14 13:10pm

buddy see the question. as per MS calling dispose calls close internally which calles flush() but it doesn't happen sometime but when i call close in my code it works as expected. my question is why it happens. Just do not post anything as answer for points