I am trying to combine two table it's giving error..need help

Question

0.00/5 (No votes)

See more:

SQL-Server-2008R2

VB

cmd.CommandText = "select MAINFILE.facno,max(fdate) as MAINTRAN.fdate ,max(fbalance) as MAINTRAN.fbalance from MAINTRAN INNER JOIN MAINFILE ON MAINFILE.facno=MAINTRAN.facno" & _
                                          "where MAINTRAN.fbankcode='" & "010" & "' and MAINTRAN.facno=MAINFILE.facno" & _
                                          "and MAINTRAN.fdate<='" & Format(prdate, "MM/dd/yyyy") & "' " & _
                                          "and MAINTRAN.fbranchcode='" & "01" & "' " & _
                                          " group by MAINFILE.facno"

With cmd

VB

dr = .ExecuteReader//error:Incorrect syntax near '.'.(sqlexception)

Posted 25-Nov-14 3:09am

lakshjoshi

Updated 25-Nov-14 3:19am

Shweta N Mishra

v4

Add a Solution

Comments

den2k88 25-Nov-14 9:12am

What error?
What is the expected result?

PS: next time don't write the title all in uppercase, it means shouting and it is rude.

lakshjoshi 25-Nov-14 9:17am

i want to display facno from mainfile and fdate&fbalance from maintran table thats it...

lakshjoshi 25-Nov-14 9:15am

ok thank you ,my mistatke will never repeated again.here is my error
error:Incorrect syntax near '.'.(sqlexception)
i checked carefully but where this error coming from...?

Tomas Takac 25-Nov-14 9:18am

Can you give us the value cmd.CommandText after the concatenation?

lakshjoshi 25-Nov-14 9:22am

i am just inputing date like 25/08/2014 means it should produce values on particulars date or lees than that date...

lakshjoshi 25-Nov-14 9:26am

output facno fbalance fdate
12 2500 25/04/2014

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Answer 1 · 2014-11-25T03:26:00

First, do NOT use string concatenation to build SQL queries. You open yourself up to SQL Injection attacks by doing that.

Second, you're storing dates as strings. That's a huge problem because it's not culturally sensitive and sorting of dates by string value does not match the sorting of dates by actual date value.

Lastly, the casing you're using is hurting my eyes, making it difficult to read. SQL keywords are normally capitalized while column names and other identifiers are not.

Also, I don't believe you can create column aliases with a dotted notation. I'm taking about the AS clauses you have in that statement. Table aliases should be short so they don't drown out your column names thereby making your SQL easier to read.

select MAINFILE.facno,max(fdate) as MAINTRAN.fdate

should be

SELECT mf.facno, MAX(mf.fdate) AS fdate

Try your query in an SQL query tool before trying to do it in your code. You'll find it's quicker and easier to debug in the tool than it is in your code.

Tomas Takac · Answer 2 · 2014-11-25T03:32:00

I would say your aliases are wrong. There is no reason to include the table name there:

SQL

select MAINFILE.facno, max(fdate) as MAINTRAN.fdate, ...

What you want is plain name, the same as the original column:

SQL

select MAINFILE.facno, max(fdate) as fdate, ...

Or if you want the whole string you need to use brackets like this:

SQL

select MAINFILE.facno, max(fdate) as [MAINTRAN.fdate], ...

/\jmot · Answer 3 · 2014-11-25T06:31:00

try this..

C#

cmd.CommandText = "select MAINFILE.facno,max(MAINTRAN.fdate) as MAINTRANfdate ,max(MAINTRAN.fbalance) as MAINTRANfbalance from MAINTRAN INNER JOIN MAINFILE ON MAINFILE.facno=MAINTRAN.facno" & _
                                          "where MAINTRAN.fbankcode='" & "010" & "' and MAINTRAN.facno=MAINFILE.facno" & _
                                          "and MAINTRAN.fdate<='" & Format(prdate, "MM/dd/yyyy") & "' " & _
                                          "and MAINTRAN.fbranchcode='" & "01" & "' " & _
                                          " group by MAINFILE.facno"

I am trying to combine two table it's giving error..need help

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0