Pass varchar in to sp

Question

0.00/5 (No votes)

See more:

I need to create a stored procedure and pass in a parameter, here it is:

SQL

create procedure GetEmployeeRole @role varchar(20)
as 
select * from Employee where employeeRole in ('Tech', 'Manager')
GO

I want to use @role to replace ('Tech', 'Manager'), so the query will be

SQL

select * from Employee where employeeRole in (@role)

So I can pass in whatever role I want, I passed in

SQL

@role = 'Tech' + ',' + 'Manager'

, It didn't work, so what did I do wrong? Thanks.

Posted 18-Sep-14 6:54am

Member 1284721

Updated 18-Sep-14 7:02am

George Jonsson

v3

Add a Solution

Comments

PIEBALDconsult 18-Sep-14 13:05pm

If SQL Server, look into using a Table Valued Parameter.
http://www.codeproject.com/Tips/93248/SQL-Server-User-Defined-Table-Types-and-Table

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ChauhanAjay · Answer 1 · 2014-09-18T07:23:00

Solution 1

Try this
Approach 1:

SQL

create procedure GetEmployeeRole @role varchar(20)
as
declare @sqlQuery nvarchar(max) 
set @sqlQuery = 'select * from Employee where employeeRole in ('''+replace(@role,',',''',''')+''')'
exec sp_executesql @sqlQuery
GO

Approach 2:

Passing comma delimited parameter to stored procedure[^]

Hope it helps.

Posted 18-Sep-14 7:23am

ChauhanAjay

Updated 18-Sep-14 7:26am

v2

Comments

Manas Bhardwaj 18-Sep-14 15:34pm

Yes, this would work +5!

But, please see my alternative!

Member 1284721 19-Sep-14 22:14pm

thank you, this is very helpful

ChauhanAjay 21-Sep-14 19:21pm

request you kindly accept the answer as solved.

Manas Bhardwaj · Answer 2 · 2014-09-18T09:33:00

I would do it bit differently.

First, create a function to split the input variable:

CREATE FUNCTION split(
    @delimited NVARCHAR(MAX),
    @delimiter NVARCHAR(100)
) 
RETURNS @t TABLE (id INT IDENTITY(1,1), val NVARCHAR(MAX))
AS
BEGIN
    DECLARE @xml XML
    SET @xml = N'<t>' + REPLACE(@delimited,@delimiter,'</t><t>') + '</t>'
    INSERT INTO @t(val)
    SELECT  r.value('.','varchar(MAX)') as item
    FROM  @xml.nodes('/t') as records(r)
    RETURN
END

Next, the query would become something like this:

SQL

SELECT * INTO #SplitResults FROM dbo.split(@role, ',')

SELECT
    *
FROM
    Employee INNER JOIN #SplitResults ON
        Employee.employeeRole = #SplitResults.Val


DROP TABLE #SplitResults

And you can pass the @role as:

@role = 'Tech,Manager'

Malidu · Answer 3 · 2014-09-21T07:47:00

Solution 3

SQL

DECLARE @role VARCHAR(MAX)
SET @role = '''Tech''' + ',' + '''Manager'''
SELECT @role

Posted 21-Sep-14 7:47am

Malidu