Error using the if condition

Question

1.00/5 (1 vote)

See more:

Error.

Please correct the coding below its around the 'if'

SQL

if (ddl_Moratorium.SelectedItem.Text ="NONE")
                txt_Morat_Mths.Enabled = false;
            else
                txt_Morat_Mths.Enabled = true;

Thanks

Posted 30-Aug-14 20:28pm

Member 10744248

Updated 30-Aug-14 20:36pm

v2

Add a Solution

7 solutions

Solution 1

Try this

C#

if (ddl_Moratorium.SelectedItem.Text == "NONE")
 txt_Morat_Mths.Enabled = false;
else
 txt_Morat_Mths.Enabled = true;

or

C#

if (ddl_Moratorium.SelectedItem.Text.Equals("NONE"))
 txt_Morat_Mths.Enabled = false;
else
 txt_Morat_Mths.Enabled = true;

Posted 30-Aug-14 20:48pm

ChauhanAjay

Updated 30-Aug-14 21:18pm

v2

Comments

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 31-Aug-14 3:10am

One closing bracket is missing in the 2nd piece of code. :)

Bernhard Hiller 3-Sep-14 2:57am

Fails with a NullReferenceException when ddl_Moratorium.SelectedItem is null.

Solution 3

Your requirement is so simple you can skip complete if else block and try following.

C#

txt_Morat_Mths.Enabled = ddl_Moratorium.SelectedItem.Text != "NONE";

Or

C#

txt_Morat_Mths.Enabled = !ddl_Moratorium.SelectedItem.Text.Equals("NONE", StringComparison.OrdinalIgnoreCase);

Posted 30-Aug-14 21:21pm

DineshMaind

Comments

Bernhard Hiller 3-Sep-14 2:58am

Fails with a NullReferenceException when ddl_Moratorium.SelectedItem is null.

DineshMaind 3-Sep-14 3:18am

ok, try this...
txt_Morat_Mths.Enabled = ddl_Moratorium.SelectedItem != null && ddl_Moratorium.SelectedItem.Text != "NONE";

Solution 2

C#

if(ddl_Moratorium.SelectedItem.Text.Equals("NONE",StringComparison.OrdinalIgnoreCase)
 txt_Morat_Mths.Enabled = false;
else
 txt_Morat_Mths.Enabled = true;

Posted 30-Aug-14 21:13pm

Sreejesh T J Nair

Comments

Bernhard Hiller 3-Sep-14 2:58am

Fails with a NullReferenceException when ddl_Moratorium.SelectedItem is null.

[no name] 3-Sep-14 12:08pm

Okay try ddl_Moratorium.SelectedValue.ToString() or ddl_Moratorium.SelectedItem.ToString() instead of ddl_Moratorium.SelectedItem.Text

Solution 6

For the better clarification use braces to define the blocks in C# Code

if (ddl_Moratorium.SelectedItem.Text == null)
{
   txt_Morat_Mths.Enabled = false;
}
else
{
   txt_Morat_Mths.Enabled = true;
}

Posted 2-Sep-14 22:20pm

MukeshSagar

Solution 4

use below code

SQL

if (ddl_Moratorium.SelectedItem.Text =="NONE")
                txt_Morat_Mths.Enabled = false;
            else
                txt_Morat_Mths.Enabled = true;

Posted 2-Sep-14 0:50am

ClimerChinna

Comments

Bernhard Hiller 3-Sep-14 2:58am

Fails with a NullReferenceException when ddl_Moratorium.SelectedItem is null.

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

George Jonsson · Accepted Answer · 2014-09-03T00:26:00

No one has actually pointed out that the problem is a syntax error in the if statement.
A single = means assignment, as in

C#

int i = 0;

In order to compare equality you need to use double ==

So you could correct your code by simply adding a second =

C#

if (ddl_Moratorium.SelectedItem.Text == "NONE")
    txt_Morat_Mths.Enabled = false;
else
    txt_Morat_Mths.Enabled = true;

As has been pointed out, this is not safe as you will get a NullReference error if ddl_Moratorium.SelectedItem is null.
Solution 5 gives you the most readable code.

You can also change your code to a one liner, but it is of course less readable. :)

C#

txt_Morat_Mths.Enabled = ((ddl_Moratorium.SelectedItem != null) && (ddl_Moratorium.SelectedItem != "NONE"));

Bernhard Hiller · Accepted Answer · 2014-09-02T21:01:00

Solution 5

SQL

if (ddl_Moratorium.SelectedItem == null)
    txt_Morat_Mths.Enabled = false;
else if (ddl_Moratorium.SelectedItem.Text == "NONE")
    txt_Morat_Mths.Enabled = false;
else
    txt_Morat_Mths.Enabled = true;

Posted 2-Sep-14 21:01pm

Bernhard Hiller

Comments

George Jonsson 3-Sep-14 6:28am

My vote of 5 for readability.

Bernhard Hiller 3-Sep-14 8:43am

Thanks.

Error using the if condition

7 solutions

Solution 7

Solution 5

Solution 1

Solution 3

Solution 2

Solution 6

Solution 4

Add your solution here

Preview 0

Error using the if condition

7 solutions

Solution 7

Solution 5

Solution 1

Solution 3

Solution 2

Solution 6

Solution 4

Add your solution here

Preview 0

Existing Members

...or Join us