Please solve this problem

Question

0.00/5 (No votes)

See more:

Hello Everyone,
I have written a code to insert the dynamically generated textbox value in database. I want to check all the textbox generated dynamically at a time. If no textbox empty then only it should insert textbox value into database. But in my code it is inserting the textbox value if one of the textbox has serial number value. How to resolve this kindly help.
My code is

C#

if (txtQuantity.Text != "")
       {
           try
           {
               for (int i = 0; i < quantity; i++)
               {

                   if (Request.Form["Textbox"+i.ToString()].Trim()== "")
                   {

                     Page.ClientScript.RegisterStartupScript(this.GetType(), "myalert", "alert('Enter Serial Number');",  true);

                     //Button2.Attributes.Add("onClick", "return false;");
                   }

                   else

                   {
                      // Label17.Visible = false;
                       con.Open();
                       string qryInsertProduct = "insert into Product_Details(GatePassNo,ClientID,Product_name,SerialNo,Status,CheckIN_Date ,Customer_Name, Customer_location, System_Date, [GatePass Status],State, City,S) values('" + GatePassNo + "','" + clientID + "','" + productName + "','" + Request.Form["Textbox" + i.ToString()] + "','" + status + "','" + TextBox1.Text + "','" + ddlCName.SelectedItem.Value + "','" + ddlCLocation.SelectedItem.Value + "','" + Label11.Text + "', 'Open','" + DropDownList1.SelectedItem.Value + "','" + DropDownList2.SelectedItem.Value + "','0')";
                       SqlCommand comInsertProduct = new SqlCommand(qryInsertProduct, con);
                       comInsertProduct.ExecuteNonQuery();
                       con.Close();
                       gdvProducts.Visible = true;
                       PopulateGridView();
                   }

               }
               }


           catch (Exception ex)
           {

           }

           finally
           {
               if (con.State == ConnectionState.Open)
               {
                   con.Close();

               }
           }
       }

Posted 22-Jul-14 22:52pm

Member 10578683

Updated 22-Jul-14 22:53pm

Sushil Mate

v2

Add a Solution

Comments

nilesh sawardekar 23-Jul-14 4:58am

please explain ,issue your facing

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2014-07-22T23:01:00

Solution 1

You have bigger problems than you think...

Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead. Particularly in a web based application, where I could delete your whole database from the other side of the world!

But...to the problem you have noticed: Simple: You only check one textbox. If it's not empty you insert. Which means that if you have four textboxes, you insert up to four times...

Check them first, in one loop, and build up a list of items to insert.
If they all pass, then do one single insert operation. If any fail, report the error and exit.

Posted 22-Jul-14 23:01pm

OriginalGriff

Comments

nilesh sawardekar 23-Jul-14 5:09am

also
"Textbox" + i.text.ToString()

OriginalGriff 23-Jul-14 5:16am

Sorry? That generates the string name of his "dynamic" textboxes:
Testbox0
Testbox1
Testbox2
Testbox3
...
Which Request.Form uses as an index to find the actual control content.

nilesh sawardekar 23-Jul-14 5:23am

He needed text in textbox so..
Textbox" + i.text

OriginalGriff 23-Jul-14 5:35am

Not so: Request.Form takes the name of the control as an index, and returns the text value of that control as a string. And a string doesn't have a Text property!
Neither does an integer as your code shows... :laugh:

Try it: you'll see what I mean.

Member 10578683 23-Jul-14 6:08am

Hello. how to do it. i tried to do but getting error. Kindly give some code

OriginalGriff 23-Jul-14 6:35am

"i tried to do but getting error"
Doesn't tell me much!
Remember that we can't see your screen, access your HDD, or read your mind.

Show us what you tried - that way we have some idea...:laugh:

Member 10578683 23-Jul-14 6:41am

if (txtQuantity.Text != "")
{
try
{
List<string> list = new List<string>();

for (int i = 0; i < quantity; i++)
{
list.Add(Request.Form["Textbox" + i.ToString()]);

if (Request.Form["Textbox"+i.ToString()]== "")
{

Page.ClientScript.RegisterStartupScript(this.GetType(), "myalert", "alert('Enter Serial Number');", true);

//Button2.Attributes.Add("onClick", "return false;");
}
}

for(int i =0;i<list.Count;i++)
{
if (list[i] != "")
// Label17.Visible = false;
con.Open();
string qryInsertProduct = "insert into Product_Details(GatePassNo,ClientID,Product_name,SerialNo,Status,CheckIN_Date ,Customer_Name, Customer_location, System_Date, [GatePass Status],State, City,S) values('" + GatePassNo + "','" + clientID + "','" + productName + "','" +list[i] + "','" + status + "','" + TextBox1.Text + "','" + ddlCName.SelectedItem.Value + "','" + ddlCLocation.SelectedItem.Value + "','" + Label11.Text + "', 'Open','" + DropDownList1.SelectedItem.Value + "','" + DropDownList2.SelectedItem.Value + "','0')";
SqlCommand comInsertProduct = new SqlCommand(qryInsertProduct, con);
comInsertProduct.ExecuteNonQuery();
con.Close();
gdvProducts.Visible = true;
PopulateGridView();
}

}

catch (Exception ex)
{

}

finally
{
if (con.State == ConnectionState.Open)
{
con.Close();

OriginalGriff 23-Jul-14 7:05am

So... what happens if you find an empty text box? You don;t do anything about it except to set an Alert message - you need to prevent your code from continuing as well. Perhaps a "return" after the RegisterStartupScript call would help?

Member 10578683 23-Jul-14 7:17am

Thanks. it is working correctly now. but problem is on postback the textboxes dissappears. when i call the function create textbox in the Add button then the text boxes appearing but the value of the textboxes are disappearing. How to do it

OriginalGriff 23-Jul-14 7:22am

That's more complicated, because of how websites work: each time your page goes back to the user, anything they type will be discarded unless you specifically save and re-load it.
So you probably want to look at storing it temporarily in the Session or in Cookies, and probably you need to check for PostBack in your Page_Load event handler.

Member 10578683 23-Jul-14 7:36am

Thanks I will try it.

Member 10578683 24-Jul-14 2:18am

Hi,
I wrote the client side code for the problem of postback. But it is working for the first dynamic textbox of all the placeholder. I am not able to know why it is not checking all the dynamically generated textboxes. My code isas follows
if (document.getElementById("txt") == "") {
alert("Please enter Serial Number");
document.getElementById("txt").focus();
return false;
}

if (document.getElementById("txt2").value == "") {
alert("Please enter Serial Number");
document.getElementById("txt2").focus();
return false;
}
if (document.getElementById("txt3").value == "") {
alert("Please enter Serial Number");
document.getElementById("txt3").focus();
return false;
}
Please help

OriginalGriff 24-Jul-14 4:43am

What do you mean by "I am not able to know why it is not checking all the dynamically generated textboxes" exactly? remember, I can't see your screen or access your HDD so I only get to work with what you tell me!

Member 10578683 24-Jul-14 10:01am

I have created dynamic textboexes. If that textboxes empty then it should give a alert msg as Enter serial Number. I have wrote the javascript code for that. But this code is showing the alert message when the first textbox of the placeholders are empty. It is not checking all the dynamic generated textboxes.
my code is as follows
public void fun1()
{
if (txtQuantity.Text != "")
{

for (int i = 0; i <= Convert.ToInt16(txtQuantity.Text) / 3; i++)
{

Label la = new Label();
la.Text = ddlProductName.SelectedItem.Value + (i + 1).ToString();
la.ID = "abc1" + i;

PlaceHolder1.Controls.Add(la);

//la = FindControl(String.Format(i)) as Label;

TextBox txtbox = new TextBox();
// txtbox.Text = "Textbox - " + i.ToString();

PlaceHolder1.Controls.Add(new LiteralControl("<input id='txt' name='Textbox" + i + "'type='Text' />"));

PlaceHolder1.Controls.Add(new LiteralControl("<br/>"));

}
for (int j = (Convert.ToInt16(txtQuantity.Text) / 3) + 1; j <= Convert.ToInt16(txtQuantity.Text) * 2 / 3; j++)
{

Label la1 = new Label();
la1.Text = ddlProductName.SelectedItem.Value + (j + 1).ToString();
la1.ID = "abc2" + j;

PlaceHolder2.Controls.Add(la1);

//la = FindControl(String.Format(i)) as Label;

TextBox txtbox1 = new TextBox();
// txtbox.Text = "Textbox - " + i.ToString();
PlaceHolder2.Controls.Add(new LiteralControl("<input id='txt2' name='Textbox" + j + "'type='Text' />"));
PlaceHolder2.Controls.Add(new LiteralControl("<br/>"));

}
for (int k = (Convert.ToInt16(txtQuantity.Text) * 2 / 3) + 1; k < Convert.ToInt16(txtQuantity.Text); k++)
{

Label la2 = new Label();
la2.Text = ddlProductName.SelectedItem.Value + (k + 1).ToString();
la2.ID = "abc3" + k;

PlaceHolder3.Controls.Add(la2);

//la = FindControl(String.Format(i)) as Label;

TextBox txtbox1 = new TextBox();
// txtbox.Text = "Textbox - " + i.ToString();

PlaceHolder3.Controls.Add(new LiteralControl("<input id='txt3' name='Textbox" + k + "'type='Text' />"));

PlaceHolder3.Controls.Add(new LiteralControl("<br/>"));

}
}

}

OriginalGriff 24-Jul-14 11:19am

Ah. I see.
Oh dear...
That really isn't a "nice" way to do things - for you or for your user.
Instead, consider using a GridView which creates a table for the user to enter his data instead of a set of labels and textboxes, and validate that.
This should help: http://devpinoy.org/blogs/keithrull/archive/2008/07/28/how-to-create-dynamic-input-rows-in-a-gridview-with-asp-net.aspx

Member 10578683 25-Jul-14 1:43am

Thanks. I will try it.

nilesh sawardekar 23-Jul-14 5:46am

thanks for increasing my GK..champ..

OriginalGriff 23-Jul-14 6:34am

You're welcome!