How Do I Resolve The Error Input String Not In Correct Format

Question

0.00/5 (No votes)

See more:

my given Stored procedure

C#

Create PROCEDURE GetSalary(@Id int,@Sal money output )
AS
BEGIN
     SELECT @Sal=EmpSalary from Emp 
	where EmpId =@Id
	
END

program.cs

C#

SqlConnection con = new SqlConnection(Helper.ConnectionString);
             SqlCommand cmd = new SqlCommand();
             cmd.Connection = con;
             cmd.CommandText = "GetSalary";
             cmd.CommandType = CommandType.StoredProcedure;
             SqlParameter parId, parSalary;
             parId = new SqlParameter("@Id", SqlDbType.Int);
             parSalary = new SqlParameter("@Sal", SqlDbType.Money);
             parSalary.Direction = ParameterDirection.Output;
             cmd.Parameters.Add(parId);
             cmd.Parameters.Add(parSalary);
             parId.Value = int.Parse(txtId.Text);
             con.Open();
             cmd.ExecuteNonQuery();
             con.Close();
             if (parSalary.Value == DBNull.Value)
                 txtSalary.Text = "";
             else
                 txtSalary.Text = parSalary.Value.ToString();
        }

Posted 17-Jun-14 23:37pm

Member 10892050

Updated 17-Jun-14 23:41pm

Thanks7872

v2

Add a Solution

Comments

Kornfeld Eliyahu Peter 18-Jun-14 5:44am

What value txtId.Text has?

ArunRajendra 18-Jun-14 6:00am

Verify proper values are entered in txtId. Validate the input before you pass it on to sql.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2014-06-18T00:38:00

Use int.TryParse instead of int.Parse to process user input, and check all fields as early as possible so you don't waste effort with things that aren't going to happen.

C#

int id;
public void myMethod()
    {
    if (!int.TryParse(txtId.Text, out id))
       {
       // report input error to user
       return;
       }
    SqlConnection con = new SqlConnection(Helper.ConnectionString);
    SqlCommand cmd = new SqlCommand();
    cmd.Connection = con;
    ...

Then use the checked-and-fine id value in your parameters

I would suggest though, that you use AddWithValue instead:

C#

cmd.CommandType = CommandType.StoredProcedure;
cmd.Parameters.AddWithValue("@Id", id);