My or clause is not working please help.

Question

0.00/5 (No votes)

See more:

Hi
This is my code. or condition is not satisfying

C#

public void populate()
{
  string qryDetails = "select GatePassNo, CheckIN_Date,Customer_Name,State,City,Customer_Location from Product_Details where  ( Customer_Name='"+ddlCName.SelectedItem.Value+"' or State='"+DropDownList2.SelectedItem.Value+"' or City='"+DropDownList3.SelectedItem.Value+"' or Status='"+DropDownList1.SelectedItem.Value+"' or GatePassNo='"+ddlCGatePassNo.SelectedItem.Value+"')";
  DataSet dsDetails = du.GetDataSet(qryDetails);

  GridView2.DataSource = dsDetails;
  GridView2.DataBind();
}

Posted 10-Jun-14 2:25am

Member 10578683

Updated 10-Jun-14 2:28am

Kornfeld Eliyahu Peter

v2

Add a Solution

Comments

Kornfeld Eliyahu Peter 10-Jun-14 8:30am

So? You may have no data for that specific condition!
Also you are on a total wrong way of building queries in ADO.NET - go and learn about parametrized queries...

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2014-06-10T02:37:00

We can't really help there: we don;t have access to your data, or the values you load into your drop downs. It could be as simple as the "State is in DropDownList1 and Status is in DropDownList2" or (as Kornfeld says) there may be no data in your DB which matches any of those conditions.

So put a breakpoint on the line:

C#

DataSet dsDetails = du.GetDataSet(qryDetails);

and look at the query. Then use SSMS to examine your database and see what values you have that match.
If there are any, then step over the GetDataSet call, and look at the tables it returns.
If the query is right, and the database has teh data, do it again, and this time step into teh call and follow through that method.

We can't do it for you.

goathik · Answer 2 · 2014-06-10T02:50:00

select GatePassNo, CheckIN_Date,Customer_Name,State,
City,Customer_Location from Product_Details
where ( Customer_Name='"+ddlCName.SelectedItem.Value+"'
or State='"+DropDownList2.SelectedItem.Value+"'
or City='"+DropDownList3.SelectedItem.Value+"'
or Status='"+DropDownList1.SelectedItem.Value+"'
or GatePassNo='"+ddlCGatePassNo.SelectedItem.Value+"')

I'll not criticize the way you are building this query, but at least it is better looking that way. Now as a solution, perhaps there is a null value on one of those dropdowns?

C#

string sql = "select GatePassNo, CheckIN_Date,Customer_Name,State, " +
 "City,Customer_Location from Product_Details " +
  "where ( 1=1 " +
  ddlCName.SelectedItem.Value != null ? " " : ("or Customer_Name='" + ddlCName.SelectedItem.Value + "' ") +
  DropDownList2.SelectedItem.Value != null ? " " : ("or State='" + DropDownList2.SelectedItem.Value + "' ") +
  DropDownList3.SelectedItem.Value != null ? " " : ("or City='" + DropDownList3.SelectedItem.Value + "' ") +
  DropDownList1.SelectedItem.Value != null ? " " : ("or Status='" + DropDownList1.SelectedItem.Value + "' ") +
  ddlCGatePassNo.SelectedItem.Value != null ? " " : ("or GatePassNo='" + ddlCGatePassNo.SelectedItem.Value + "')");

My or clause is not working please help.

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0