how to change label forecolor at runtime

Question

3.40/5 (2 votes)

See more:

i try to make MDI application.i add a label at runtime and i want to change color of text label with color dialog. i try to use the following code

C#

private void colorToolStripMenuItem_Click(object sender, EventArgs e)
        {
            Form actif = this.ActiveMdiChild;
            Label label = (Label)actif.ActiveControl;
            Label lbl = new Label();
            
            ColorDialog colordialog1 = new ColorDialog();
            if (colordialog1.ShowDialog()!=System.Windows.Forms.DialogResult.Cancel)
            {
                lbl.ForeColor = colordialog1.Color; //error
            }      

        }

how can i change properties of label at runtime ?

Posted 23-May-14 9:04am

Muhammad Iqbal Suzetta

Updated 17-May-20 8:36am

Add a Solution

Comments

[no name] 23-May-14 15:18pm

Even if you did not get whatever error you are getting, you are creating a new label, setting the forecolor and then letting go out of scope without doing anything else with it. What error is it that you are getting?

Abhishek Sivasubramanian 23-May-14 15:22pm

Are you getting some error on that line you highlighted OR your problem is that you cannot see the forecolor being applied ?

If later is the case, you need to place the dynamically generated label to the form's control collection or a panel. Then only you can see that.

[no name] 23-May-14 15:29pm

Try to solve it step by step.
Are you sure that you ask the right property from ColorDialog?
Maybe not, so the next step is _not_ to assign the Color returned from the dlg, assign a fix value you are shure to recognize. If your Label does still not show this fix Color....then I'm out of order ;)

uups jsut have a look to solution 1 ;)

Emre Ataseven 25-May-14 7:45am

It doesn't look like a good way whatever you're trying to do

2 solutions

Solution 2

Label1.ForeColor = System.Drawing.Color.DodgerBlue;
Label1.ForeColor = System.Drawing.Color.red;

etc...

Posted 17-May-20 8:37am

Member 14835179

Updated 17-May-20 8:39am

v2

Comments

Dave Kreskowiak 17-May-20 15:02pm

Not an answer to the 6 year old question. You failed to understand the problem with the OP's code.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2014-05-23T09:21:00

You won't get an error there with the exact code you are showing - it won't do anything, but you won't get an error either.
You almost certainly will get an error if you try to set the ForeColor property of label though, as the MSDN page says very explicitly:

In order to receive a valid value from this property, the object that calls it must either contain or be contained in the control it is calling. If one form tries to call another form's ActiveControl properties, it will receive an undefined value. In this case, you need to define your own communication mechanism between the forms to pass this data.

Since that is definitely not the case here, you will get some odd errors occuring...

Don't do things like that: it's not exactly difficult to do it properly.
See here: Transferring information between two forms, Part 1: Parent to Child[^] and implement the "Property method"