Timer elapsing more than once

Question

0.00/5 (No votes)

See more:

Hello Friends,

Hello Friends, I am working on a timer based project. I need that the timer should elapse just once. I wrote the following code:

C#

class Program
   {
       static void Main(string[] args)
       {

           Start_Event_Timer("Rahul");
           Start_Event_Timer("Varinder");


           Console.ReadLine();
       }

       static Timer t;
       public static void Start_Event_Timer(string s1)
       {
           Console.WriteLine("Timer started for : {0} at {1}", s1, DateTime.Now.ToString());
           t = new System.Timers.Timer(60 * 1000);
           t.Enabled = true;
           t.Elapsed += (sender, e) => G_TIMER_ELAPSED(sender, e, s1);

           t.Start();
       }


       public static void G_TIMER_ELAPSED(object sender, ElapsedEventArgs e, string s1)
       {
           Console.WriteLine("Timer elapsed for :{0} at {1} ", s1, DateTime.Now.ToString());

           t.AutoReset = false;
           t.Enabled = false;
           t.Stop();
       }

     }

I will also show you the output which i captured from the console:

Quote:
Timer started for : Rahul at 4/25/2014 11:46:04 AM
Timer started for : Varinder at 4/25/2014 11:46:04 AM
Timer elapsed for :Rahul at 4/25/2014 11:47:04 AM
Timer elapsed for :Varinder at 4/25/2014 11:47:04 AM
Timer elapsed for :Rahul at 4/25/2014 11:48:04 AM
Timer elapsed for :Rahul at 4/25/2014 11:49:04 AM
Timer elapsed for :Rahul at 4/25/2014 11:50:04 AM
Timer elapsed for :Rahul at 4/25/2014 11:51:04 AM

Any suggestions? as to why is the timer being elapsed multiple times even if i started it once?

Posted 24-Apr-14 20:29pm

Rahul VB

Add a Solution

2 solutions

Solution 1

http://social.msdn.microsoft.com/Forums/vstudio/en-US/03e83a93-652f-4559-ba9e-f397b1755ad7/timerenabled-vs-timerstartstop-?forum=csharpgeneral

Posted 24-Apr-14 21:06pm

ccalma

Comments

Rahul VB 25-Apr-14 5:51am

Thanks for help

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Alan N · Accepted Answer · 2014-04-24T22:06:00

You are using one location, the static field t, to store two timer instances. The timer accessible via t is the last one assigned, "Varinder". Although the code is awful, it is possible to make it work as intended, like this :

C#

public static void G_TIMER_ELAPSED(object sender, ElapsedEventArgs e, string s1)
{
    Timer t = (Timer)sender;    
    Console.WriteLine("Timer elapsed for :{0} at {1} ", s1, DateTime.Now.ToString());

    t.AutoReset = false;
    t.Enabled = false;
    t.Stop();
}

The sender parameter in the event handler contains the invoking instance and so simply casting the object gets the correct Timer.

Alan.