Multiple Insert to SQL

Question

0.00/5 (No votes)

See more:

C#

try
            {
                if (txtDesc1.Text == "")
                {
                }
                else
                {
                    con1 = new SqlDbConnect();
                    strSQL = "insert into sample (id, description, dosage, qty, selling, amount)";
                    strSQL += "select '" + labelTransID.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtDesc1.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtDosage1.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtQty1.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtSelling1.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtAmount1.Text.Replace("'", "''") + "'";
                    con1.SqlQuery(strSQL);
                    con1.NonQueryEx();
                    con1.Close();
                }

                if (txtDesc2.Text == "")
                {
                }
                else
                {
                    con2 = new SqlDbConnect();
                    strSQL = "insert into sample (id, description, dosage, qty, selling, amount)";
                    strSQL += "select '" + labelTransID.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtDesc2.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtDosage2.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtQty2.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtSelling2.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtAmount2.Text.Replace("'", "''") + "'";
                    con2.SqlQuery(strSQL);
                    con2.NonQueryEx();
                    con2.Close();
                }
                if (txtDesc3.Text == "")
                {
                }
                else
                {
                    con3 = new SqlDbConnect();
                    strSQL = "insert into sample (id, description, dosage, qty, selling, amount)";
                    strSQL += "select '" + labelTransID.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtDesc3.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtDosage3.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtQty3.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtSelling3.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtAmount3.Text.Replace("'", "''") + "'";
                    con3.SqlQuery(strSQL);
                    con3.NonQueryEx();
                    con3.Close();
                }
                if (txtDesc4.Text == "")
                {
                }
                else
                {
                    con4 = new SqlDbConnect();
                    strSQL = "insert into sample (id, description, dosage, qty, selling, amount)";
                    strSQL += "select '" + labelTransID.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtDesc4.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtDosage4.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtQty4.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtSelling4.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtAmount4.Text.Replace("'", "''") + "'";
                    con4.SqlQuery(strSQL);
                    con4.NonQueryEx();
                    con4.Close();
                }
                if (txtDesc5.Text == "")
                {
                }
                else
                {
                    con5 = new SqlDbConnect();
                    strSQL = "insert into sample (id, description, dosage, qty, selling, amount)";
                    strSQL += "select '" + labelTransID.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtDesc5.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtDosage5.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtQty5.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtSelling5.Text.Replace("'", "''") + "'";
                    strSQL += ", '" + txtAmount5.Text.Replace("'", "''") + "'";
                    con5.SqlQuery(strSQL);
                    con5.NonQueryEx();
                    con5.Close();
                }
            }
            catch
            {
                MessageBox.Show("Successfully Saved", "Completed !", MessageBoxButtons.OK);
            }

here is my code for saving...problem is when the other textboxes are empty. won't save to sql database. is there any other approach to minimize this lot of codes.ty

Posted 16-Apr-14 1:19am

Member 10717094

Updated 16-Apr-14 1:29am

Mike Meinz

v2

Add a Solution

Comments

Mike Meinz 16-Apr-14 7:32am

Please use the SQLParameter class to remove the potential for SQL Injection attacks against your software. By taking data directly from TextBoxes and inserting it into dynamically created SQL INSERT statements, you provide a path for an attacker to damage your web site by altering or deleting data.

2 solutions

Solution 1

I suggest you, that first made xml of all data which you want to insert on front end, then send it into procedure and after that you can insert it from that xml.

Posted 16-Apr-14 1:37am

abhishek_singh

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Peter Leow · Accepted Answer · 2014-04-16T01:37:00

Try running this example and discover the mistakes in your code:

C#

using System;

public class Program
{
    public static void Main()
    {
        string str = "we're a nation";
        string str1 = str.Replace("'","''");
        Console.WriteLine(str);
        Console.WriteLine(str1);
    }
}

You also should
Use Parameterized queries to prevent SQL Injection Attacks in SQL Server [^]