can you please slove it

Question

0.00/5 (No votes)

See more:

C#

c1.con.Open();
string k = "NO";
DateTime start = DateTime.ParseExact(TextBox10.Text, "dd-MM-yyyy", System.Globalization.CultureInfo.InvariantCulture);
DateTime end = DateTime.ParseExact(TextBox11.Text, "dd-MM-yyyy", System.Globalization.CultureInfo.InvariantCulture);
c1.cmd.CommandText = "update" + Session["no"].ToString() + "set avail='" + k + "'where date between'" + start + "'and'" + end + "'";
ab = c1.cmd.ExecuteReader();
Label5.Visible = true;
c1.con.Close();

gives an error incorrect syntax near "="

Posted 10-Apr-14 11:30am

Member 10740448

Updated 10-Apr-14 22:56pm

phil.o

v3

Add a Solution

Comments

CHill60 10-Apr-14 17:37pm

On which line? the commandtext?

[no name] 10-Apr-14 17:42pm

Sure.... seen this same code several times in the past few days in homework assignments. You are missing a space in your where, (k + "' where)

2 solutions

Solution 2

Just debug that and take a look at c1.cmd.CommandText: you should immediately see that that is not a valid SQL query. There are no spaces between inidvidual parts of the query, it is something like
updatesession42set avail='NO'where date between'2014-04-08 00:00:00'and'2014-04-10 00:00:00'
Richard's answer shows you an excellent way for using SQL queries from code - but also there make sure that there are spaces!

Posted 10-Apr-14 22:16pm

Bernhard Hiller

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard C Bishop · Accepted Answer · 2014-04-10T11:41:00

It is not a good idea to concatenate string together to form queries. That leaves you susceptible to SQL Injection. You should be using parameterized queries. Also, your syntax is not spaced correctly for your query.

Use something like this:

c1.cmd.CommandText = "UPDATE tablename SET avail=@k WHERE date between @start and  @end";
c1.cmd.Parameters.AddWithValue("@k","NO");
c1.cmd.Parameters.AddWithValue("@start",DateTime.ParseExact(TextBox10.Text, "dd-MM-yyyy", System.Globalization.CultureInfo.InvariantCulture));
c1.cmd.Parameters.AddWithValue("@end",DateTime.ParseExact(TextBox11.Text, "dd-MM-yyyy", System.Globalization.CultureInfo.InvariantCulture));

The "tableName" should be replaced with the name of the table you want to updated. If the table is dynamic as well, then you can use the initial method you tried with the tablename I suppose.