Problem in String Array and Strings

Question

0.00/5 (No votes)

See more:

VB

dim AllPlayerInfo as string()

AllPlayerInfo = PlayerFile.split(vbcrlf)

If Not AllPlayerInfo.Length = 0 Then

            If AllPlayerInfo(1) = TextBox1.Text Then

                If AllPlayerInfo(2) = TextBox2.Text Then

                    MsgBox("Hello " & TextBox1.Text)

                    Return True
                    Exit Function

                End If

            End If

        End If
  MsgBox("Can't Find This Account .. , MsgBoxStyle.Information)

    Return False

The problem is it show the can't find msgbox
even AllPlayerInfo(1) = TextBox1.Text and AllPlayerInfo(2) = TextBox2.Text

How can i solve this

Posted 11-Jan-14 8:03am

Tarek Mohamed Abdalla

Updated 11-Jan-14 9:16am

CPallini

v2

Add a Solution

2 solutions

Solution 2

VB

dim AllPlayerInfo as string()

AllPlayerInfo = PlayerFile.split(vbcrlf)

If Not AllPlayerInfo.Length = 0 Then

            If AllPlayerInfo(0) = TextBox1.Text Then

                If AllPlayerInfo(1) = TextBox2.Text Then

                    MsgBox("Hello " & TextBox1.Text)

                    Return True
                    Exit Function

                End If

            End If
Else
  MsgBox("Can't Find This Account .. , MsgBoxStyle.Information)
End If

Return False

Posted 11-Jan-14 21:29pm

Imtiaz Dahar

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Shahan Ayyub · Accepted Answer · 2014-01-11T08:18:00

Try this:

VB

Dim AllPlayerInfo As String()

AllPlayerInfo = PlayerFile.Split(vbCrLf.ToCharArray, StringSplitOptions.RemoveEmptyEntries)

If Not AllPlayerInfo.Length = 0 AndAlso AllPlayerInfo(1).ToLower() = TextBox1.Text.ToLower() AndAlso AllPlayerInfo(2).ToLower() = TextBox2.Text.ToLower() Then
      MsgBox("Hello " & TextBox1.Text)
      Return True
Else
      MsgBox("Can't Find This Account .. ", MsgBoxStyle.Information)
      Return False
End If

Your messagebox always displays becuase you have written it outside the scope of IF..THEN..ELSE statement. By doing this it will display iff the "Length" property returns zero, which is your intentions i guess.

Hope it helps!

EDIT

First of all, the code has been modified. I have figured out a couple of things is your code.

1) No need to EXIT FUNCTION when there is already RETURN statement present. So remove it.
2) Change:

PlayerFile.Split(vbCrLf)

to :

PlayerFile.Split(vbCrLf.ToCharArray, StringSplitOptions.RemoveEmptyEntries)

my guess is that you are getting a "vbLf" appended in front of the next array element which fails the comparison. So doing it this way will fix this issue.

3) When we compare strings it is preferred to make it either UPPER case or LOWER case, so i have used .ToLower(), depending upon case sensitivity. Please adjust it as per your scenario.

4) It is good to define ELSE part for each IF..ELSE IF condition, it helps to cover the rest of the cases so instead of defining three ELSE statements i have minimized the condition to one IF..ELSE statement.

Check it out. Hope it helps!

If you need further assistance please come up with sample values of variables and the desired result examples.

Happy coding!!!