Stored procedure error in c#

Question

0.00/5 (No votes)

See more:

Hai

I have a stored procedure "sampledata1".In the code behind file i am inserting the values into table by using stored procedure.But i am getting error "Procedure or function sampledata1 has too many arguments specified.".Below is the code.

Stored procedure;

create procedure sampledata1
(
@incidentnumber int,
@priority varchar(5),
@primaryimpactedarea varchar(50),
@secondaryimpactedarea varchar(50)
)
as
BEGIN
insert into Incidents(IncidentNumber,Priority,PrimaryImpactedArea,SecondaryImpactedArea)values(@incidentnumber,@priority,@primaryimpactedarea,@secondaryimpactedarea)
END

Button click event in codebehind:

SqlConnection con = new SqlConnection("Data Source=CDC015;Initial Catalog=Dashboard;User ID=Rash;Password=1111*");
       con.Open();
       SqlCommand cmd = new SqlCommand("sampledata1", con);
       cmd.CommandType = CommandType.StoredProcedure;
       try
       {

           cmd.Parameters.AddWithValue("@incidentnumber", txtIncidentNumber.Text);
           cmd.Parameters.AddWithValue("@priority", txtPriority.Text);
           string n = string.Empty;
           foreach (ListItem li in lstPrimaryImpactedArea.Items)
           {
               if (li.Selected == true)
               {
                   n += lstPrimaryImpactedArea.SelectedItem.Value;
                   cmd.Parameters.AddWithValue("@primaryimpactedarea", n);
               }
           }


           //cmd.Parameters.AddWithValue("@primaryimpactedarea",lstPrimaryImpactedArea.SelectedItem.Text);
           cmd.Parameters.AddWithValue("@secondaryimpactedarea",lstSecondaryImpactedArea.SelectedItem.Text);




            cmd.ExecuteNonQuery();
       }
       catch
       {
           throw;
       }
       finally
       {
           cmd.Dispose();
           con.Close();
           con.Dispose();
       }

Thanks in advance

Posted 11-Dec-13 18:05pm

Member 10234093

Updated 11-Dec-13 18:41pm

♥…ЯҠ…♥

v2

Add a Solution

Comments

♥…ЯҠ…♥ 12-Dec-13 0:31am

Debug and see how many parameters are passed to the stored proc?

Member 10234093 12-Dec-13 0:33am

I have debugged the code.Arguments that are passed in SP is 4 only.In code behind also only 4 arguments.Maybe in foreach loop there is some mistake.Could you plz clarify this.

2 solutions

Solution 1

Check This line is correct or not:-
you have mentioned sampledata1 Sp and you passing that parameters to sampledata2.
SqlCommand cmd = new SqlCommand("sampledata2", con);

Posted 11-Dec-13 18:26pm

TrushnaK

Comments

Member 10234093 12-Dec-13 0:28am

sry.It is sampledata1 only.But still i am getting that error.I think in foreach loop it is mistake.Can u plz help me

TrushnaK 12-Dec-13 0:40am

ya that is problem
what you want to do in foreach loop.

Member 10234093 12-Dec-13 1:40am

To select multiple items in listbox

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

♥…ЯҠ…♥ · Accepted Answer · 2013-12-11T18:40:00

Hi,

Lemme guess you are iterating parameters inside foreach,
try the below code and check

C#

foreach (ListItem li in lstPrimaryImpactedArea.Items)
            {
                if (li.Selected == true)
                {
                    n += lstPrimaryImpactedArea.SelectedItem.Value;
                   //cmd.Parameters.AddWithValue("@primaryimpactedarea", n); Deprecate it and assign after loop
                }
            }
cmd.Parameters.AddWithValue("@primaryimpactedarea", n);

Updated as per your comments:

You can use SelectedItems to get desired selected items from listbox like this

C#

for (int i = 0; i < ListBox1.Items.Count; i++)
            {
                if (ListBox1.Items[i].Selected)
                {
                    n += ListBox1.Items[i].Value;
                }
            }

Hope this helps you a bit.

Regards,
RK