approve error in asp.net

Question

1.00/5 (1 vote)

See more:

I >am trying to approve documents in asp.net when admin login then they approve documents 2 or 3 days ago code works fine now when i again open my project and approve documents it shows me error "Input string was in correct format "

here is the button code.

C#

protected void Button1_Click(object sender, EventArgs e)
    {

        string connStr = 
        ConfigurationManager.ConnectionStrings["mydms"].ConnectionString;
        SqlConnection mySQLconnection = new SqlConnection(connStr);


        try{
            mySQLconnection.Open();
        for (int i = 0; i < Repeater2.Items.Count; i++)
        {
            DropDownList DropDownListcontrol =
            ((DropDownList)Repeater2.Items[i].FindControl("DropDownList4"));
            Label DocId = ((Label)Repeater2.Items[i].FindControl("DocId"));
             SqlCommand cmd = new SqlCommand("approveddd", mySQLconnection);
             cmd.CommandType = CommandType.StoredProcedure;
             cmd.Parameters.Add("@DocID", SqlDbType.Int).Value = 
             Convert.ToInt32((DocId.Text));

                cmd.Parameters.Add("@ApproveID", SqlDbType.Int).Value = 
              Convert.ToInt32(DropDownListcontrol.SelectedValue);
                cmd.Parameters.Add("@ApproveBy", SqlDbType.VarChar, 50).Value =
              (Session["Login2"]);

                cmd.ExecuteNonQuery();

                DMSLIB.Doc myDoc = new DMSLIB.Doc();
                myDoc.MarkDocAs(Convert.ToInt16(DocId.Text), 
             Convert.ToInt32(DropDownListcontrol.SelectedValue));

            }
        }
           catch (Exception ex)
            {
                apfi.Text = "Error";
            }
         finally
        {
            mySQLconnection.Close();
        }
        }

please any one tell me where is the problem occur... ??

Posted 13-Nov-13 3:04am

Diya Ayesa

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Kornfeld Eliyahu Peter · Accepted Answer · 2013-11-13T03:10:00

Solution 1

"Input string was in correct format" error came from Convert.ToInt32.
It means, that the value you just passed can not be converted to int.
To see where exactly the error occurs, remove the try-catch-finally block and run again.

Posted 13-Nov-13 3:10am

Kornfeld Eliyahu Peter

Comments

Diya Ayesa 13-Nov-13 9:15am

so what i write instead of try catch

Kornfeld Eliyahu Peter 13-Nov-13 9:19am

Nothing. It's not the source of the error. Removing it will help you find out which of the two Convert.ToInt32 causes the error, and in turn it will tell you the source of the error...

Diya Ayesa 13-Nov-13 9:24am

removing try catch may be bracket error comes in this...//catch (Exception ex)
//{
apfi.Text = ex.Message;
//}

Kornfeld Eliyahu Peter 13-Nov-13 10:05am

Of course, you have no ex... Comment this line out too...

Kornfeld Eliyahu Peter 14-Nov-13 6:27am

It's because you didn't commented out finally - it's part of the try complex...

Diya Ayesa 14-Nov-13 6:35am

ok now i try this ...
protected void Button1_Click(object sender, EventArgs e)
{

string connStr = ConfigurationManager.ConnectionStrings["mydms"].ConnectionString;
SqlConnection mySQLconnection = new SqlConnection(connStr);
if (mySQLconnection.State == ConnectionState.Closed)
{
mySQLconnection.Open();

for (int i = 0; i < Repeater2.Items.Count; i++)
{
DropDownList DropDownListcontrol = ((DropDownList)Repeater2.Items[i].FindControl("DropDownList4"));
Label DocId = ((Label)Repeater2.Items[i].FindControl("DocId"));

SqlCommand cmd = new SqlCommand("approveddd", mySQLconnection);
cmd.CommandType = CommandType.StoredProcedure;

cmd.Parameters.Add("@DocID", SqlDbType.Int).Value = Convert.ToInt32((DocId.Text));

cmd.Parameters.Add("@ApproveID", SqlDbType.Int).Value = Convert.ToInt32(DropDownListcontrol.SelectedValue);
cmd.Parameters.Add("@ApproveBy", SqlDbType.VarChar, 50).Value = (Session["Login2"]);

cmd.ExecuteNonQuery();
//UPDATE APPPROVEID IN DOCUMENTINFO TABLE
DMSLIB.Doc myDoc = new DMSLIB.Doc();
myDoc.MarkDocAs(Convert.ToInt16(DocId.Text), Convert.ToInt32(DropDownListcontrol.SelectedValue));

}

}
else
{
apfi.Text = "Error";
}
if (mySQLconnection.State == ConnectionState.Open)
{
mySQLconnection.Close();
}
}

it shows me error in this line ...

line
cmd.Parameters.Add("@DocID", SqlDbType.Int).Value = Convert.ToInt32((DocId.Text));

error:Input String was not in correct format

Kornfeld Eliyahu Peter 14-Nov-13 6:37am

What value DocId.Text has?

Diya Ayesa 14-Nov-13 6:46am

it is in int in database and then value is save when in database ..when user upload document in documentinfo table then i set a rpimary key in docid in table ..like this
docid docname uploadedby
1 abc def

Kornfeld Eliyahu Peter 14-Nov-13 6:52am

No. For sure not.
DocId is a variable holding reference to a label on you page. It has a property called Text. That property has an actual value that can not be converted to int. What the value is?

Diya Ayesa 14-Nov-13 6:53am

in html?

Diya Ayesa 14-Nov-13 6:53am

in html like this.... <td>
<asp:Label Id="DocId" runat="server">
<%#DataBinder.Eval(Container.DataItem, "DocID")%>
</td>

Kornfeld Eliyahu Peter 14-Nov-13 7:25am

No. You got an error, right. You know the line. Put a breakpoint on that line and check the value...

Diya Ayesa 14-Nov-13 7:48am

i write like this in html and it works <asp:Label Id="DocId" text='<%#DataBinder.Eval(Container.DataItem, "DocID")%>' runat="server">

thanku so much for ur suggestions

Kornfeld Eliyahu Peter 14-Nov-13 7:54am

I'm glad to help.
Please don't feel offended, but I have to speak up my mind...
If you wan't to become a programmer, IMHO, you must stop now for a while.
Take some books - on-line maybe - and learn the basics. I can see from your code and from the questions you asked that you have a very poor basic. You don't know - and don't understand - ASP.NET. You don't aware of the capabilities of you development environment. You must learn this things BEFORE you start real programming...
Good luck!