problems while trying to optimize my SQL(inner join and group)

Question

0.00/5 (No votes)

See more:

SQL-Server-2005

Im having a problem in joining and grouping two table. Im using ms sql server 2005 express .

I also tried GROUP BY otd.task,otd.date_request,ot.approved_by but it gives me this error:

SQL

Column 'otd.userid' is invalid in the select list because it is not contained in either an aggregate function or the GROUP BY clause.

Thank you in advance!

Posted 11-Sep-13 17:58pm

Uknownymous

Updated 16-Sep-13 13:55pm

v2

Add a Solution

Comments

Dholakiya Ankit 16-Sep-13 23:31pm

otd.userid is not in a group by clause add that one in the seleted list

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

chaau · Answer 1 · 2013-09-11T18:27:00

I think you need to add date_request into the join criteria, otherwise your join does not generate unique results:

SQL

SELECT otd.userid,otd.task,otd.date_request,ot.approved_by 
FROM otd INNER JOIN ot ON otd.userid = ot.requested_by AND otd.date_request = ot.date_request 
WHERE otd.userid ='xxx' 
AND CONVERT(varchar,otd.date_request,101) BETWEEN '09/10/2013' AND '09/11/2013' 
AND ot.status ='A'
ORDER BY otd.date_request,ot.date_request ASC

Mahesh Bailwal · Answer 2 · 2013-09-11T18:32:00

Solution 2

You can also use distinct

SELECT distinct otd.userid,otd.task,otd.date_request,ot.approved_by 
FROM otd INNER JOIN ot ON otd.userid = ot.requested_by
WHERE otd.userid ='xxx' 
AND CONVERT(varchar,otd.date_request,101) BETWEEN '09/10/2013' AND '09/11/2013' 
AND ot.status ='A'
ORDER BY otd.date_request,ot.date_request ASC

Posted 11-Sep-13 18:32pm

Mahesh Bailwal

Comments

chaau 12-Sep-13 0:38am

distinct will produce the same result. Have a look at date_request

PRAKASH1034 · Answer 3 · 2013-09-11T19:09:00

Solution 3

Try this....

select otd.userid,otd.task,otd.date_request,ot.apporved_by from otd left join ot on otd.userid=ot.requested_by  where otd.userid='xxx' and ot.date_request=otd.date_request  order by apporved_by

Posted 11-Sep-13 19:09pm

PRAKASH1034

Comments

Member 9848727 12-Sep-13 12:45pm

SELECT
otd.userid,
otd.task,
otd.date_request,
ot.approved_by
FROM
otd
INNER JOIN
ot ON otd.userid = ot.requested_by
and otd.date_request = ot.date_request
WHERE
otd.userid ='xxx'
AND CONVERT(varchar,otd.date_request,101) BETWEEN '09/10/2013' AND '09/11/2013'
AND ot.status ='A'
ORDER BY otd.date_request,ot.date_request ASC

problems while trying to optimize my SQL(inner join and group)

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0

Existing Members

...or Join us