How can i stop comparasion between null=="" ?

Question

0.00/5 (No votes)

See more:

what i am doing is

if(emp.name!=this.name)
{

//I am adding it to audit trail .

}

but sometimes if emp.name=null and this.name="" the if statement gets executed as the condign is true and in my audit grid old value= blank and new value = blank gets speedily ... which i don't want to

how can i this condion makes fall

Posted 15-Sep-13 22:28pm

Torakami

Add a Solution

4 solutions

Solution 1

Change the condition to

if(!String.IsNullOrEmpty(emp.name) && (emp.name!=this.name))

Posted 15-Sep-13 22:30pm

ArunRajendra

Solution 2

C#

if (!string.IsNullOrEmpty(emp.name) && !string.IsNullOrEmpty(this.name) && (emp.name != this.name)) {
   // Whatever
}

[EDIT] Solution for specific case when one of the terms is null and the other is empty

C#

if (!((emp.name == null && this.name == String.Empty) || (emp.name == String.Empty && this.name == null)) && (emp.name != this.name)) {
   // Whatever
}

There should be a way to simplify these conditions but I do not have time for that now.

[/EDIT]

Posted 15-Sep-13 22:32pm

phil.o

Updated 16-Sep-13 0:22am

v2

Comments

Torakami 16-Sep-13 5:42am

wither of them can be null or empty .. but they should not be equal if one of them is null and other is ""

phil.o 16-Sep-13 6:11am

I do not have time to test that for now, bit I thought a comparison with any of both terms being null would return false.
If this is not the case for you, then see my updated solution.

Solution 3

I think best approach to your problem is convert.tostring()

as per my knowledge it handles null values

so your new comparison would be

C#

if(convert.tostring(emp.name)!=convert.tostring(this.name))
{

//I am adding it to audit trail .

}

regards...:)

Posted 15-Sep-13 22:36pm

Dholakiya Ankit

Comments

Torakami 16-Sep-13 5:39am

No .. convert.tostring doesnt work for me .. it takes null !="" only which is failing my logic ..

Dholakiya Ankit 16-Sep-13 5:42am

why not working what your emp.name value and this.name value give me full data this should work this will convert null value to "" which you want

Torakami 16-Sep-13 6:14am

if (emp.ReasonForLeaving != this.ReasonForLeaving)
{
objempAudit = new ActusLibrary.Linq.EmployeeAudit();
objempAudit.Module = "Employee";
objempAudit.ReferencedId = emp.Id;
objempAudit.OldValue = emp.ReasonForLeaving;
objempAudit.NewValue = this.ReasonForLeaving;
objempAudit.Operation = "Update";
objempAudit.Operation_status = "Success";
objempAudit.ModifiedOn = DateTime.Now;
objempAudit.ModifiedBy = ApConfig.CurrentUser.EmpId;
objempAudit.CompanyId = emp.Company_Id;
objempAudit.ColumnName = "Reason For Leaving";
lstEmpAudit.Add(objempAudit);

emp.ReasonForLeaving = this.ReasonForLeaving;
}

this is what my code is i am using in order to add it to audit trail .. I tried with your own way .. still if emp.ReasonForLeaving =null and this.ReasonForLeaving ="" both are not equating and i am falining to build my logic

Torakami 16-Sep-13 6:16am

if any one is null or empty with other string to compare then will be fine ... coz i want to disply old value and new value ... so one can be blank and other can be value ... but not both should gets diplsyed blank coz both are not equating null = ""

Dholakiya Ankit 16-Sep-13 6:23am

i think you want that previous reason for leaving and this reason both should not be equal or both should not be empty right?

Torakami 16-Sep-13 7:02am

yes .. both should not be equal and both can not be empty ... but in database few values are set to null .. so when i compare it null = blank which is value from current object .. they both gets equated and my final reason is i am getting is both blank

Dholakiya Ankit 16-Sep-13 7:19am

yes then this should be your answer if you getting both blank then in the else condition you have to write your data
like

if(convert.tostring(emp.name)!=convert.tostring(this.name))

{
objempAudit = new ActusLibrary.Linq.EmployeeAudit();
}
else
{
your database conditions
}

:)

Torakami 16-Sep-13 7:35am

Dude... this is not working .. its still equating null with blank .. I told you already

Dholakiya Ankit 16-Sep-13 8:04am

can you put your code?

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ErBhati · Accepted Answer · 2013-09-16T00:52:00

Solution 4

C#

if (!((emp.name == null && this.name == String.Empty) || (emp.name == String.Empty && this.name == null)) && (emp.name != this.name)) 
{
   // do other things here
}

Posted 16-Sep-13 0:52am

ErBhati