Details view control asp.net

Question

0.00/5 (No votes)

See more:

Hi,
I have this details view control where users enter their leave application I have used the if statement to set conditions but the details are still inserted even when the conditions are not met. I have tried using exit sub but its giving the same result.
Here is the code.

VB

If days <= 1 Then
            Label3.Visible = True
            lvconn.Close()
            Exit Sub
        ElseIf days >= 30 Then
            Label4.Visible = True
            lvconn.Close()
            Exit Sub
        Else
            Response.Redirect("Leave_details.aspx")
        End If

Posted 27-Jan-11 2:03am

larsh from Nairobi

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Ryan Zahra · Answer 1 · 2011-01-27T02:17:00

Solution 1

Is this code in a loop?
If so you could use Exit For or Exit Do which will exit from a for loop and a do loop respectively.

Posted 27-Jan-11 2:17am

Ryan Zahra

Updated 27-Jan-11 2:40am

v2

Comments

larsh from Nairobi 27-Jan-11 8:21am

Ryan, its just an if statement with two conditions nothing much.
Thanks 4 the advice.

Ryan Zahra 27-Jan-11 8:23am

Can I see the whole method instead?

larsh from Nairobi 27-Jan-11 8:31am

Its here.

Protected Sub LinkButton1_Click1(ByVal sender As Object, ByVal e As System.EventArgs)
Dim lvconn As New SqlConnection("Data Source=MARS\SQLEXPRESS;Initial Catalog=leave;Persist Security Info=True;User ID=sa;Password=charkushck")
Dim cmd As New SqlCommand()
cmd.Connection = lvconn
Dim tdate, fdate As Date
Dim fdate2 As TextBox = CType(DetailsView1.FindControl("fdate2"), TextBox)
Dim tdate1 As TextBox = CType(DetailsView1.FindControl("tdate1"), TextBox)
tdate = tdate1.Text
fdate = fdate2.Text
Dim ts As TimeSpan = tdate.Subtract(fdate)
Dim days As Integer = ts.Days
lvconn.Open()
If days <= 1 Then
Label3.Visible = True
lvconn.Close()
Exit Sub
ElseIf days >= 30 Then
Label4.Visible = True
lvconn.Close()
Exit Sub
Else
Response.Redirect("Leave_details.aspx")
End If
End Sub

Ryan Zahra 27-Jan-11 8:39am

I must ask why you are opening the connection and not always closing it, apart from not being in a try catch finally block.

Also try to debug your code and watch the variables value. What are the values of tdate and fdate? Are you sure they are storing the date correctly? Also what is the value of days?

larsh from Nairobi 27-Jan-11 8:46am

First, about the opening and closing of the connection its something I was trying to fix the problem.

For the variables tdate and fdate am just using them in the timespan since am certain it cant accept to use the text boxes(fdate2&tdate1).

Ryan Zahra 27-Jan-11 8:58am

Dim txtFDate = CType(DetailsView1.FindControl("fdate2"), TextBox)
Dim txtTDate = CType(DetailsView1.FindControl("tdate1"), TextBox)

Dim fDate As Date = CDate(txtTDate.Text)
Dim tDate As Date = CDate(txtTDate.Text)

Dim ts As TimeSpan = tDate.Subtract(tDate)
Dim days As Integer = ts.Days

larsh from Nairobi 27-Jan-11 9:16am

@Ryan, even when I apply your code it still enters wrong values to the table.
What should I do about that?

Ryan Zahra 27-Jan-11 9:18am

Are you debugging your code? Where is the problem with your data?

larsh from Nairobi 27-Jan-11 9:22am

Its a logical error, the if statement am using is supposed to impose the condition on the user of which the wrong shouldn't enter into the table after the label has been displayed but instead the details still enter the table.
That's actually my problem.
I really appreciate ur help.

Ryan Zahra 27-Jan-11 9:30am

Dim ts is holding the date and time difference. This means that ts can hold a difference of less than a day. This means that ts can even hold a number of hours.

In your first if statement, this first condition is to check if the number of days is 1 or less. Thus having between 0 and 24 hours. In the else if statement, you are checking if the number of days is greater than or equals to 30 days.

I'm asking you to debug you code in order to know the value of ts and which if statement the program will execute.

larsh from Nairobi 27-Jan-11 9:36am

The statement executes well.
It checks both conditions but it still posts to the table. So how do I stop the wrong data from entering the table?

Ryan Zahra 27-Jan-11 9:42am

I cannot tell you why because I dont have all your code. Please post your code in order to help you out.

larsh from Nairobi 28-Jan-11 1:40am

Ryan, here's the whole code please assist.
asp.net
<%@ Page Language="VB" MasterPageFile="~/Site.master" AutoEventWireup="false" CodeFile="Leave_insert.aspx.vb" Inherits="Leave_insert" title="Leave Application." %>
<asp:Content ID="Content1" ContentPlaceHolderID="Maincontent" Runat="Server">
<asp:DetailsView ID="DetailsView1" runat="server" AutoGenerateRows="False"
BackColor="#DEBA84" BorderColor="#DEBA84" BorderStyle="None" BorderWidth="1px"
CellPadding="3" CellSpacing="2" DataKeyNames="Leave_ID" DataSourceID="SqlDataSource1"
DefaultMode="Insert" Height="86px" Width="338px">
<footerstyle backcolor="#F7DFB5" forecolor="#8C4510">
<rowstyle backcolor="#FFF7E7" forecolor="#8C4510">
<PagerStyle ForeColor="#8C4510" HorizontalAlign="Center" />
<fields>
<asp:TemplateField HeaderText="Leave_Days" SortExpression="Leave_Days">
<edititemtemplate>
<asp:TextBox ID="TextBox1" runat="server" Text='<%# Bind("Leave_Days") %>'></asp:TextBox>

<insertitemtemplate>
<asp:TextBox ID="TextBox1" runat="server" Text='<%# Bind("Leave_Days") %>'></asp:TextBox>

<itemtemplate>
<asp:Label ID="Label1" runat="server" Text='<%# Bind("Leave_Days") %>'></asp:Label>

</asp:TemplateField>
<asp:TemplateField HeaderText="Leave_ID" SortExpression="Leave_ID">
<edititemtemplate>
<asp:Label ID="Label1" runat="server" Text='<%# Eval("Leave_ID") %>'></asp:Label>

<insertitemtemplate>
<asp:TextBox ID="TextBox2" runat="server" Text='<%# Bind("Leave_ID") %>'></asp:TextBox>

<itemtemplate>
<asp:Label ID="Label2" runat="server" Text='<%# Bind("Leave_ID") %>'></asp:Label>

</asp:TemplateField>
<asp:TemplateField HeaderText="From_Date" SortExpression="From_Date">
<edititemtemplate>
<asp:TextBox ID="fdate2" runat="server" Text='<%# Bind("From_Date") %>'></asp:TextBox>

<insertitemtemplate>
<asp:TextBox ID="fdate2" runat="server" Text='<%# Bind("From_Date") %>'></asp:TextBox>

<itemtemplate>
<asp:Label ID="Label3" runat="server" Text='<%# Bind("From_Date") %>'></asp:Label>

</asp:TemplateField>
<asp:TemplateField HeaderText="To_Date" SortExpression="To_Date">
<edititemtemplate>
<asp:TextBox ID="tdate1" runat="server" Text='<%# Bind("To_Date") %>'></asp:TextBox>

<insertitemtemplate>
<asp:TextBox ID="tdate1" runat="server" Text='<%# Bind("To_Date") %>'></asp:TextBox>

<itemtemplate>
<asp:Label ID="Label4" runat="server" Text='<%# Bind("To_Date") %>'></asp:Label>

</asp:TemplateField>
<asp:TemplateField HeaderText="Approval" SortExpression="Approval">
<edititemtemplate>
<asp:CheckBox ID="CheckBox1" runat="server" Checked='<%# Bind("Approval") %>' Enabled="False" />

<insertitemtemplate>
<asp:CheckBox ID="CheckBox1" runat="server

Ryan Zahra 28-Jan-11 3:18am

I want the vb code not the asp.net code

larsh from Nairobi 28-Jan-11 3:35am

I posted both but it seems it didn't come through, its here...
Imports System.Data
Imports System.Data.SqlClient
Partial Class Leave_insert
Inherits System.Web.UI.Page

Protected Sub LinkButton2_Click1(ByVal sender As Object, ByVal e As System.EventArgs)
Response.Redirect("User_details_Table.aspx")
End Sub

Protected Sub LinkButton1_Click1(ByVal sender As Object, ByVal e As System.EventArgs)
Dim lvconn As New SqlConnection("Data Source=MARS\SQLEXPRESS;Initial Catalog=leave;Persist Security Info=True;User ID=sa;Password=charkushck")
Dim cmd As New SqlCommand()
cmd.Connection = lvconn
Dim txtfdate = CType(DetailsView1.FindControl("fdate2"), TextBox)
Dim txttdate = CType(DetailsView1.FindControl("tdate1"), TextBox)
Dim tdate As Date = CDate(txttdate.Text)
Dim fdate As Date = CDate(txtfdate.Text)
Dim ts As TimeSpan = tdate.Subtract(fdate)
Dim days As Integer = ts.Days
lvconn.Open()
If days <= 1 Then
Label3.Visible = True
Exit Sub
ElseIf days >= 30 Then
Label4.Visible = True
Exit Sub
Else
Response.Redirect("Leave_details.aspx")
End If
lvconn.Close()
End Sub
End Class

Ryan Zahra 28-Jan-11 3:44am

From the code that you gave me, there is no code that saves any data to the database.