LinQ VS Normal Code (Sql Data Adapter vs Sql Data Reader)

Question

1.00/5 (1 vote)

See more:

Hi,

Which is the best way to implement following two methods in my code

C#

class Sample
{
public string Name {get; set;}
public int ID {get; set;}
}

C#

//Method 1
var list =(from row in ds.Tables[0].AsEnumerable()
                                         select new Sample
                                         {
                                             Name= row.Field<string>("Name"),
                                             ID= row.Field<int>("ID")
                                         }
                                          ).ToList();

C#

//Method 2
List<Sample> sampleList = new List<Sample>(); 
while(sqlDataReader.Read())
{
Sample s1 = new Sample();
s1.Name = (string)sqlDataReader["Name"];
s1.ID = (int)sqlDataReader["ID"];
sampleList.Add(s1);
}

both codes can able to generate generic list object but,
in the first method i am using SqlDataAdapter and then convert the dataset to list using LINQ
In the second method, i am using SqlDataReader and convert the result as list

I want to know which the right way of using these two technique in my code.
I thought Method 2 is optimized way... Is it right?

Regards,
--Sj

Posted 10-Jun-13 3:58am

codeninja-C#

Updated 11-Jun-13 3:33am

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

**Zoltán Zörgő** · Answer 1 · 2013-06-10T06:10:00

It depends.

Don't combine technologies that are meant to replace each-other.
Method 1 is LINQ, but it isn't LINQ to SQL, because you use several explicit casting and that over dataset objects - actually this is an existing approach called LINQ to DataSet[^] - but as I see, this was meant only for transition.
I suggest you use either DataSet approach or LINQ to SQL, or Entity Framework.
Avoid using the integer indexer over the tables collection.

DataReader can be a good approach if the schema is simple, and you don't need bidirectional access - reporting is a good example. It consumes less resources and it is fast.

Umeshwaran.V · Answer 2 · 2013-06-10T05:19:00

Method1 is faster. Linq is having capability of handling memory. And easy to manage.
In case you want to utilize available cores in your system linq is the best option. you can easly parallalize.

And one more important thing is your code is not executed yet, until you consume variable list.

LinQ VS Normal Code (Sql Data Adapter vs Sql Data Reader)

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0