checking extention in a string that contain a file path

Question

1.00/5 (1 vote)

See more:

, +

hello, i have a form with a textBox and a label, i want to check if the textBox Text is finishing by ".pdf" or ".jpg", then i want to show the extention in the label :

C#

public Form1()
        {
            InitializeComponent();

            textBox1.Text = "http://www.site.com/Documents/file.pdf";

            Match matchPdf = Regex.Match(textBox1.Text, @"\*+(.pdf|.PDF)$/",
                RegexOptions.IgnoreCase);
            Match matchImg = Regex.Match(textBox1.Text, @"\*+(.jpeg|.JPEG|.gif|.GIF| .png|.PNG)$/",
                RegexOptions.IgnoreCase);

            if (matchPdf.Success)
            {
                label1.Text = "PDF";
            }
            else if (matchImg.Success)
            {
                label1.Text = "IMG";
            }
            else label1.Text = "UNIVERSAL";
        }

The label is always showing "Universal"... someone can help me please!

Posted 7-May-13 19:20pm

Nnorss

Updated 8-May-13 4:13am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2013-05-07T19:29:00

Solution 1

I can see at least one bug: at the very beginning, use '.+', not '\*+'. Just think about it: you are not looking for a wildcard, but for some file characters, and '*' cannot ever appear in a file name.

[EDIT]

Besides, you probably would need one more file naming scheme: .JPG. One more problem: you are not taking into account the names like *.GiF, *.GIf, *.Gif etc., as some user may legitimately use them. That said, you should not try to list all the cases, but rather need to use a case-insensitive Regex.

[END EDIT]

This Regex would not be comprehensive though: you should also check up for correct URI scheme, exclude the characters not allowed in paths, etc. Are you sure you the you want to validate it at all? Perhaps you could use one of the file dialogs? (I don't know, because I don't know your application.)

—SA

Posted 7-May-13 19:29pm

Sergey Alexandrovich Kryukov

Updated 8-May-13 4:32am

v2

Comments

Nnorss 8-May-13 10:08am

thanks for your attention, it is the first time that i use regex, i really need to validate the extention to tell the program what to do if its, pdf, what to do if it's jpeg.....

Sergey Alexandrovich Kryukov 8-May-13 10:17am

Is your problem solved?
—SA

Nnorss 8-May-13 10:20am

No! i'm still searching for the solution :s

Sergey Alexandrovich Kryukov 8-May-13 10:32am

What are the problems?
—SA

Nnorss 8-May-13 10:36am

problem resolved :D

Sergey Alexandrovich Kryukov 8-May-13 10:41am

Great, congratulations. Will you accept this answer formally (green button)? I've really found some bugs for you...
—SA

Nnorss 8-May-13 10:42am

sure!

Sergey Alexandrovich Kryukov 8-May-13 10:44am

Thanks. Good luck, call again.
—SA