data table values not being filled

Question

3.18/5 (3 votes)

See more:

In my web application i am trying to send gridview data in mail based on checkbox and radiobutton selection. Code for the same is as below:

C#

protected void Button1_Click(object sender, EventArgs e)
        {
            string nam = Request.QueryString["name"];
            string type = Request.QueryString["type"];
            string rn = Request.QueryString["code"];
            DataTable dtable = new DataTable();
            dtable.Columns.Add(new DataColumn("date", typeof(DateTime)));
            dtable.Columns.Add(new DataColumn("hf", typeof(float)));
            dtable.Columns.Add(new DataColumn("status", typeof(string)));
            Session["dt"] = dtable;
            SqlConnection conn = new SqlConnection();
            conn.ConnectionString = System.Configuration.ConfigurationManager.ConnectionStrings["leave"].ConnectionString;
            conn.Open();
            for (int i = 0; i < final.Rows.Count; i++)
            {
                dtable=(DataTable)Session["dt"];
                GridViewRow row = final.Rows[i];
                CheckBox chk=(CheckBox)row.Cells[3].FindControl("CheckBox1");                
                if (chk.Checked)
                {    
                
                    RadioButtonList rButton = (RadioButtonList)final.Rows[i].Cells[2].FindControl("RadioButtonList1");
                    if (rButton.SelectedValue == "Half")
                    {
                        //update database,fill gridview with data table values
                    }
                    else
                    {
                       //update database,fill gridview with data table values
                    }
                }
                else
                {
                    //Only this code is working
                }
            }            
            Gridview1.visible = true;
        }

In above code i have gridview with name,dates,radiobutton,checkbox.last two controls are templatefields.The problem is checkbox is checked or not is not working(the bold marked)..that is it enters the last 'else' evertime.Any help would be greatly appreciated....

Posted 17-Mar-13 23:07pm

Thanks7872

Updated 18-Mar-13 21:28pm

v7

Add a Solution

Comments

Jegan Thiyagesan 18-Mar-13 13:39pm

Can you try to reduce the unnecessary repeated code, it makes the overall code lengthy, difficult to read the code and definitely makes it hard to spot the problem.

1 solution

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jegan Thiyagesan · Answer 1 · 2013-03-18T07:37:00

Hi,

first of all, it is not an answer but a suggestion, can you refactor your code so that is readable?
for example:

C#

//-----------------------------------------------------------------
CheckBox cBox = (CheckBox)final.Rows[i].Cells[3].FindControl("CheckBox1");
if (cBox != null)
{
    RadioButtonList rButton = (RadioButtonList)final.Rows[i].Cells[2].FindControl("RadioButtonList1");
    if (rButton.SelectedValue == "Half")
    {
        UpdateDataTable(0.5, "Approved", dtable,  nam,  type,  rn,  conn);
    }
    else
    {
        UpdateDataTable(1.0, "Approved", dtable, nam, type, rn, conn);
    }
}
else
{
    UpdateDataTable(0.0, "Disapproved", dtable, nam, type, rn, conn);
}
//----------------------------------------------------------------------

private void UpdateDataTable(float hf, string status, DataTable dTable, string nam, string type, string rn, SqlConnection conn)
{
    DataRow dd = dtable.NewRow();
    dd["date"] = Convert.ToDateTime(final.Rows[i].Cells[1].Text);
    dd["hf"] = hf;
    dd["status"] = "Approved";
    dtable.Rows.Add(dd);
    GridView1.DataSource = dTable;
    GridView1.DataBind();
    SqlCommand cmd = new SqlCommand("insert into leave_rec VALUES('" + nam + "','" + dd["date"] + "','" + dd["hf"] + "','" + type + "','" + status + "')", conn);
    cmd.ExecuteNonQuery();
    calculate_half(type, nam);
    Session["dt"] = dTable;
}

Second, There are few things that I noticed, where you are parsing the wrong type on rButton check:

C#

dd["date"] = final.Rows[i].Cells[1].Text;
dd["hf"] = "1";

you have defined them as DateTime and float, but assigning them string.

Finally, this is where you are having the problem I guess, lines like this,

C#

CheckBox cBox = (CheckBox)final.Rows[i].Cells[3].FindControl("CheckBox1");

RadioButtonList rButton =(RadioButtonList)final.Rows[i].Cells[2].FindControl("RadioButtonList1");

How many controls a cell in a specific row can have in your application
If the cell can have only one control why don't you take that cell as the control, why are you searching for it?
i.e.

C#

CheckBox cBox = (CheckBox)final.Rows[i].Cells[3];

or if you know there is a check box control named "CheckBox1" then look for that control.
i.e.

C#

if (CheckBox1.checked)

I am not sure I answered your question, reducing unnecessary code will help you find the problem faster.

Regards
Jegan

data table values not being filled

1 solution

Solution 1

Add your solution here

Preview 0

data table values not being filled

1 solution

Solution 1

Add your solution here

Preview 0

Existing Members

...or Join us